* [PATCH] dmaengine: imx-sdma: Correct addr widths
@ 2017-09-14 5:39 Nicolin Chen
2017-09-14 18:42 ` Nicolin Chen
0 siblings, 1 reply; 2+ messages in thread
From: Nicolin Chen @ 2017-09-14 5:39 UTC (permalink / raw)
To: vinod.koul; +Cc: fabio.estevam, dan.j.williams, dmaengine, linux-kernel
The driver also supports 2_BYTES and 1_BYTE in sdma_prep_slave_sg().
So this patch just adds them to the lists.
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
---
drivers/dma/imx-sdma.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index a67ec1b..2be8d0d 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -178,6 +178,10 @@
#define SDMA_WATERMARK_LEVEL_HWE BIT(29)
#define SDMA_WATERMARK_LEVEL_CONT BIT(31)
+#define SDMA_DMA_BUSWIDTHS (BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) | \
+ BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) | \
+ BIT(DMA_SLAVE_BUSWIDTH_4_BYTES))
+
/*
* Mode/Count of data node descriptors - IPCv2
*/
@@ -1851,8 +1855,8 @@ static int sdma_probe(struct platform_device *pdev)
sdma->dma_device.device_prep_dma_cyclic = sdma_prep_dma_cyclic;
sdma->dma_device.device_config = sdma_config;
sdma->dma_device.device_terminate_all = sdma_disable_channel_with_delay;
- sdma->dma_device.src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);
- sdma->dma_device.dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);
+ sdma->dma_device.src_addr_widths = SDMA_DMA_BUSWIDTHS;
+ sdma->dma_device.dst_addr_widths = SDMA_DMA_BUSWIDTHS;
sdma->dma_device.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
sdma->dma_device.residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT;
sdma->dma_device.device_issue_pending = sdma_issue_pending;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: imx-sdma: Correct addr widths
2017-09-14 5:39 [PATCH] dmaengine: imx-sdma: Correct addr widths Nicolin Chen
@ 2017-09-14 18:42 ` Nicolin Chen
0 siblings, 0 replies; 2+ messages in thread
From: Nicolin Chen @ 2017-09-14 18:42 UTC (permalink / raw)
To: vinod.koul; +Cc: fabio.estevam, dan.j.williams, dmaengine, linux-kernel
On Wed, Sep 13, 2017 at 10:39:20PM -0700, Nicolin Chen wrote:
> The driver also supports 2_BYTES and 1_BYTE in sdma_prep_slave_sg().
> So this patch just adds them to the lists.
>
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Please ignore this one as I just found the "directions" is also
wrong. Sending a v2....
Thanks
Nicolin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-14 18:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-14 5:39 [PATCH] dmaengine: imx-sdma: Correct addr widths Nicolin Chen
2017-09-14 18:42 ` Nicolin Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).