[PATCH 0/3] SoM1 EK board fixes

[PATCH 0/3] SoM1 EK board fixes

[Claudiu Beznea]

Hi,

This series contains fixes for SAMA5D27 SoM1 EK board. It would be
good if we will have this in 4.14 version.

Thank you,
Claudiu

Ludovic Desroches (2):
  ARM: dts: at91: sama5d27_som1_ek: update pinmux/pinconf for LEDs and
    USB
  ARM: dts: at91: sama5d27_som1_ek: fix typos

Nicolas Ferre (1):
  ARM: dts: at91: sama5d27_som1_ek: fix USB host vbus

 arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

-- 
2.7.4

[PATCH 1/3] ARM: dts: at91: sama5d27_som1_ek: update pinmux/pinconf for LEDs and USB

[Claudiu Beznea]

From: Ludovic Desroches <ludovic.desroches@microchip.com>

There are some changes from the prototype board concerning LEDs and USB
pins:
- USBB power enable and red LED pins are inverted.
- The polarity of LEDs is inverted too.

Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
index 9c9088c99cc4..f13ef4fbab60 100644
--- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
+++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
@@ -67,7 +67,7 @@
 
 		usb1: ohci@00400000 {
 			num-ports = <3>;
-			atmel,vbus-gpio = <&pioA PIN_PA10 GPIO_ACTIVE_HIGH>;
+			atmel,vbus-gpio = <&pioA PIN_PA27 GPIO_ACTIVE_HIGH>;
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_usb_default>;
 			status = "okay";
@@ -330,7 +330,7 @@
 				};
 
 				pinctrl_led_gpio_default: led_gpio_default {
-					pinmux = <PIN_PA27__GPIO>,
+					pinmux = <PIN_PA10__GPIO>,
 						 <PIN_PB1__GPIO>,
 						 <PIN_PA31__GPIO>;
 					bias-pull-up;
@@ -396,7 +396,7 @@
 				};
 
 				pinctrl_usb_default: usb_default {
-					pinmux = <PIN_PA10__GPIO>,
+					pinmux = <PIN_PA27__GPIO>,
 						 <PIN_PD19__GPIO>;
 					bias-disable;
 				};
@@ -520,17 +520,17 @@
 
 		red {
 			label = "red";
-			gpios = <&pioA PIN_PA27 GPIO_ACTIVE_LOW>;
+			gpios = <&pioA PIN_PA10 GPIO_ACTIVE_HIGH>;
 		};
 
 		green {
 			label = "green";
-			gpios = <&pioA PIN_PB1 GPIO_ACTIVE_LOW>;
+			gpios = <&pioA PIN_PB1 GPIO_ACTIVE_HIGH>;
 		};
 
 		blue {
 			label = "blue";
-			gpios = <&pioA PIN_PA31 GPIO_ACTIVE_LOW>;
+			gpios = <&pioA PIN_PA31 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};
 	};
-- 
2.7.4

[PATCH 2/3] ARM: dts: at91: sama5d27_som1_ek: fix typos

[Claudiu Beznea]

From: Ludovic Desroches <ludovic.desroches@microchip.com>

Fix typos that prevent proper using of uart2 and uart4 devices.

Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
index f13ef4fbab60..be5cd913f274 100644
--- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
+++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
@@ -120,7 +120,7 @@
 				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_mikrobus2_uart>;
 				atmel,use-dma-rx;
-				atmel-use-dma-tx;
+				atmel,use-dma-tx;
 				status = "okay";
 			};
 
@@ -178,7 +178,7 @@
 			uart4: serial@fc00c000 {
 				atmel,use-dma-rx;
 				atmel,use-dma-tx;
-				pinctrl-name = "default";
+				pinctrl-names = "default";
 				pinctrl-0 = <&pinctrl_mikrobus1_uart>;
 				status = "okay";
 			};
-- 
2.7.4

[PATCH 3/3] ARM: dts: at91: sama5d27_som1_ek: fix USB host vbus

[Claudiu Beznea]

From: Nicolas Ferre <nicolas.ferre@microchip.com>

The USB host has 3 ports so we must specify the entries for each
in the atmel,vbus-gpio property.
The specified pin (PA27) is the vbus for USBB and not USBA.

Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
[claudiu.beznea@microchip.com: change subject to match the desired prefix]
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
index be5cd913f274..60cb084a8d92 100644
--- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
+++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
@@ -67,7 +67,10 @@
 
 		usb1: ohci@00400000 {
 			num-ports = <3>;
-			atmel,vbus-gpio = <&pioA PIN_PA27 GPIO_ACTIVE_HIGH>;
+			atmel,vbus-gpio = <0 /* &pioA PIN_PD20 GPIO_ACTIVE_HIGH */
+					   &pioA PIN_PA27 GPIO_ACTIVE_HIGH
+					   0
+					  >;
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_usb_default>;
 			status = "okay";
-- 
2.7.4

Re: [PATCH 0/3] SoM1 EK board fixes

[Nicolas Ferre]

On 14/09/2017 at 16:28, Claudiu Beznea wrote:
> Hi,
> 
> This series contains fixes for SAMA5D27 SoM1 EK board. It would be
> good if we will have this in 4.14 version.
> 
> Thank you,
> Claudiu
> 
> Ludovic Desroches (2):
>   ARM: dts: at91: sama5d27_som1_ek: update pinmux/pinconf for LEDs and
>     USB
>   ARM: dts: at91: sama5d27_som1_ek: fix typos

Additional:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
For those 2.

I merged them in a at91-4.14-fixes branch here:
https://git.kernel.org/pub/scm/linux/kernel/git/nferre/linux-at91.git/log/?h=at91-4.14-fixes

and merge it in at91-next. It should appear in tomorrow's linux-next.

Alexandre, do you agree with these 3 patches for fixes? Do you see other
patches to add to this "-fixes" branch? like:
ARM: at91: Replace uses of virt_to_phys with __pa_symbol
...

Do you want me to do the RP while you are at "Linux plumbers"?

Bye,

> Nicolas Ferre (1):
>   ARM: dts: at91: sama5d27_som1_ek: fix USB host vbus
> 
>  arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
> 


-- 
Nicolas Ferre

Re: [PATCH 0/3] SoM1 EK board fixes

[Alexandre Belloni]

On 14/09/2017 at 19:00:13 +0200, Nicolas Ferre wrote:
> On 14/09/2017 at 16:28, Claudiu Beznea wrote:
> > Hi,
> > 
> > This series contains fixes for SAMA5D27 SoM1 EK board. It would be
> > good if we will have this in 4.14 version.
> > 
> > Thank you,
> > Claudiu
> > 
> > Ludovic Desroches (2):
> >   ARM: dts: at91: sama5d27_som1_ek: update pinmux/pinconf for LEDs and
> >     USB
> >   ARM: dts: at91: sama5d27_som1_ek: fix typos
> 
> Additional:
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> For those 2.
> 
> I merged them in a at91-4.14-fixes branch here:
> https://git.kernel.org/pub/scm/linux/kernel/git/nferre/linux-at91.git/log/?h=at91-4.14-fixes
> 
> and merge it in at91-next. It should appear in tomorrow's linux-next.
> 
> Alexandre, do you agree with these 3 patches for fixes? Do you see other
> patches to add to this "-fixes" branch? like:
> ARM: at91: Replace uses of virt_to_phys with __pa_symbol
> ...
> 
> Do you want me to do the RP while you are at "Linux plumbers"?
> 

You can't send any PR this week because 4.14-rc1 has not been released
yet. You can't base your PR on anything useful...


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com