* [PATCH] i40e/i40evf: actually use u32 for feature flags
@ 2017-10-11 14:02 Arnd Bergmann
2017-10-11 22:21 ` Keller, Jacob E
2017-10-11 22:46 ` Jeff Kirsher
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-10-11 14:02 UTC (permalink / raw)
To: Jeff Kirsher
Cc: Arnd Bergmann, Jacob Keller, Alexander Duyck, Mitch Williams,
Filip Sadowski, intel-wired-lan, netdev, linux-kernel
A previous cleanup intended to change the flags variable to 32
bit instead of 64, but accidentally left out the important
part of that change, leading to a build error:
drivers/net/ethernet/intel/i40e/i40e_ethtool.o: In function `i40e_set_priv_flags':
i40e_ethtool.c:(.text+0x1a94): undefined reference to `wrong_size_cmpxchg'
This adds the missing modification.
Fixes: b74f571f59a8 ("i40e/i40evf: organize and re-number feature flags")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h
index 18c453a3e728..7baf6d8a84dd 100644
--- a/drivers/net/ethernet/intel/i40e/i40e.h
+++ b/drivers/net/ethernet/intel/i40e/i40e.h
@@ -424,7 +424,7 @@ struct i40e_pf {
#define I40E_HW_PORT_ID_VALID BIT(17)
#define I40E_HW_RESTART_AUTONEG BIT(18)
- u64 flags;
+ u32 flags;
#define I40E_FLAG_RX_CSUM_ENABLED BIT(0)
#define I40E_FLAG_MSI_ENABLED BIT(1)
#define I40E_FLAG_MSIX_ENABLED BIT(2)
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] i40e/i40evf: actually use u32 for feature flags
2017-10-11 14:02 [PATCH] i40e/i40evf: actually use u32 for feature flags Arnd Bergmann
@ 2017-10-11 22:21 ` Keller, Jacob E
2017-10-11 22:46 ` Jeff Kirsher
1 sibling, 0 replies; 3+ messages in thread
From: Keller, Jacob E @ 2017-10-11 22:21 UTC (permalink / raw)
To: Arnd Bergmann, Kirsher, Jeffrey T
Cc: Duyck, Alexander H, Williams, Mitch A, Sadowski, Filip,
intel-wired-lan, netdev, linux-kernel
> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Wednesday, October 11, 2017 7:03 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>; Keller, Jacob E
> <jacob.e.keller@intel.com>; Duyck, Alexander H
> <alexander.h.duyck@intel.com>; Williams, Mitch A
> <mitch.a.williams@intel.com>; Sadowski, Filip <filip.sadowski@intel.com>; intel-
> wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] i40e/i40evf: actually use u32 for feature flags
>
> A previous cleanup intended to change the flags variable to 32
> bit instead of 64, but accidentally left out the important
> part of that change, leading to a build error:
>
> drivers/net/ethernet/intel/i40e/i40e_ethtool.o: In function `i40e_set_priv_flags':
> i40e_ethtool.c:(.text+0x1a94): undefined reference to `wrong_size_cmpxchg'
>
> This adds the missing modification.
>
Hah good eyes. I'm guessing this got messed up in a patch re-ordering.
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
> Fixes: b74f571f59a8 ("i40e/i40evf: organize and re-number feature flags")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e.h
> b/drivers/net/ethernet/intel/i40e/i40e.h
> index 18c453a3e728..7baf6d8a84dd 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e.h
> @@ -424,7 +424,7 @@ struct i40e_pf {
> #define I40E_HW_PORT_ID_VALID BIT(17)
> #define I40E_HW_RESTART_AUTONEG BIT(18)
>
> - u64 flags;
> + u32 flags;
> #define I40E_FLAG_RX_CSUM_ENABLED BIT(0)
> #define I40E_FLAG_MSI_ENABLED BIT(1)
> #define I40E_FLAG_MSIX_ENABLED BIT(2)
> --
> 2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i40e/i40evf: actually use u32 for feature flags
2017-10-11 14:02 [PATCH] i40e/i40evf: actually use u32 for feature flags Arnd Bergmann
2017-10-11 22:21 ` Keller, Jacob E
@ 2017-10-11 22:46 ` Jeff Kirsher
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Kirsher @ 2017-10-11 22:46 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jacob Keller, Alexander Duyck, Mitch Williams, Filip Sadowski,
intel-wired-lan, netdev, linux-kernel
On Wed, 2017-10-11 at 16:02 +0200, Arnd Bergmann wrote:
> A previous cleanup intended to change the flags variable to 32
> bit instead of 64, but accidentally left out the important
> part of that change, leading to a build error:
>
> drivers/net/ethernet/intel/i40e/i40e_ethtool.o: In function
> `i40e_set_priv_flags':
> i40e_ethtool.c:(.text+0x1a94): undefined reference to
> `wrong_size_cmpxchg'
>
> This adds the missing modification.
>
> Fixes: b74f571f59a8 ("i40e/i40evf: organize and re-number feature
> flags")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
To slow... :-) I had already sent a fix for this on Monday to David.
Check David Miller's net-next tree, it is already there.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-11 22:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 14:02 [PATCH] i40e/i40evf: actually use u32 for feature flags Arnd Bergmann
2017-10-11 22:21 ` Keller, Jacob E
2017-10-11 22:46 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).