From: Tero Kristo <t-kristo@ti.com>
To: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<rafael.j.wysocki@intel.com>
Subject: [PATCH] PM / QoS: Fix default runtime_pm device resume latency
Date: Mon, 30 Oct 2017 09:10:46 +0200 [thread overview]
Message-ID: <1509347446-26105-1-git-send-email-t-kristo@ti.com> (raw)
The recent change to the PM QoS framework to introduce a proper
no constraint value overlooked to handle the devices which don't
implement PM QoS OPS. Runtime PM is one of the more severely
impacted subsystems, failing every attempt to runtime suspend
a device. This leads into some nasty second level issues like
probe failures and increased power consumption among other things.
Fix this by adding a proper return value for devices that don't
implement PM QoS implicitly.
Fixes: 0cc2b4e5a020 ("PM / QoS: Fix device resume latency PM QoS")
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
include/linux/pm_qos.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/pm_qos.h b/include/linux/pm_qos.h
index 6737a8c..d68b056 100644
--- a/include/linux/pm_qos.h
+++ b/include/linux/pm_qos.h
@@ -175,7 +175,8 @@ static inline s32 dev_pm_qos_requested_flags(struct device *dev)
static inline s32 dev_pm_qos_raw_read_value(struct device *dev)
{
return IS_ERR_OR_NULL(dev->power.qos) ?
- 0 : pm_qos_read_value(&dev->power.qos->resume_latency);
+ PM_QOS_RESUME_LATENCY_NO_CONSTRAINT :
+ pm_qos_read_value(&dev->power.qos->resume_latency);
}
#else
static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev,
--
1.9.1
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next reply other threads:[~2017-10-30 7:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 7:10 Tero Kristo [this message]
2017-10-30 10:19 ` [PATCH] PM / QoS: Fix default runtime_pm device resume latency Rafael J. Wysocki
2017-10-30 23:27 ` Rafael J. Wysocki
2017-10-31 7:13 ` Tero Kristo
2017-10-31 8:40 ` Rafael J. Wysocki
2017-10-31 10:18 ` Tero Kristo
2017-10-31 13:09 ` Geert Uytterhoeven
2017-10-31 13:10 ` Geert Uytterhoeven
2017-10-31 13:55 ` Geert Uytterhoeven
2017-10-31 14:04 ` Ulf Hansson
2017-10-31 16:35 ` Rafael J. Wysocki
2017-10-31 15:37 ` Jani Nikula
2017-10-31 16:40 ` Daniel Vetter
2017-10-31 17:12 ` Laurent Pinchart
2017-10-31 17:22 ` Rafael J. Wysocki
2017-10-31 18:07 ` Geert Uytterhoeven
2017-10-31 22:32 ` Rafael J. Wysocki
2017-11-01 10:28 ` Tero Kristo
2017-11-01 20:50 ` Rafael J. Wysocki
2017-11-01 22:36 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509347446-26105-1-git-send-email-t-kristo@ti.com \
--to=t-kristo@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).