[RFC PATCH 0/2] scripts: warn about invalid MAINTAINER patterns

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [RFC PATCH 0/2] scripts: warn about invalid MAINTAINER patterns
@ 2017-10-31 14:46 Tom Saeger
  2017-10-31 14:46 ` [RFC PATCH 1/2] " Tom Saeger
  2017-10-31 14:46 ` [RFC PATCH 2/2] MAINTAINERS: various pattern fixes for mv/rm/typos Tom Saeger
  0 siblings, 2 replies; 6+ messages in thread
From: Tom Saeger @ 2017-10-31 14:46 UTC (permalink / raw)
  To: Joe Perches
  Cc: Tom Saeger, Andrew Morton, David S. Miller, Greg Kroah-Hartman,
	Mauro Carvalho Chehab, Randy Dunlap, linux-kernel

This series attempts to fix all stale MAINTAINER file "F" and "X" patterns.

First patch adds an option "checks" to get_maintainer.pl which outputs
warnings for any "F" or "X" pattern found in MAINTAINER file which does
not register any file/directory matches known by git in current worktree.

Originally, I wrote a standalone script "check_maintainer", but as this
duplicated some of the functions found in get_maintainer.pl it seemed to
make more sense to change get_maintainer.pl directly.

The "-x|--checks" option is intended to be used as follows:

./scripts/get_maintainer.pl -x ./ | tee out.txt
./MAINTAINERS:1743      warning: no matches     drivers/.*/pm8...-.*    F:      drivers/*/pm8???-*
./MAINTAINERS:8721      warning: no matches     drivers/net/ethernet/mellanox/mlx5/core/en_ipsec/.*     F:      drivers/net/ethernet/mellanox/mlx5/core/en_ipsec/*
./MAINTAINERS:8722      warning: no matches     drivers/net/ethernet/mellanox/mlx5/core/ipsec.* F:      drivers/net/ethernet/mellanox/mlx5/core/ipsec*
./MAINTAINERS:9431      warning: no matches     net/core/flow\.c        F:      net/core/flow.c

The output format lends itself to the following in vim (note tab
character):
set errorformat=%f:%l\	%m
cfile out.txt
copen

Second patch fixes all MAINTAINER warnings but four (those listed above), which were not
obvious to me how to fix.  Most fixes were obvious, requiring only "ls
./**/*pat*" or "git log --follow -- xyz.c" or "git blame MAINTAINERS" to
figure out what needed to be changed.

Patches are independent, however I did employ the first in figuring out the
second.

Looking for input on how best to get these merged.  Some of these have
been broken for a long time - so stable kernels might benefit from
backporting.

Future enhancements could sanity check all the other entry types found in
MAINTAINER file.

--Tom

Tom Saeger (2):
  scripts: warn about invalid MAINTAINER patterns
  MAINTAINERS: various pattern fixes for mv/rm/typos

 MAINTAINERS               | 107 ++++++++++++++++++----------------------------
 scripts/get_maintainer.pl |  65 ++++++++++++++++++++++++++++
 2 files changed, 107 insertions(+), 65 deletions(-)

-- 
2.14.3

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [RFC PATCH 1/2] scripts: warn about invalid MAINTAINER patterns
  2017-10-31 14:46 [RFC PATCH 0/2] scripts: warn about invalid MAINTAINER patterns Tom Saeger
@ 2017-10-31 14:46 ` Tom Saeger
  2017-10-31 15:47   ` Joe Perches
  2017-10-31 14:46 ` [RFC PATCH 2/2] MAINTAINERS: various pattern fixes for mv/rm/typos Tom Saeger
  1 sibling, 1 reply; 6+ messages in thread
From: Tom Saeger @ 2017-10-31 14:46 UTC (permalink / raw)
  To: Joe Perches; +Cc: Tom Saeger, Andrew Morton, Greg Kroah-Hartman, linux-kernel


Add get_maintainer.pl option to warn about invalid
"F" and "X" patterns found in MAINTAINERS file(s).

Signed-off-by: Tom Saeger <tom.saeger@oracle.com>
---
 scripts/get_maintainer.pl | 65 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index bc443201d3ef..e01041325ea0 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -19,6 +19,7 @@ my $V = '0.26';
 use Getopt::Long qw(:config no_auto_abbrev);
 use Cwd;
 use File::Find;
+use File::Basename;
 
 my $cur_path = fastgetcwd() . '/';
 my $lk_path = "./";
@@ -57,6 +58,7 @@ my $sections = 0;
 my $file_emails = 0;
 my $from_filename = 0;
 my $pattern_depth = 0;
+my $xchecks = 0;
 my $version = 0;
 my $help = 0;
 my $find_maintainer_files = 0;
@@ -138,6 +140,7 @@ my %VCS_cmds_git = (
     "subject_pattern" => "^GitSubject: (.*)",
     "stat_pattern" => "^(\\d+)\\t(\\d+)\\t\$file\$",
     "file_exists_cmd" => "git ls-files \$file",
+    "list_files_cmd" => "git ls-files \$file",
 );
 
 my %VCS_cmds_hg = (
@@ -167,6 +170,7 @@ my %VCS_cmds_hg = (
     "subject_pattern" => "^HgSubject: (.*)",
     "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
     "file_exists_cmd" => "hg files \$file",
+    "list_files_cmd" => "hg files \$file",
 );
 
 my $conf = which_conf(".get_maintainer.conf");
@@ -252,6 +256,7 @@ if (!GetOptions(
 		'fe|file-emails!' => \$file_emails,
 		'f|file' => \$from_filename,
 		'find-maintainer-files' => \$find_maintainer_files,
+		'x|checks' => \$xchecks,
 		'v|version' => \$version,
 		'h|help|usage' => \$help,
 		)) {
@@ -311,12 +316,14 @@ if (!top_of_kernel_tree($lk_path)) {
 my @typevalue = ();
 my %keyword_hash;
 my @mfiles = ();
+my @patternchecks = ();
 
 sub read_maintainer_file {
     my ($file) = @_;
 
     open (my $maint, '<', "$file")
 	or die "$P: Can't open MAINTAINERS file '$file': $!\n";
+    my $i = 1;
     while (<$maint>) {
 	my $line = $_;
 
@@ -333,6 +340,9 @@ sub read_maintainer_file {
 		if ((-d $value)) {
 		    $value =~ s@([^/])$@$1/@;
 		}
+		if ($xchecks) {
+			push(@patternchecks, {file=>$file, line=>$line, linenr=>$i, pat=>$value});
+		}
 	    } elsif ($type eq "K") {
 		$keyword_hash{@typevalue} = $value;
 	    }
@@ -341,6 +351,7 @@ sub read_maintainer_file {
 	    $line =~ s/\n$//g;
 	    push(@typevalue, $line);
 	}
+	$i++;
     }
     close($maint);
 }
@@ -543,6 +554,11 @@ foreach my $file (@ARGV) {
     }
 }
 
+if ($xchecks) {
+    check_maintainer_patterns();
+    exit 0;
+}
+
 @file_emails = uniq(@file_emails);
 
 my %email_hash_name;
@@ -584,6 +600,37 @@ if ($web) {
     output(@web);
 }
 
+sub has_valid_matches {
+    my ($value, $files) = @_;
+    foreach my $file (@{$files}) {
+        if (file_match_pattern($file, $value)) {
+            return 1;
+        }
+    }
+    return 0;
+}
+
+sub check_maintainer_patterns {
+    my @lsfiles = ();
+
+    @lsfiles = vcs_list_files($lk_path);
+
+    # add directories too
+    my @dirs = ();
+    foreach my $f (@lsfiles) {
+        push(@dirs, dirname($f));
+    }
+    push(@lsfiles, uniq(@dirs));
+
+    for my $x (@patternchecks) {
+        if (!has_valid_matches($x->{pat}, \@lsfiles)) {
+            my $line = $x->{line};
+            chomp($line);
+            print("$x->{file}:$x->{linenr}\twarning: no matches\t$x->{pat}\t$line\n");
+        }
+    }
+}
+
 exit($exit);
 
 sub ignore_email_address {
@@ -863,6 +910,7 @@ Other options:
   --sections => print all of the subsystem sections with pattern matches
   --letters => print all matching 'letter' types from all matching sections
   --mailmap => use .mailmap file (default: $email_use_mailmap)
+  --checks => check for "F" and "X" pattern warnings
   --version => show version
   --help => show this help information
 
@@ -2192,6 +2240,23 @@ sub vcs_file_exists {
     return $exists;
 }
 
+sub vcs_list_files {
+    my ($file) = @_;
+
+    my @lsfiles = ();
+
+    my $vcs_used = vcs_exists();
+    return 0 if (!$vcs_used);
+
+    my $cmd = $VCS_cmds{"list_files_cmd"};
+    $cmd =~ s/(\$\w+)/$1/eeg;   # interpolate $cmd
+    @lsfiles = &{$VCS_cmds{"execute_cmd"}}($cmd);
+
+    return () if ($? != 0);
+
+    return @lsfiles;
+}
+
 sub uniq {
     my (@parms) = @_;
 
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH 1/2] scripts: warn about invalid MAINTAINER patterns
  2017-10-31 14:46 ` [RFC PATCH 1/2] " Tom Saeger
@ 2017-10-31 15:47   ` Joe Perches
  2017-10-31 15:50     ` Tom Saeger
  0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2017-10-31 15:47 UTC (permalink / raw)
  To: Tom Saeger; +Cc: Andrew Morton, Greg Kroah-Hartman, linux-kernel

On Tue, 2017-10-31 at 09:46 -0500, Tom Saeger wrote:
> Add get_maintainer.pl option to warn about invalid
> "F" and "X" patterns found in MAINTAINERS file(s).

Hi Tom.

I've had a similar script for many years.

This implementation is very inefficient as it runs
git ls-files once for each file pattern.

It's much more efficient to do a global git ls-files
once and store the result and then do a local grep
for pattern matches.

cheers, Joe

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH 1/2] scripts: warn about invalid MAINTAINER patterns
  2017-10-31 15:47   ` Joe Perches
@ 2017-10-31 15:50     ` Tom Saeger
  0 siblings, 0 replies; 6+ messages in thread
From: Tom Saeger @ 2017-10-31 15:50 UTC (permalink / raw)
  To: Joe Perches; +Cc: Tom Saeger, Andrew Morton, Greg Kroah-Hartman, linux-kernel

On Tue, Oct 31, 2017 at 08:47:58AM -0700, Joe Perches wrote:
> On Tue, 2017-10-31 at 09:46 -0500, Tom Saeger wrote:
> > Add get_maintainer.pl option to warn about invalid
> > "F" and "X" patterns found in MAINTAINERS file(s).
> 
> Hi Tom.
> 
> I've had a similar script for many years.
> 
> This implementation is very inefficient as it runs
> git ls-files once for each file pattern.
> 
> It's much more efficient to do a global git ls-files
> once and store the result and then do a local grep
> for pattern matches.

OH! that was my intention.  Thanks - I'll fix it.

> 
> cheers, Joe

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [RFC PATCH 2/2] MAINTAINERS: various pattern fixes for mv/rm/typos
  2017-10-31 14:46 [RFC PATCH 0/2] scripts: warn about invalid MAINTAINER patterns Tom Saeger
  2017-10-31 14:46 ` [RFC PATCH 1/2] " Tom Saeger
@ 2017-10-31 14:46 ` Tom Saeger
  2017-10-31 15:55   ` Joe Perches
  1 sibling, 1 reply; 6+ messages in thread
From: Tom Saeger @ 2017-10-31 14:46 UTC (permalink / raw)
  To: Joe Perches
  Cc: Tom Saeger, David S. Miller, Greg Kroah-Hartman,
	Mauro Carvalho Chehab, Randy Dunlap, Andrew Morton, linux-kernel


Several stale or typo'd "F" "X" patterns fixed.

Signed-off-by: Tom Saeger <tom.saeger@oracle.com>
---
 MAINTAINERS | 107 ++++++++++++++++++++++++------------------------------------
 1 file changed, 42 insertions(+), 65 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index af0cb69f6a3e..8ba5ec8584dc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -885,7 +885,6 @@ L:	devel@driverdev.osuosl.org
 S:	Supported
 F:	drivers/staging/android/ion
 F:	drivers/staging/android/uapi/ion.h
-F:	drivers/staging/android/uapi/ion_test.h
 
 AOA (Apple Onboard Audio) ALSA DRIVER
 M:	Johannes Berg <johannes@sipsolutions.net>
@@ -1279,7 +1278,6 @@ M:	Russell King <linux@armlinux.org.uk>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 T:	git git://git.armlinux.org.uk/~rmk/linux-arm.git clkdev
-F:	arch/arm/include/asm/clkdev.h
 F:	drivers/clk/clkdev.c
 
 ARM/COMPULAB CM-X270/EM-X270 and CM-X300 MACHINE SUPPORT
@@ -1687,7 +1685,7 @@ M:	Tomas Cech <sleep_walker@suse.com>
 L:	linux-arm-kernel@lists.infradead.org
 W:	http://hackndev.com
 S:	Maintained
-F:	arch/arm/mach-pxa/include/mach/palmtreo.h
+F:	arch/arm/mach-pxa/palmtreo.h
 F:	arch/arm/mach-pxa/palmtreo.c
 
 ARM/PALMTX,PALMT5,PALMLD,PALMTE2,PALMTC SUPPORT
@@ -1697,11 +1695,11 @@ W:	http://hackndev.com
 S:	Maintained
 F:	arch/arm/mach-pxa/include/mach/palmtx.h
 F:	arch/arm/mach-pxa/palmtx.c
-F:	arch/arm/mach-pxa/include/mach/palmt5.h
+F:	arch/arm/mach-pxa/palmt5.h
 F:	arch/arm/mach-pxa/palmt5.c
 F:	arch/arm/mach-pxa/include/mach/palmld.h
 F:	arch/arm/mach-pxa/palmld.c
-F:	arch/arm/mach-pxa/include/mach/palmte2.h
+F:	arch/arm/mach-pxa/palmte2.h
 F:	arch/arm/mach-pxa/palmte2.c
 F:	arch/arm/mach-pxa/include/mach/palmtc.h
 F:	arch/arm/mach-pxa/palmtc.c
@@ -1711,7 +1709,7 @@ M:	Sergey Lapin <slapin@ossfans.org>
 L:	linux-arm-kernel@lists.infradead.org
 W:	http://hackndev.com
 S:	Maintained
-F:	arch/arm/mach-pxa/include/mach/palmz72.h
+F:	arch/arm/mach-pxa/palmz72.h
 F:	arch/arm/mach-pxa/palmz72.c
 
 ARM/PLEB SUPPORT
@@ -1741,7 +1739,6 @@ F:	drivers/clk/qcom/
 F:	drivers/dma/qcom/
 F:	drivers/soc/qcom/
 F:	drivers/spi/spi-qup.c
-F:	drivers/tty/serial/msm_serial.h
 F:	drivers/tty/serial/msm_serial.c
 F:	drivers/*/pm8???-*
 F:	drivers/mfd/ssbi.c
@@ -1870,7 +1867,6 @@ M:	Andrzej Hajda <a.hajda@samsung.com>
 L:	linux-arm-kernel@lists.infradead.org
 L:	linux-media@vger.kernel.org
 S:	Maintained
-F:	arch/arm/plat-samsung/s5p-dev-mfc.c
 F:	drivers/media/platform/s5p-mfc/
 
 ARM/SHMOBILE ARM ARCHITECTURE
@@ -1908,7 +1904,7 @@ F:	drivers/clk/socfpga/
 ARM/SOCFPGA EDAC SUPPORT
 M:	Thor Thayer <thor.thayer@linux.intel.com>
 S:	Maintained
-F:	drivers/edac/altera_edac.
+F:	drivers/edac/altera_edac.*
 
 ARM/STI ARCHITECTURE
 M:	Patrice Chotard <patrice.chotard@st.com>
@@ -2348,7 +2344,7 @@ M:	Ludovic Desroches <ludovic.desroches@microchip.com>
 L:	linux-media@vger.kernel.org
 S:	Supported
 F:	drivers/media/platform/atmel/atmel-isi.c
-F:	include/media/atmel-isi.h
+F:	drivers/media/platform/atmel/atmel-isi.h
 
 ATMEL LCDFB DRIVER
 M:	Nicolas Ferre <nicolas.ferre@microchip.com>
@@ -2923,7 +2919,7 @@ N:	bcm583*
 N:	bcm585*
 N:	bcm586*
 N:	bcm88312
-F:	arch/arm64/boot/dts/broadcom/ns2*
+F:	arch/arm64/boot/dts/broadcom/northstar2/*
 F:	drivers/clk/bcm/clk-ns*
 F:	drivers/pinctrl/bcm/pinctrl-ns*
 
@@ -3016,7 +3012,7 @@ M:	Clemens Ladisch <clemens@ladisch.de>
 L:	alsa-devel@alsa-project.org (moderated for non-subscribers)
 T:	git git://git.alsa-project.org/alsa-kernel.git
 S:	Maintained
-F:	Documentation/sound/alsa/Bt87x.txt
+F:	Documentation/sound/cards/bt87x.rst
 F:	sound/pci/bt87x.c
 
 BT8XXGPIO DRIVER
@@ -3298,7 +3294,7 @@ M:	David Howells <dhowells@redhat.com>
 M:	David Woodhouse <dwmw2@infradead.org>
 L:	keyrings@vger.kernel.org
 S:	Maintained
-F:	Documentation/module-signing.txt
+F:	Documentation/admin-guide/module-signing.rst
 F:	certs/
 F:	scripts/sign-file.c
 F:	scripts/extract-cert.c
@@ -3579,7 +3575,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git
 S:	Maintained
 F:	Documentation/cgroup-v1/cpusets.txt
 F:	include/linux/cpuset.h
-F:	kernel/cpuset.c
+F:	kernel/cgroup/cpuset.c
 
 CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)
 M:	Johannes Weiner <hannes@cmpxchg.org>
@@ -3720,7 +3716,6 @@ T:	git git://linuxtv.org/media_tree.git
 W:	http://linuxtv.org
 S:	Odd Fixes
 F:	drivers/media/i2c/cs3308.c
-F:	drivers/media/i2c/cs3308.h
 
 CS5535 Audio ALSA driver
 M:	Jaya Kumar <jayakumar.alsa@gmail.com>
@@ -3751,7 +3746,7 @@ T:	git git://linuxtv.org/media_tree.git
 W:	https://linuxtv.org
 S:	Maintained
 F:	drivers/media/common/cx2341x*
-F:	include/media/cx2341x*
+F:	include/media/drv-intf/cx2341x*
 
 CX24120 MEDIA DRIVER
 M:	Jemma Denson <jdenson@gmail.com>
@@ -3859,7 +3854,7 @@ M:	Uma Krishnan <ukrishn@linux.vnet.ibm.com>
 L:	linux-scsi@vger.kernel.org
 S:	Supported
 F:	drivers/scsi/cxlflash/
-F:	include/uapi/scsi/cxlflash_ioctls.h
+F:	include/uapi/scsi/cxlflash_ioctl.h
 F:	Documentation/powerpc/cxlflash.txt
 
 CYBERPRO FB DRIVER
@@ -3902,7 +3897,7 @@ D-LINK DIR-685 TOUCHKEYS DRIVER
 M:	Linus Walleij <linus.walleij@linaro.org>
 L:	linux-input@vger.kernel.org
 S:	Supported
-F:	drivers/input/dlink-dir685-touchkeys.c
+F:	drivers/input/keyboard/dlink-dir685-touchkeys.c
 
 DALLAS/MAXIM DS1685-FAMILY REAL TIME CLOCK
 M:	Joshua Kinard <kumba@gentoo.org>
@@ -4114,7 +4109,7 @@ F:	Documentation/devicetree/bindings/mfd/da90*.txt
 F:	Documentation/devicetree/bindings/input/da90??-onkey.txt
 F:	Documentation/devicetree/bindings/thermal/da90??-thermal.txt
 F:	Documentation/devicetree/bindings/regulator/da92*.txt
-F:	Documentation/devicetree/bindings/watchdog/da92??-wdt.txt
+F:	Documentation/devicetree/bindings/watchdog/da90??-wdt.txt
 F:	Documentation/devicetree/bindings/sound/da[79]*.txt
 F:	drivers/gpio/gpio-da90??.c
 F:	drivers/hwmon/da90??-hwmon.c
@@ -4450,7 +4445,7 @@ DRM DRIVER FOR SITRONIX ST7586 PANELS
 M:	David Lechner <david@lechnology.com>
 S:	Maintained
 F:	drivers/gpu/drm/tinydrm/st7586.c
-F:	Documentation/devicetree/bindings/display/st7586.txt
+F:	Documentation/devicetree/bindings/display/sitronix,st7586.txt
 
 DRM DRIVER FOR TDFX VIDEO CARDS
 S:	Orphan / Obsolete
@@ -4483,7 +4478,6 @@ F:	drivers/gpu/drm/
 F:	drivers/gpu/vga/
 F:	Documentation/devicetree/bindings/display/
 F:	Documentation/devicetree/bindings/gpu/
-F:	Documentation/devicetree/bindings/video/
 F:	Documentation/gpu/
 F:	include/drm/
 F:	include/uapi/drm/
@@ -4528,7 +4522,7 @@ M:	Boris Brezillon <boris.brezillon@free-electrons.com>
 L:	dri-devel@lists.freedesktop.org
 S:	Supported
 F:	drivers/gpu/drm/atmel-hlcdc/
-F:	Documentation/devicetree/bindings/drm/atmel/
+F:	Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 
 DRM DRIVERS FOR BRIDGE CHIPS
@@ -4559,7 +4553,7 @@ S:	Supported
 F:	drivers/gpu/drm/fsl-dcu/
 F:	Documentation/devicetree/bindings/display/fsl,dcu.txt
 F:	Documentation/devicetree/bindings/display/fsl,tcon.txt
-F:	Documentation/devicetree/bindings/display/panel/nec,nl4827hc19_05b.txt
+F:	Documentation/devicetree/bindings/display/panel/nec,nl4827hc19-05b.txt
 
 DRM DRIVERS FOR FREESCALE IMX
 M:	Philipp Zabel <p.zabel@pengutronix.de>
@@ -5537,7 +5531,7 @@ M:	Madalin Bucur <madalin.bucur@nxp.com>
 L:	netdev@vger.kernel.org
 S:	Maintained
 F:	drivers/net/ethernet/freescale/fman
-F:	Documentation/devicetree/bindings/powerpc/fsl/fman.txt
+F:	Documentation/devicetree/bindings/net/fsl-fman.txt
 
 FREESCALE QUAD SPI DRIVER
 M:	Han Xu <han.xu@nxp.com>
@@ -5550,8 +5544,8 @@ M:	Qiang Zhao <qiang.zhao@nxp.com>
 L:	linuxppc-dev@lists.ozlabs.org
 S:	Maintained
 F:	drivers/soc/fsl/qe/
-F:	include/soc/fsl/*qe*.h
-F:	include/soc/fsl/*ucc*.h
+F:	include/soc/fsl/qe/*qe*.h
+F:	include/soc/fsl/qe/*ucc*.h
 
 FREESCALE QUICC ENGINE UCC ETHERNET DRIVER
 M:	Li Yang <leoyang.li@nxp.com>
@@ -5922,7 +5916,7 @@ F:	drivers/staging/greybus/bootrom.c
 F:	drivers/staging/greybus/firmware.h
 F:	drivers/staging/greybus/fw-core.c
 F:	drivers/staging/greybus/fw-download.c
-F:	drivers/staging/greybus/fw-managament.c
+F:	drivers/staging/greybus/fw-management.c
 F:	drivers/staging/greybus/greybus_authentication.h
 F:	drivers/staging/greybus/greybus_firmware.h
 F:	drivers/staging/greybus/hid.c
@@ -5935,8 +5929,6 @@ GREYBUS LOOPBACK/TIME PROTOCOLS DRIVERS
 M:	Bryan O'Donoghue <pure.logic@nexus-software.ie>
 S:	Maintained
 F:	drivers/staging/greybus/loopback.c
-F:	drivers/staging/greybus/timesync.c
-F:	drivers/staging/greybus/timesync_platform.c
 
 GREYBUS PLATFORM DRIVERS
 M:	Vaibhav Hiremath <hvaibhav.linux@gmail.com>
@@ -6542,7 +6534,7 @@ F:	drivers/crypto/nx/nx-aes*
 F:	drivers/crypto/nx/nx-sha*
 F:	drivers/crypto/nx/nx.*
 F:	drivers/crypto/nx/nx_csbcpb.h
-F:	drivers/crypto/nx/nx_debugfs.h
+F:	drivers/crypto/nx/nx_debugfs.c
 
 IBM Power Linux RAID adapter
 M:	Brian King <brking@us.ibm.com>
@@ -6563,7 +6555,6 @@ S:	Supported
 F:	arch/powerpc/platforms/powernv/vas*
 F:	arch/powerpc/platforms/powernv/copy-paste.h
 F:	arch/powerpc/include/asm/vas.h
-F:	arch/powerpc/include/uapi/asm/vas.h
 
 IBM Power Virtual Ethernet Device Driver
 M:	Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
@@ -6709,7 +6700,7 @@ IIO MULTIPLEXER
 M:	Peter Rosin <peda@axentia.se>
 L:	linux-iio@vger.kernel.org
 S:	Maintained
-F:	Documentation/devicetree/bindings/iio/multiplexer/iio-mux.txt
+F:	Documentation/devicetree/bindings/iio/multiplexer/io-channel-mux.txt
 F:	drivers/iio/multiplexer/iio-mux.c
 
 IIO SUBSYSTEM AND DRIVERS
@@ -6753,7 +6744,7 @@ M:	Guenter Roeck <linux@roeck-us.net>
 L:	linux-hwmon@vger.kernel.org
 S:	Maintained
 F:	Documentation/hwmon/ina209
-F:	Documentation/devicetree/bindings/i2c/ina209.txt
+F:	Documentation/devicetree/bindings/hwmon/ina2xx.txt
 F:	drivers/hwmon/ina209.c
 
 INA2XX HARDWARE MONITOR DRIVER
@@ -7131,7 +7122,7 @@ M:	Linus Walleij <linus.walleij@linaro.org>
 L:	linux-iio@vger.kernel.org
 S:	Maintained
 F:	drivers/iio/gyro/mpu3050*
-F:	Documentation/devicetree/bindings/iio/gyroscope/inv,mpu3050.txt
+F:	Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.txt
 
 IOC3 ETHERNET DRIVER
 M:	Ralf Baechle <ralf@linux-mips.org>
@@ -7652,7 +7643,6 @@ S:	Maintained
 F:	Documentation/security/keys/core.rst
 F:	include/linux/key.h
 F:	include/linux/key-type.h
-F:	include/linux/keyctl.h
 F:	include/uapi/linux/keyctl.h
 F:	include/keys/
 F:	security/keys/
@@ -8085,7 +8075,6 @@ F:	include/linux/spinlock*.h
 F:	arch/*/include/asm/spinlock*.h
 F:	include/linux/rwlock*.h
 F:	include/linux/mutex*.h
-F:	arch/*/include/asm/mutex*.h
 F:	include/linux/rwsem*.h
 F:	arch/*/include/asm/rwsem.h
 F:	include/linux/seqlock.h
@@ -8109,7 +8098,6 @@ L:	linux-scsi@vger.kernel.org
 W:	http://www.avagotech.com/support/
 S:	Supported
 F:	drivers/message/fusion/
-F:	drivers/scsi/mpt2sas/
 F:	drivers/scsi/mpt3sas/
 
 LSILOGIC/SYMBIOS/NCR 53C8XX and 53C1010 PCI-SCSI drivers
@@ -8335,7 +8323,7 @@ M:	Guenter Roeck <linux@roeck-us.net>
 L:	linux-hwmon@vger.kernel.org
 S:	Maintained
 F:	Documentation/hwmon/max20751
-F:	drivers/hwmon/max20751.c
+F:	drivers/hwmon/pmbus/max20751.c
 
 MAX2175 SDR TUNER DRIVER
 M:	Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
@@ -8358,7 +8346,7 @@ M:	Guenter Roeck <linux@roeck-us.net>
 L:	linux-hwmon@vger.kernel.org
 S:	Maintained
 F:	Documentation/hwmon/max6697
-F:	Documentation/devicetree/bindings/i2c/max6697.txt
+F:	Documentation/devicetree/bindings/hwmon/max6697.txt
 F:	drivers/hwmon/max6697.c
 F:	include/linux/platform_data/max6697.h
 
@@ -8669,7 +8657,7 @@ M:	Martin Donnelly <martin.donnelly@ge.com>
 M:	Martyn Welch <martyn.welch@collabora.co.uk>
 S:	Maintained
 F:	drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
-F:	Documentation/devicetree/bindings/video/bridge/megachips-stdpxxxx-ge-b850v3-fw.txt
+F:	Documentation/devicetree/bindings/display/bridge/megachips-stdpxxxx-ge-b850v3-fw.txt
 
 MEGARAID SCSI/SAS DRIVERS
 M:	Kashyap Desai <kashyap.desai@broadcom.com>
@@ -8939,7 +8927,7 @@ L:	linux-media@vger.kernel.org
 S:	Supported
 F:	drivers/media/platform/atmel/atmel-isc.c
 F:	drivers/media/platform/atmel/atmel-isc-regs.h
-F:	devicetree/bindings/media/atmel-isc.txt
+F:	Documentation/devicetree/bindings/media/atmel-isc.txt
 
 MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER
 M:	Woojung Huh <Woojung.Huh@microchip.com>
@@ -9193,9 +9181,9 @@ F:	include/uapi/linux/mmc/
 MULTIPLEXER SUBSYSTEM
 M:	Peter Rosin <peda@axentia.se>
 S:	Maintained
-F:	Documentation/ABI/testing/mux/sysfs-class-mux*
+F:	Documentation/ABI/testing/sysfs-class-mux*
 F:	Documentation/devicetree/bindings/mux/
-F:	include/linux/dt-bindings/mux/
+F:	include/dt-bindings/mux
 F:	include/linux/mux/
 F:	drivers/mux/
 
@@ -9230,7 +9218,7 @@ MXSFB DRM DRIVER
 M:	Marek Vasut <marex@denx.de>
 S:	Supported
 F:	drivers/gpu/drm/mxsfb/
-F:	Documentation/devicetree/bindings/display/mxsfb-drm.txt
+F:	Documentation/devicetree/bindings/display/mxsfb.txt
 
 MYRICOM MYRI-10G 10GbE DRIVER (MYRI10GE)
 M:	Hyong-Youb Kim <hykim@myri.com>
@@ -10164,7 +10152,7 @@ M:	Willy Tarreau <willy@haproxy.com>
 M:	Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
 S:	Odd Fixes
 F:	Documentation/misc-devices/lcd-panel-cgram.txt
-F:	drivers/misc/panel.c
+F:	drivers/auxdisplay/panel.c
 
 PARALLEL PORT SUBSYSTEM
 M:	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
@@ -10482,7 +10470,7 @@ M:	Xiaowei Song <songxiaowei@hisilicon.com>
 M:	Binghui Wang <wangbinghui@hisilicon.com>
 L:	linux-pci@vger.kernel.org
 S:	Maintained
-F:	Documentation/devicetree/bindings/pci/pcie-kirin.txt
+F:	Documentation/devicetree/bindings/pci/kirin-pcie.txt
 F:	drivers/pci/dwc/pcie-kirin.c
 
 PCIE DRIVER FOR MEDIATEK
@@ -10934,7 +10922,6 @@ F:	include/uapi/linux/ptrace.h
 F:	include/uapi/linux/ptrace.h
 F:	include/asm-generic/ptrace.h
 F:	kernel/ptrace.c
-F:	arch/*/ptrace*.c
 F:	arch/*/*/ptrace*.c
 F:	arch/*/include/asm/ptrace*.h
 
@@ -11467,7 +11454,7 @@ RENESAS R-CAR GYROADC DRIVER
 M:	Marek Vasut <marek.vasut@gmail.com>
 L:	linux-iio@vger.kernel.org
 S:	Supported
-F:	drivers/iio/adc/rcar_gyro_adc.c
+F:	drivers/iio/adc/rcar-gyroadc.c
 
 RENESAS USB PHY DRIVER
 M:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
@@ -11750,7 +11737,6 @@ T:	git git://linuxtv.org/media_tree.git
 S:	Maintained
 F:	drivers/media/common/saa7146/
 F:	drivers/media/pci/saa7146/
-F:	include/media/saa7146*
 
 SAMSUNG AUDIO (ASoC) DRIVERS
 M:	Krzysztof Kozlowski <krzk@kernel.org>
@@ -12341,7 +12327,6 @@ W:	http://www.rdrop.com/users/paulmck/RCU/
 S:	Supported
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
 F:	include/linux/srcu.h
-F:	kernel/rcu/srcu.c
 
 SMACK SECURITY MODULE
 M:	Casey Schaufler <casey@schaufler-ca.com>
@@ -12510,7 +12495,7 @@ M:	Vinod Koul <vinod.koul@intel.com>
 L:	alsa-devel@alsa-project.org (moderated for non-subscribers)
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
 S:	Supported
-F:	Documentation/sound/alsa/compress_offload.txt
+F:	Documentation/sound/designs/compress-offload.rst
 F:	include/sound/compress_driver.h
 F:	include/uapi/sound/compress_*
 F:	sound/core/compress_offload.c
@@ -12531,7 +12516,7 @@ L:	alsa-devel@alsa-project.org (moderated for non-subscribers)
 W:	http://alsa-project.org/main/index.php/ASoC
 S:	Supported
 F:	Documentation/devicetree/bindings/sound/
-F:	Documentation/sound/alsa/soc/
+F:	Documentation/sound/soc/
 F:	sound/soc/
 F:	include/sound/soc*
 
@@ -12669,11 +12654,6 @@ M:	H Hartley Sweeten <hsweeten@visionengravers.com>
 S:	Odd Fixes
 F:	drivers/staging/comedi/
 
-STAGING - FLARION FT1000 DRIVERS
-M:	Marek Belisko <marek.belisko@gmail.com>
-S:	Odd Fixes
-F:	drivers/staging/ft1000/
-
 STAGING - INDUSTRIAL IO
 M:	Jonathan Cameron <jic23@kernel.org>
 L:	linux-iio@vger.kernel.org
@@ -12773,7 +12753,7 @@ F:	drivers/block/skd*[ch]
 STI CEC DRIVER
 M:	Benjamin Gaignard <benjamin.gaignard@linaro.org>
 S:	Maintained
-F:	drivers/staging/media/st-cec/
+F:	drivers/media/platform/sti/cec/
 F:	Documentation/devicetree/bindings/media/stih-cec.txt
 
 STK1160 USB VIDEO CAPTURE DRIVER
@@ -13235,7 +13215,6 @@ F:	Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
 F:	drivers/firmware/ti_sci*
 F:	include/linux/soc/ti/ti_sci_protocol.h
 F:	Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt
-F:	include/dt-bindings/genpd/k2g.h
 F:	drivers/soc/ti/ti_sci_pm_domains.c
 F:	Documentation/devicetree/bindings/reset/ti,sci-reset.txt
 F:	Documentation/devicetree/bindings/clock/ti,sci-clk.txt
@@ -13756,7 +13735,7 @@ UDRAW TABLET
 M:	Bastien Nocera <hadess@hadess.net>
 L:	linux-input@vger.kernel.org
 S:	Maintained
-F:	drivers/hid/hid-udraw.c
+F:	drivers/hid/hid-udraw-ps3.c
 
 UFS FILESYSTEM
 M:	Evgeniy Dushistov <dushistov@mail.ru>
@@ -14058,7 +14037,7 @@ M:	Heikki Krogerus <heikki.krogerus@linux.intel.com>
 L:	linux-usb@vger.kernel.org
 S:	Maintained
 F:	Documentation/ABI/testing/sysfs-class-typec
-F:	Documentation/usb/typec.rst
+F:	Documentation/driver-api/usb/typec.rst
 F:	drivers/usb/typec/
 F:	include/linux/usb/typec.h
 
@@ -14134,7 +14113,6 @@ F:	Documentation/virtual/uml/
 F:	arch/um/
 F:	arch/x86/um/
 F:	fs/hostfs/
-F:	fs/hppfs/
 
 USERSPACE I/O (UIO)
 M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
@@ -14284,7 +14262,7 @@ F:	net/vmw_vsock/virtio_transport_common.c
 F:	net/vmw_vsock/virtio_transport.c
 F:	drivers/net/vsockmon.c
 F:	drivers/vhost/vsock.c
-F:	drivers/vhost/vsock.h
+F:	include/uapi/linux/vhost.h
 
 VIRTIO CONSOLE DRIVER
 M:	Amit Shah <amit@kernel.org>
@@ -14547,7 +14525,6 @@ L:	wil6210@qca.qualcomm.com
 S:	Supported
 W:	http://wireless.kernel.org/en/users/Drivers/wil6210
 F:	drivers/net/wireless/ath/wil6210/
-F:	include/uapi/linux/wil6210_uapi.h
 
 WIMAX STACK
 M:	Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
@@ -14838,7 +14815,7 @@ YEALINK PHONE DRIVER
 M:	Henk Vergonet <Henk.Vergonet@gmail.com>
 L:	usbb2k-api-dev@nongnu.org
 S:	Maintained
-F:	Documentation/input/yealink.rst
+F:	Documentation/input/devices/yealink.rst
 F:	drivers/input/misc/yealink.*
 
 Z8530 DRIVER FOR AX.25
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH 2/2] MAINTAINERS: various pattern fixes for mv/rm/typos
  2017-10-31 14:46 ` [RFC PATCH 2/2] MAINTAINERS: various pattern fixes for mv/rm/typos Tom Saeger
@ 2017-10-31 15:55   ` Joe Perches
  0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2017-10-31 15:55 UTC (permalink / raw)
  To: Tom Saeger
  Cc: David S. Miller, Greg Kroah-Hartman, Mauro Carvalho Chehab,
	Randy Dunlap, Andrew Morton, linux-kernel

On Tue, 2017-10-31 at 09:46 -0500, Tom Saeger wrote:
> Several stale or typo'd "F" "X" patterns fixed.

This sort of patch is almost impossible to apply as
MAINTAINERS is updated by many many people and this
probably won't apply tomorrow.

It's generally _much_ better to break out each of these
changes into separate patches.

It also allows each individual patch to describe what
happened via renames/moves or other updates.

fyi:

My list of currently invalid file patterns in -next

drivers/staging/android/uapi/ion_test.h
arch/arm/include/asm/clkdev.h
arch/arm/mach-pxa/include/mach/palmtreo.h
arch/arm/mach-pxa/include/mach/palmt5.h
arch/arm/mach-pxa/include/mach/palmte2.h
arch/arm/mach-pxa/include/mach/palmz72.h
drivers/tty/serial/msm_serial.h
arch/arm/plat-samsung/s5p-dev-mfc.c
include/media/atmel-isi.h
arch/arm64/boot/dts/broadcom/ns2*
Documentation/sound/alsa/Bt87x.txt
Documentation/module-signing.txt
kernel/cpuset.c
drivers/media/i2c/cs3308.h
include/media/cx2341x*
include/uapi/scsi/cxlflash_ioctls.h
drivers/input/dlink-dir685-touchkeys.c
Documentation/devicetree/bindings/display/st7586.txt
Documentation/devicetree/bindings/video/
Documentation/devicetree/bindings/drm/atmel/
Documentation/devicetree/bindings/display/panel/nec,nl4827hc19_05b.txt
Documentation/devicetree/bindings/powerpc/fsl/fman.txt
drivers/staging/greybus/fw-managament.c
drivers/staging/greybus/timesync.c
drivers/staging/greybus/timesync_platform.c
drivers/crypto/nx/nx_debugfs.h
arch/powerpc/include/uapi/asm/vas.h
Documentation/devicetree/bindings/iio/multiplexer/iio-mux.txt
Documentation/devicetree/bindings/i2c/ina209.txt
Documentation/devicetree/bindings/iio/gyroscope/inv,mpu3050.txt
include/linux/keyctl.h
arch/*/include/asm/mutex*.h
drivers/scsi/mpt2sas/
drivers/hwmon/max20751.c
Documentation/devicetree/bindings/i2c/max6697.txt
Documentation/devicetree/bindings/video/bridge/megachips-stdpxxxx-ge-b850v3-fw.txt
drivers/net/ethernet/mellanox/mlx5/core/en_ipsec/*
drivers/net/ethernet/mellanox/mlx5/core/ipsec*
Documentation/ABI/testing/mux/sysfs-class-mux*
include/linux/dt-bindings/mux/
Documentation/devicetree/bindings/display/mxsfb-drm.txt
net/core/flow.c
drivers/misc/panel.c
Documentation/devicetree/bindings/pci/pcie-kirin.txt
drivers/iio/adc/rcar_gyro_adc.c
include/media/saa7146*
kernel/rcu/srcu.c
Documentation/sound/alsa/compress_offload.txt
Documentation/sound/alsa/soc/
drivers/staging/ft1000/
drivers/staging/media/st-cec/
include/dt-bindings/genpd/k2g.h
Documentation/usb/typec.rst
fs/hppfs/
drivers/vhost/vsock.h
include/uapi/linux/wil6210_uapi.h
Documentation/input/yealink.rst

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-10-31 15:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-31 14:46 [RFC PATCH 0/2] scripts: warn about invalid MAINTAINER patterns Tom Saeger
2017-10-31 14:46 ` [RFC PATCH 1/2] " Tom Saeger
2017-10-31 15:47   ` Joe Perches
2017-10-31 15:50     ` Tom Saeger
2017-10-31 14:46 ` [RFC PATCH 2/2] MAINTAINERS: various pattern fixes for mv/rm/typos Tom Saeger
2017-10-31 15:55   ` Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).