From: Joe Perches <joe@perches.com>
To: Tom Saeger <tom.saeger@oracle.com>, linux-kernel@vger.kernel.org
Cc: xen-devel <xen-devel@lists.xenproject.org>,
mercurial-devel@mercurial-scm.org
Subject: Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns
Date: Wed, 01 Nov 2017 09:50:05 -0700 [thread overview]
Message-ID: <1509555005.31043.43.camel@perches.com> (raw)
In-Reply-To: <20171031213740.25510-1-tom.saeger@oracle.com>
(add mercurial-devel and xen-devel to cc's)
On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote:
> Add "--pattern-checks" option to get_maintainer.pl to warn about invalid
> "F" and "X" patterns found in MAINTAINERS file(s).
Hey again Tom.
About mercurial/hg.
While as far as I know there hasn't been a mercurial tree
for the linux kernel sources in many years, I believe the
mercurial command to list files should be different.
> my %VCS_cmds_hg = (
> @@ -167,6 +169,7 @@ my %VCS_cmds_hg = (
> "subject_pattern" => "^HgSubject: (.*)",
> "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
> "file_exists_cmd" => "hg files \$file",
> + "list_files_cmd" => "hg files \$file",
I think this should be
"list_files_cmd" => "hg manifest -R \$file",
It seems to work on a XEN test branch but does anyone
really care about hg support in get_maintainers?
btw: to the XEN maintainers
The XEN mercurial branch for MAINTAINERS has a few odd
entries and a few missing file patterns
I think the XEN MAINTAINERS file should be updated to:
---
diff -r c60f04b73240 MAINTAINERS
--- a/MAINTAINERS Mon Oct 16 15:24:44 2017 +0100
+++ b/MAINTAINERS Wed Nov 01 09:39:34 2017 -0700
@@ -246,7 +246,8 @@
KCONFIG
M: Doug Goldstein <cardoe@cardoe.com>
S: Supported
-F: docs/misc/kconfig{,-language}.txt
+F: docs/misc/kconfig.txt
+F: docs/misc/kconfig-language.txt
F: xen/tools/kconfig/
KDD DEBUGGER
@@ -257,8 +258,8 @@
KEXEC
M: Andrew Cooper <andrew.cooper3@citrix.com>
S: Supported
-F: xen/common/{kexec,kimage}.c
-F: xen/include/{kexec,kimage}.h
+F: xen/common/kexec.[ch]
+F: xen/common/kimage.[ch]
F: xen/arch/x86/machine_kexec.c
F: xen/arch/x86/x86_64/kexec_reloc.S
---
After the patch above is applied, --self-test shows:
$ ~/linux/next/scripts/get_maintainer.pl --self-test
./MAINTAINERS:403: warning: no matches F: drivers/xen/usb*/
./MAINTAINERS:415: warning: no matches F: xen/arch/x88/hvm/vm_event.c
./MAINTAINERS:429: warning: no matches F: extras/mini-os/tpm*
./MAINTAINERS:430: warning: no matches F: extras/mini-os/include/tpm*
next prev parent reply other threads:[~2017-11-01 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 21:37 [PATCH] scripts: warn about invalid MAINTAINERS patterns Tom Saeger
2017-11-01 15:32 ` Joe Perches
2017-11-01 16:05 ` Tom Saeger
2017-11-01 16:50 ` Joe Perches [this message]
2017-11-01 17:11 ` Tom Saeger
2017-11-01 20:05 ` Augie Fackler
2017-11-01 20:24 ` Joe Perches
2017-11-01 18:13 ` [PATCH v2 1/1] " Tom Saeger
2017-11-01 18:33 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509555005.31043.43.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mercurial-devel@mercurial-scm.org \
--cc=tom.saeger@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).