From: Tom Saeger <tom.saeger@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Tom Saeger <tom.saeger@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns
Date: Wed, 1 Nov 2017 11:05:32 -0500 [thread overview]
Message-ID: <20171101160532.bfsqm6kfyupz7rci@revenge.us.oracle.com> (raw)
In-Reply-To: <1509550371.31043.31.camel@perches.com>
On Wed, Nov 01, 2017 at 08:32:51AM -0700, Joe Perches wrote:
> On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote:
> > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid
> > "F" and "X" patterns found in MAINTAINERS file(s).
>
> Hey Tom.
>
> I've come around to this addition, but I think a few
> changes are useful.
>
> o Change --pattern-checks to --self-test so future checks
> can be added (valid email address, .mailmap uses, existence
> of git trees, etc...)
Ok.
Had similar thoughts. Was just looking at git trees.
> o Do not require an unnecessary argument with --self-test
Ok.
> o Validate --self-test if it is the only command line argument
Ok.
> o Use emacs filename:line: style output for easier linking
Ok.
> o --self-test emits to STDOUT not STDERR
Ok - I debated this one, I'll change it back.
Thanks for your input Joe, I'll send a v2.
--Tom
next prev parent reply other threads:[~2017-11-01 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 21:37 [PATCH] scripts: warn about invalid MAINTAINERS patterns Tom Saeger
2017-11-01 15:32 ` Joe Perches
2017-11-01 16:05 ` Tom Saeger [this message]
2017-11-01 16:50 ` Joe Perches
2017-11-01 17:11 ` Tom Saeger
2017-11-01 20:05 ` Augie Fackler
2017-11-01 20:24 ` Joe Perches
2017-11-01 18:13 ` [PATCH v2 1/1] " Tom Saeger
2017-11-01 18:33 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101160532.bfsqm6kfyupz7rci@revenge.us.oracle.com \
--to=tom.saeger@oracle.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).