From: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
To: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Jiri Kosina" <jikos@kernel.org>,
"Julien Boibessot" <julien.boibessot@armadeus.com>,
"Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
Subject: [PATCH 2/3] HID: cp2112: add HIDRAW dependency
Date: Thu, 2 Nov 2017 12:12:43 +0100 [thread overview]
Message-ID: <1509621164-28830-2-git-send-email-sebastien.szymanski@armadeus.com> (raw)
In-Reply-To: <1509621164-28830-1-git-send-email-sebastien.szymanski@armadeus.com>
Otherwise, with HIDRAW=n, the probe function crashes because of null
dereference of hdev->hidraw.
Fixes: 42cb6b35b9e6 ("HID: cp2112: use proper hidraw name with minor number")
Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
drivers/hid/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 374301f..8c7a0ce 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -230,7 +230,7 @@ config HID_CMEDIA
config HID_CP2112
tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
- depends on USB_HID && I2C && GPIOLIB
+ depends on USB_HID && HIDRAW && I2C && GPIOLIB
select GPIOLIB_IRQCHIP
---help---
Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
--
2.7.3
next prev parent reply other threads:[~2017-11-02 11:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 11:12 [PATCH 1/3] HID: cp2112: fix interface specification URL Sébastien Szymanski
2017-11-02 11:12 ` Sébastien Szymanski [this message]
2017-11-06 8:12 ` [PATCH 2/3] HID: cp2112: add HIDRAW dependency Benjamin Tissoires
2017-11-02 11:12 ` [PATCH 3/3] HID: cp2112: fix broken gpio_direction_input callback Sébastien Szymanski
2017-11-06 8:11 ` Benjamin Tissoires
2017-11-06 13:58 ` Sébastien Szymanski
2017-11-06 17:43 ` Benjamin Tissoires
2017-11-09 11:45 ` [PATCH 1/3] HID: cp2112: fix interface specification URL Jiri Kosina
2017-11-10 9:05 ` Sébastien Szymanski
2017-11-10 10:04 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509621164-28830-2-git-send-email-sebastien.szymanski@armadeus.com \
--to=sebastien.szymanski@armadeus.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=julien.boibessot@armadeus.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).