From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "keescook@chromium.org" <keescook@chromium.org>,
"Himanshu.Madhani@cavium.com" <Himanshu.Madhani@cavium.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"qla2xxx-upstream@cavium.com" <qla2xxx-upstream@cavium.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()
Date: Mon, 6 Nov 2017 00:18:50 +0000 [thread overview]
Message-ID: <1509927529.8757.1.camel@wdc.com> (raw)
In-Reply-To: <F16A8DFC-AF77-44A0-BDC8-F0197A314123@cavium.com>
On Wed, 2017-11-01 at 19:18 +0000, Madhani, Himanshu wrote:
> Hi Kees,
>
> > On Nov 1, 2017, at 11:46 AM, Kees Cook <keescook@chromium.org> wrote:
> >
> > On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook <keescook@chromium.org> wrote:
> > > This breaks out the logical steps to convert the qla2xxx timers:
> > >
> > > 1) init_timer() -> setup_timer()
> > > 2) refactor qla2x00_start_timer() to not pass callback as argument
> > > 3) qla2x00_timer() to use timer_setup()
> > > 4) qla2x00_sp_timeout() to use timer_setup()
> > >
> > > The resulting diff is identical to the patch that appears to lock up
> > > the driver. This should help identify which step causes this behavior.
> >
> > Hi, just curious if there's been any progress on debugging the issue
> > you saw with this series?
>
> Sorry for delay. I will test this series later today and post update.
Hello Himanshu and Kees,
The qla2xxx driver does not crash if apply these four patches on kernel
v4.14-rc8 and load the qla2xxx driver on my test setup. Point-to-point
mode seems broken again but I don't think that's related to this patch
series.
Bart.
next prev parent reply other threads:[~2017-11-06 0:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 19:13 [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup() Kees Cook
2017-10-31 19:13 ` [PATCH 1/4] scsi: qla2xxx: Convert timers to use setup_timer() Kees Cook
2017-10-31 19:13 ` [PATCH 2/4] scsi: qla2xxx: Refactor qla2x00_start_timer() Kees Cook
2017-10-31 19:13 ` [PATCH 3/4] scsi: qla2xxx: Convert qla2x00_timer() to use timer_setup() Kees Cook
2017-10-31 19:13 ` [PATCH 4/4] scsi: qla2xxx: Convert qla2x00_sp_timeout() " Kees Cook
2017-11-01 18:46 ` [PATCH 0/4] scsi: qla2xxx: Convert timers " Kees Cook
2017-11-01 19:18 ` Madhani, Himanshu
2017-11-06 0:18 ` Bart Van Assche [this message]
2017-11-06 19:58 ` Madhani, Himanshu
2017-11-07 4:30 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509927529.8757.1.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=Himanshu.Madhani@cavium.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=qla2xxx-upstream@cavium.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).