[PATCH 0/2] scsi: ses: Fix space before '[' and remove error check

[PATCH 0/2] scsi: ses: Fix space before '[' and remove error check

[Arvind Yadav]

Fix checkpatch.pl error:
ERROR: space prohibited before open square bracket '['.

It is not necessary to check return value of class_register.
enclosure_init returns both successful and error value.

Arvind Yadav (2):
  [PATCH 1/2] scsi: ses: Fix space before '[' error.
  [PATCH 2/2] scsi: ses: Remove unnecessary error check

 drivers/misc/enclosure.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

-- 
2.7.4

[PATCH 1/2] scsi: ses: Fix space before '[' error.

[Arvind Yadav]

Fix checkpatch.pl error:
ERROR: space prohibited before open square bracket '['.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/misc/enclosure.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c
index eb29113..c4c5552 100644
--- a/drivers/misc/enclosure.c
+++ b/drivers/misc/enclosure.c
@@ -468,7 +468,7 @@ static struct class enclosure_class = {
 	.dev_groups		= enclosure_class_groups,
 };
 
-static const char *const enclosure_status [] = {
+static const char *const enclosure_status[] = {
 	[ENCLOSURE_STATUS_UNSUPPORTED] = "unsupported",
 	[ENCLOSURE_STATUS_OK] = "OK",
 	[ENCLOSURE_STATUS_CRITICAL] = "critical",
@@ -480,7 +480,7 @@ static const char *const enclosure_status [] = {
 	[ENCLOSURE_STATUS_MAX] = NULL,
 };
 
-static const char *const enclosure_type [] = {
+static const char *const enclosure_type[] = {
 	[ENCLOSURE_COMPONENT_DEVICE] = "device",
 	[ENCLOSURE_COMPONENT_ARRAY_DEVICE] = "array device",
 };
-- 
2.7.4

Re: [PATCH 1/2] scsi: ses: Fix space before '[' error.

[Greg KH]

On Sat, Nov 11, 2017 at 08:46:19PM +0530, Arvind Yadav wrote:
> Fix checkpatch.pl error:
> ERROR: space prohibited before open square bracket '['.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/misc/enclosure.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Your subject does not show the correct subsystem/driver :(

[PATCH 2/2] scsi: ses: Remove unnecessary error check

[Arvind Yadav]

It is not necessary to check return value of class_register.
enclosure_init returns both successful and error value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/misc/enclosure.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c
index c4c5552..5a17bfe 100644
--- a/drivers/misc/enclosure.c
+++ b/drivers/misc/enclosure.c
@@ -680,13 +680,7 @@ ATTRIBUTE_GROUPS(enclosure_component);
 
 static int __init enclosure_init(void)
 {
-	int err;
-
-	err = class_register(&enclosure_class);
-	if (err)
-		return err;
-
-	return 0;
+	return class_register(&enclosure_class);
 }
 
 static void __exit enclosure_exit(void)
-- 
2.7.4

Re: [PATCH 2/2] scsi: ses: Remove unnecessary error check

[Greg KH]

On Sat, Nov 11, 2017 at 08:46:20PM +0530, Arvind Yadav wrote:
> It is not necessary to check return value of class_register.
> enclosure_init returns both successful and error value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/misc/enclosure.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)

Same subject error here :(