* [PATCH] dell-laptop: Use bool type in struct quirk_entry for true/false fields
@ 2017-11-11 22:20 Pali Rohár
2017-12-08 21:41 ` Darren Hart
0 siblings, 1 reply; 2+ messages in thread
From: Pali Rohár @ 2017-11-11 22:20 UTC (permalink / raw)
To: Darren Hart, Matthew Garrett, Andy Shevchenko
Cc: platform-driver-x86, linux-kernel, Pali Rohár
In struct quirk_entry some boolean fields used int, some u8 type. Change
them all to bool type.
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
drivers/platform/x86/dell-laptop.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index 7424e53..de7d04b 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -48,10 +48,10 @@
#define KBD_LED_AC_TOKEN 0x0451
struct quirk_entry {
- u8 touchpad_led;
- u8 kbd_led_levels_off_1;
+ bool touchpad_led;
+ bool kbd_led_levels_off_1;
- int needs_kbd_timeouts;
+ bool needs_kbd_timeouts;
/*
* Ordered list of timeouts expressed in seconds.
* The list must end with -1
@@ -62,7 +62,7 @@ struct quirk_entry {
static struct quirk_entry *quirks;
static struct quirk_entry quirk_dell_vostro_v130 = {
- .touchpad_led = 1,
+ .touchpad_led = true,
};
static int __init dmi_matched(const struct dmi_system_id *dmi)
@@ -76,12 +76,12 @@ static int __init dmi_matched(const struct dmi_system_id *dmi)
* is used then BIOS silently set timeout to 0 without any error message.
*/
static struct quirk_entry quirk_dell_xps13_9333 = {
- .needs_kbd_timeouts = 1,
+ .needs_kbd_timeouts = true,
.kbd_timeouts = { 0, 5, 15, 60, 5 * 60, 15 * 60, -1 },
};
static struct quirk_entry quirk_dell_latitude_e6410 = {
- .kbd_led_levels_off_1 = 1,
+ .kbd_led_levels_off_1 = true,
};
static struct platform_driver platform_driver = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dell-laptop: Use bool type in struct quirk_entry for true/false fields
2017-11-11 22:20 [PATCH] dell-laptop: Use bool type in struct quirk_entry for true/false fields Pali Rohár
@ 2017-12-08 21:41 ` Darren Hart
0 siblings, 0 replies; 2+ messages in thread
From: Darren Hart @ 2017-12-08 21:41 UTC (permalink / raw)
To: Pali Rohár
Cc: Matthew Garrett, Andy Shevchenko, platform-driver-x86, linux-kernel
On Sat, Nov 11, 2017 at 11:20:23PM +0100, Pali Rohár wrote:
> In struct quirk_entry some boolean fields used int, some u8 type. Change
> them all to bool type.
>
Queued, thanks!
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-08 21:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-11 22:20 [PATCH] dell-laptop: Use bool type in struct quirk_entry for true/false fields Pali Rohár
2017-12-08 21:41 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).