From: Doug Ledford <dledford@redhat.com>
To: Leon Romanovsky <leon@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@lst.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
Matan Barak <matanb@mellanox.com>,
Yishai Hadas <yishaih@mellanox.com>,
Sean Hefty <sean.hefty@intel.com>,
Dasaratharaman Chandramouli
<dasaratharaman.chandramouli@intel.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband: avoid uninitialized variable warning in create_udata
Date: Mon, 13 Nov 2017 16:14:36 -0500 [thread overview]
Message-ID: <1510607676.3735.37.camel@redhat.com> (raw)
In-Reply-To: <20171111092105.GU18825@mtr-leonro.local>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
On Sat, 2017-11-11 at 11:21 +0200, Leon Romanovsky wrote:
> On Fri, Nov 10, 2017 at 11:10:31PM +0100, Arnd Bergmann wrote:
> > As Dan pointed out, the rework I did makes it harder for smatch and other
> > static checkers to figure out what is going on with the uninitialized
> > pointers.
> >
> > By open-coding the call in create_udata(), we make it more readable for
> > both humans and tools.
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Fixes: 12f727721eee ("IB/uverbs: clean up INIT_UDATA_BUF_OR_NULL usage")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/infiniband/core/uverbs_std_types.c | 21 ++++++++++-----------
> > 1 file changed, 10 insertions(+), 11 deletions(-)
> >
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-11-13 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 22:10 [PATCH] infiniband: avoid uninitialized variable warning in create_udata Arnd Bergmann
2017-11-11 9:21 ` Leon Romanovsky
2017-11-13 21:14 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510607676.3735.37.camel@redhat.com \
--to=dledford@redhat.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=dasaratharaman.chandramouli@intel.com \
--cc=hch@lst.de \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=sean.hefty@intel.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).