From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: acme@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, srikar@linux.vnet.ibm.com,
bala24@linux.vnet.ibm.com
Subject: Re: [PATCH v3 1/2] perf/bench/numa: Add functions to detect sparse numa nodes
Date: Tue, 14 Nov 2017 18:17:46 +0530 [thread overview]
Message-ID: <1510663666.24275.41.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171031151453.pe2ef33hyjl6bcxo@naverao1-tp.localdomain>
Hi Naveen,Thanks for detailed review, my comments inline.
On Tue, 2017-10-31 at 20:44 +0530, Naveen N. Rao wrote:
> Hi Satheesh,
>
> On 2017/08/21 10:15AM, sathnaga@linux.vnet.ibm.com wrote:
> >
> > From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> >
> > Added functions 1) to get a count of all nodes that are exposed to
> > userspace. These nodes could be memoryless cpu nodes or cpuless
> > memory
> > nodes, 2) to check given node is present and 3) to check given
> > node has cpus
> >
> > This information can be used to handle sparse/discontiguous nodes.
> >
> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> > Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> > Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> > Signed-off-by: Balamuruhan S <bala24@linux.vnet.ibm.com>
> > ---
> > tools/perf/bench/numa.c | 44
> > ++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 44 insertions(+)
> >
> > diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
> > index 469d65b..2483174 100644
> > --- a/tools/perf/bench/numa.c
> > +++ b/tools/perf/bench/numa.c
> > @@ -215,6 +215,50 @@ static const char * const numa_usage[] = {
> > NULL
> > };
> >
> > +/*
> > + * To get number of numa nodes present.
> > + */
> > +static int nr_numa_nodes(void)
> > +{
> > + int i, nr_nodes = 0;
> > +
> > + for (i = 0; i < g->p.nr_nodes; i++) {
> > + if (numa_bitmask_isbitset(numa_nodes_ptr, i))
> > + nr_nodes++;
> > + }
> > +
> > + return nr_nodes;
> > +}
> > +
> > +/*
> Please run patches through scripts/checkpatch.pl. There is a
> trailing
> whitespace above...
>
Sure
> >
> > + * To check if given numa node is present.
> > + */
> > +static int is_node_present(int node)
> > +{
> > + return numa_bitmask_isbitset(numa_nodes_ptr, node);
> > +}
> > +
> > +/*
> > + * To check given numa node has cpus.
> > + */
> > +static bool node_has_cpus(int node)
> > +{
> > + struct bitmask *cpu = numa_allocate_cpumask();
> > + unsigned int i;
> > +
> > + if (cpu == NULL)
> > + return false; /* lets fall back to nocpus safely
> > */
> > +
> > + if (numa_node_to_cpus(node, cpu) == 0) {
> This can be simplified to:
> if (cpu && !numa_node_to_cpus(node, cpu)) {
>
> >
> > + for (i = 0; i < cpu->size; i++) {
> > + if (numa_bitmask_isbitset(cpu, i))
> > + return true;
> > + }
> > + }
> The indentation on those brackets look to be wrong.
>
Sure
> >
> > +
> > + return false;
> > +}
> > +
> More importantly, you've introduced few functions in this patch, but
> none of those are being used. This is not a useful way to split your
> patches. In fact, this hurts bisect since trying to build perf with
> just
> this patch applied throws errors.
>
Sure, This can be merged to single patch, will do it in next version.
> You seem to be addressing a few different issues related to perf
> bench
> numa. You might want to split your patch based on the specific
> issue(s)
> each change fixes.
>
>
> - Naveen
>
>
Regards,
-Satheesh.
> >
> > static cpu_set_t bind_to_cpu(int target_cpu)
> > {
> > cpu_set_t orig_mask, mask;
next prev parent reply other threads:[~2017-11-14 12:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 10:15 [PATCH v3 0/2] Fixup for discontiguous/sparse numa nodes sathnaga
2017-08-21 10:15 ` [PATCH v3 1/2] perf/bench/numa: Add functions to detect sparse " sathnaga
2017-10-31 15:14 ` Naveen N. Rao
2017-11-14 12:47 ` Satheesh Rajendran [this message]
2017-08-21 10:17 ` [PATCH v3 2/2] perf/bench/numa: Handle discontiguous/sparse " sathnaga
2017-10-31 15:16 ` Naveen N. Rao
2017-10-31 15:26 ` Arnaldo Carvalho de Melo
2017-11-15 15:51 ` Satheesh Rajendran
2017-11-14 12:46 ` Satheesh Rajendran
2017-11-15 9:43 ` Naveen N. Rao
2017-09-19 9:34 ` [PATCH v3 0/2] Fixup for " Satheesh Rajendran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510663666.24275.41.camel@linux.vnet.ibm.com \
--to=sathnaga@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=bala24@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).