linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: acme@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org, srikar@linux.vnet.ibm.com,
	bala24@linux.vnet.ibm.com
Subject: Re: [PATCH v3 2/2] perf/bench/numa: Handle discontiguous/sparse numa nodes
Date: Tue, 14 Nov 2017 18:16:02 +0530	[thread overview]
Message-ID: <1510663562.24275.38.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171031151658.clq6qmdfw3gj6afg@naverao1-tp.localdomain>

Hi Naveen,


On Tue, 2017-10-31 at 20:46 +0530, Naveen N. Rao wrote:
> 
> >  	}
> >  	BUG_ON(nr_min > nr_max);
> > -
> Looks like an un-necessary change there.
> 
> - Naveen
> 
I had hit with this compilation error, so had to move the
initialization above.
Please advice. Thanks.

  CC       bench/numa.o
bench/numa.c: In function ‘calc_convergence’:
bench/numa.c:1035:3: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
   int processes = count_node_processes(node);
   ^
cc1: all warnings being treated as errors
mv: cannot stat ‘bench/.numa.o.tmp’: No such file or directory
make[4]: *** [bench/numa.o] Error 1
make[3]: *** [bench] Error 2
make[2]: *** [perf-in.o] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2

Regards,
-Satheesh.
> > 
> >  	BUG_ON(sum > g->p.nr_tasks);
> > 
> >  	if (0 && (sum < g->p.nr_tasks))
@@ -1027,8 +1029,9 @@ static void calc_convergence(double 

  parent reply	other threads:[~2017-11-14 12:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21 10:15 [PATCH v3 0/2] Fixup for discontiguous/sparse numa nodes sathnaga
2017-08-21 10:15 ` [PATCH v3 1/2] perf/bench/numa: Add functions to detect sparse " sathnaga
2017-10-31 15:14   ` Naveen N. Rao
2017-11-14 12:47     ` Satheesh Rajendran
2017-08-21 10:17 ` [PATCH v3 2/2] perf/bench/numa: Handle discontiguous/sparse " sathnaga
2017-10-31 15:16   ` Naveen N. Rao
2017-10-31 15:26     ` Arnaldo Carvalho de Melo
2017-11-15 15:51       ` Satheesh Rajendran
2017-11-14 12:46     ` Satheesh Rajendran [this message]
2017-11-15  9:43       ` Naveen N. Rao
2017-09-19  9:34 ` [PATCH v3 0/2] Fixup for " Satheesh Rajendran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510663562.24275.38.camel@linux.vnet.ibm.com \
    --to=sathnaga@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=bala24@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).