From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: "Darren Hart" <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"Ingo Molnar" <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-doc@vger.kernel.org,
"Jonathan Corbet" <corbet@lwn.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v5 11/11] intel_sgx: driver documentation
Date: Mon, 27 Nov 2017 11:41:48 -0800 [thread overview]
Message-ID: <1511811708.9392.51.camel@intel.com> (raw)
In-Reply-To: <1511802219.9392.44.camel@intel.com>
+ Cc: KVM, Paolo and Radim
On Mon, 2017-11-27 at 09:03 -0800, Sean Christopherson wrote:
> On Tue, 2017-11-21 at 01:08 +0200, Jarkko Sakkinen wrote:
> >
> > On Sat, Nov 18, 2017 at 12:34:33AM +0100, Thomas Gleixner wrote:
> > >
> > >
> > > This is architecural. From the cursory read of that series it seems there
> > > are two parts to it:
> > >
> > > 1) The actual core handling, which should be in arch/x86 because that
> > > hardly qualifies as a 'platform' device driver.
> > >
> > > 2) The user space interface, which can be separated out perhaps.
> > >
> > > I don't know how intertwingled they are, but that's hard to tell from the
> > > actual patches w/o doing a deep inspection. Jarkko should be able to
> > > answer
> > > that.
> > >
> > > Thanks,
> > >
> > > tglx
> > Darren, tglx,
> >
> > You can leave user space device as separate module as sgx_ioctl.c merely
> > calls stuff that I have inside sgx_encl.c. VMA creation is bound to file
> > operations.
> >
> > My questions would be:
> >
> > 1. What is your recommendation on the deployment under arch/x86?
> > 2. Which parts should be compilable as a LKM? Only the user interface
> > or both parts?
> >
> > /Jarkko
> To enable KVM and a cgroup for EPC accounting, at a minimum arch/x86 needs to
> manage the EPC pages (alloc/free/lrus/reclaim/etc...) and LE hash MSRs. IMO,
> ideally everything else would be left in the device driver, e.g. anything
> involving ENCLS. Keeping the majority of the driver out of arch/x86 minimizes
> the footprint in arch/x86 and thereby the size of KVM's dependency required to
> virtualize SGX, and allows the various SGX pieces, e.g. arch, driver and KVM,
> to evolve more independently.
>
> Preferably the arch/x86 code would not be a loadable module, e.g. to simplify
> KVM support.
>
> I have a branch based on Jarkko's patches (I believe it's up-to-date with v5)
> that implements what I described. I'd be happy to send RFC patches if that
> would help.
>
>
> Branches for those interested:
>
> https://github.com/sean-jc/linux.git sgx/arch - move core EPC to arch/x86
> https://github.com/sean-jc/linux.git sgx/kvm - KVM support for SGX
> https://github.com/sean-jc/linux.git sgx/lc - KVM support for Launch
> Control
> https://github.com/sean-jc/linux.git sgx/cgroup - EPC cgroup
>
>
> branch relationships:
>
> Jarkko's patches
> |
> |
> sgx/arch
> / \
> sgx/kvm sgx/cgroup
> /
> sgx/lc
next prev parent reply other threads:[~2017-11-27 19:46 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 19:45 [PATCH v5 00/11] Intel SGX Driver Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 01/11] intel_sgx: updated MAINTAINERS Jarkko Sakkinen
2017-11-17 21:54 ` Darren Hart
2017-11-24 19:18 ` Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 02/11] x86: add SGX definition to cpufeature Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 03/11] x86: define the feature control MSR's SGX enable bit Jarkko Sakkinen
2017-11-17 21:48 ` Darren Hart
2017-11-13 19:45 ` [PATCH v5 04/11] x86: define the feature control MSR's SGX launch control bit Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 05/11] x86: add SGX MSRs to msr-index.h Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 06/11] intel_sgx: driver for Intel Software Guard Extensions Jarkko Sakkinen
2017-11-13 23:41 ` James Morris
2017-11-14 20:12 ` Jarkko Sakkinen
2017-11-15 10:04 ` Jarkko Sakkinen
2017-11-14 17:55 ` [intel-sgx-kernel-dev] " Sean Christopherson
2017-11-14 20:28 ` Jarkko Sakkinen
2017-11-15 18:20 ` Sean Christopherson
2017-12-13 23:18 ` Christopherson, Sean J
2017-12-15 15:00 ` Jarkko Sakkinen
2017-12-19 18:52 ` Christopherson, Sean J
2017-12-19 23:11 ` Jarkko Sakkinen
2017-12-19 23:24 ` Christopherson, Sean J
2017-12-20 10:13 ` Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 07/11] intel_sgx: ptrace() support Jarkko Sakkinen
2017-11-16 9:28 ` Thomas Gleixner
2017-11-23 10:25 ` Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 08/11] intel_sgx: in-kernel launch enclave Jarkko Sakkinen
2017-11-14 17:05 ` [intel-sgx-kernel-dev] " Sean Christopherson
2017-11-14 20:05 ` Jarkko Sakkinen
2017-11-20 22:21 ` Jarkko Sakkinen
2017-11-15 11:50 ` Peter Zijlstra
2017-11-20 22:25 ` Jarkko Sakkinen
2017-11-20 22:43 ` Thomas Gleixner
2017-11-20 23:43 ` Jarkko Sakkinen
2017-11-20 23:48 ` Thomas Gleixner
2017-11-21 12:23 ` Jarkko Sakkinen
2017-11-21 23:36 ` Thomas Gleixner
2017-11-13 19:45 ` [PATCH v5 09/11] fs/pipe.c: export create_pipe_files() and replace_fd() Jarkko Sakkinen
2017-11-16 9:15 ` Thomas Gleixner
2017-11-20 22:30 ` Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 10/11] intel_sgx: glue code for in-kernel LE Jarkko Sakkinen
2017-11-14 18:16 ` [intel-sgx-kernel-dev] " Sean Christopherson
2017-11-14 20:31 ` Jarkko Sakkinen
2017-11-15 10:10 ` Jarkko Sakkinen
2017-11-17 23:07 ` Darren Hart
2017-11-25 12:52 ` Jarkko Sakkinen
2017-11-25 18:01 ` Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 11/11] intel_sgx: driver documentation Jarkko Sakkinen
2017-11-14 3:01 ` [intel-sgx-kernel-dev] " Kai Huang
2017-11-14 19:47 ` Jarkko Sakkinen
2017-11-14 21:12 ` Kai Huang
2017-11-14 8:36 ` Borislav Petkov
2017-11-14 20:49 ` Jarkko Sakkinen
2017-11-14 21:53 ` Borislav Petkov
2017-11-20 22:37 ` Jarkko Sakkinen
2017-11-20 22:42 ` Borislav Petkov
2017-11-20 23:41 ` Jarkko Sakkinen
2017-11-21 11:10 ` Borislav Petkov
2017-11-15 11:54 ` Peter Zijlstra
2017-11-20 22:46 ` Jarkko Sakkinen
2017-11-21 12:38 ` Jarkko Sakkinen
2017-11-21 12:47 ` Borislav Petkov
2017-11-21 23:45 ` Jethro Beekman
2017-11-22 0:10 ` Borislav Petkov
2017-11-22 0:27 ` Jethro Beekman
2017-11-22 11:00 ` Borislav Petkov
2017-11-22 16:07 ` Jethro Beekman
2017-11-17 21:43 ` Darren Hart
2017-11-17 23:34 ` Thomas Gleixner
2017-11-17 23:46 ` Darren Hart
2017-11-20 23:12 ` Jarkko Sakkinen
2017-11-20 23:08 ` Jarkko Sakkinen
2017-11-27 17:03 ` Sean Christopherson
2017-11-27 19:41 ` Sean Christopherson [this message]
2017-11-28 20:37 ` Jarkko Sakkinen
2017-11-28 20:46 ` Jarkko Sakkinen
2017-11-24 17:26 ` Jarkko Sakkinen
2017-11-15 10:35 ` [PATCH v5 00/11] Intel SGX Driver Thomas Gleixner
2017-11-20 22:20 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511811708.9392.51.camel@intel.com \
--to=sean.j.christopherson@intel.com \
--cc=corbet@lwn.net \
--cc=dvhart@infradead.org \
--cc=hpa@zytor.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pbonzini@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).