From: Thomas Gleixner <tglx@linutronix.de>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v5 09/11] fs/pipe.c: export create_pipe_files() and replace_fd()
Date: Thu, 16 Nov 2017 10:15:42 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1711161012510.2191@nanos> (raw)
In-Reply-To: <20171113194528.28557-10-jarkko.sakkinen@linux.intel.com>
On Mon, 13 Nov 2017, Jarkko Sakkinen wrote:
+ Cc: Al
- Cc: that intel sgx list because it's moderated and spams my inbox with
useless moderation mails.
> Exported create_pipe_files() and replace_fd() because the SGX driver
> needs to be able to setup pipes in order to communicate with the helper
> process that hosts the Launch Enclave (LE). The pipe creation will be
> done in the init-callback supplied to call_usermodehelper_setup().
>
> The driver will use two pipes for communication with the LE hosting
> process:
>
> * One for writing SIGSTRUCT blobs.
> * One for reading EINITTOKEN blobs.
Can you pretty please make sure that people who maintain the affected code
are CC'd on your changes?
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> ---
> fs/file.c | 1 +
> fs/pipe.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/fs/file.c b/fs/file.c
> index 1fc7fbbb4510..b1fa28919b22 100644
> --- a/fs/file.c
> +++ b/fs/file.c
> @@ -871,6 +871,7 @@ int replace_fd(unsigned fd, struct file *file, unsigned flags)
> spin_unlock(&files->file_lock);
> return err;
> }
> +EXPORT_SYMBOL_GPL(replace_fd);
>
> SYSCALL_DEFINE3(dup3, unsigned int, oldfd, unsigned int, newfd, int, flags)
> {
> diff --git a/fs/pipe.c b/fs/pipe.c
> index 97e5be897753..ee33a84127e7 100644
> --- a/fs/pipe.c
> +++ b/fs/pipe.c
> @@ -784,6 +784,7 @@ int create_pipe_files(struct file **res, int flags)
> iput(inode);
> return err;
> }
> +EXPORT_SYMBOL_GPL(create_pipe_files);
>
> static int __do_pipe_flags(int *fd, struct file **files, int flags)
> {
> --
> 2.14.1
>
>
next prev parent reply other threads:[~2017-11-16 9:16 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 19:45 [PATCH v5 00/11] Intel SGX Driver Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 01/11] intel_sgx: updated MAINTAINERS Jarkko Sakkinen
2017-11-17 21:54 ` Darren Hart
2017-11-24 19:18 ` Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 02/11] x86: add SGX definition to cpufeature Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 03/11] x86: define the feature control MSR's SGX enable bit Jarkko Sakkinen
2017-11-17 21:48 ` Darren Hart
2017-11-13 19:45 ` [PATCH v5 04/11] x86: define the feature control MSR's SGX launch control bit Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 05/11] x86: add SGX MSRs to msr-index.h Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 06/11] intel_sgx: driver for Intel Software Guard Extensions Jarkko Sakkinen
2017-11-13 23:41 ` James Morris
2017-11-14 20:12 ` Jarkko Sakkinen
2017-11-15 10:04 ` Jarkko Sakkinen
2017-11-14 17:55 ` [intel-sgx-kernel-dev] " Sean Christopherson
2017-11-14 20:28 ` Jarkko Sakkinen
2017-11-15 18:20 ` Sean Christopherson
2017-12-13 23:18 ` Christopherson, Sean J
2017-12-15 15:00 ` Jarkko Sakkinen
2017-12-19 18:52 ` Christopherson, Sean J
2017-12-19 23:11 ` Jarkko Sakkinen
2017-12-19 23:24 ` Christopherson, Sean J
2017-12-20 10:13 ` Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 07/11] intel_sgx: ptrace() support Jarkko Sakkinen
2017-11-16 9:28 ` Thomas Gleixner
2017-11-23 10:25 ` Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 08/11] intel_sgx: in-kernel launch enclave Jarkko Sakkinen
2017-11-14 17:05 ` [intel-sgx-kernel-dev] " Sean Christopherson
2017-11-14 20:05 ` Jarkko Sakkinen
2017-11-20 22:21 ` Jarkko Sakkinen
2017-11-15 11:50 ` Peter Zijlstra
2017-11-20 22:25 ` Jarkko Sakkinen
2017-11-20 22:43 ` Thomas Gleixner
2017-11-20 23:43 ` Jarkko Sakkinen
2017-11-20 23:48 ` Thomas Gleixner
2017-11-21 12:23 ` Jarkko Sakkinen
2017-11-21 23:36 ` Thomas Gleixner
2017-11-13 19:45 ` [PATCH v5 09/11] fs/pipe.c: export create_pipe_files() and replace_fd() Jarkko Sakkinen
2017-11-16 9:15 ` Thomas Gleixner [this message]
2017-11-20 22:30 ` Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 10/11] intel_sgx: glue code for in-kernel LE Jarkko Sakkinen
2017-11-14 18:16 ` [intel-sgx-kernel-dev] " Sean Christopherson
2017-11-14 20:31 ` Jarkko Sakkinen
2017-11-15 10:10 ` Jarkko Sakkinen
2017-11-17 23:07 ` Darren Hart
2017-11-25 12:52 ` Jarkko Sakkinen
2017-11-25 18:01 ` Jarkko Sakkinen
2017-11-13 19:45 ` [PATCH v5 11/11] intel_sgx: driver documentation Jarkko Sakkinen
2017-11-14 3:01 ` [intel-sgx-kernel-dev] " Kai Huang
2017-11-14 19:47 ` Jarkko Sakkinen
2017-11-14 21:12 ` Kai Huang
2017-11-14 8:36 ` Borislav Petkov
2017-11-14 20:49 ` Jarkko Sakkinen
2017-11-14 21:53 ` Borislav Petkov
2017-11-20 22:37 ` Jarkko Sakkinen
2017-11-20 22:42 ` Borislav Petkov
2017-11-20 23:41 ` Jarkko Sakkinen
2017-11-21 11:10 ` Borislav Petkov
2017-11-15 11:54 ` Peter Zijlstra
2017-11-20 22:46 ` Jarkko Sakkinen
2017-11-21 12:38 ` Jarkko Sakkinen
2017-11-21 12:47 ` Borislav Petkov
2017-11-21 23:45 ` Jethro Beekman
2017-11-22 0:10 ` Borislav Petkov
2017-11-22 0:27 ` Jethro Beekman
2017-11-22 11:00 ` Borislav Petkov
2017-11-22 16:07 ` Jethro Beekman
2017-11-17 21:43 ` Darren Hart
2017-11-17 23:34 ` Thomas Gleixner
2017-11-17 23:46 ` Darren Hart
2017-11-20 23:12 ` Jarkko Sakkinen
2017-11-20 23:08 ` Jarkko Sakkinen
2017-11-27 17:03 ` Sean Christopherson
2017-11-27 19:41 ` Sean Christopherson
2017-11-28 20:37 ` Jarkko Sakkinen
2017-11-28 20:46 ` Jarkko Sakkinen
2017-11-24 17:26 ` Jarkko Sakkinen
2017-11-15 10:35 ` [PATCH v5 00/11] Intel SGX Driver Thomas Gleixner
2017-11-20 22:20 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1711161012510.2191@nanos \
--to=tglx@linutronix.de \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).