* [PATCH] mmc: sdhci-of-arasan: Add sdhci_arasan_set_power
@ 2017-11-28 0:02 Milan Stevanovic
2017-11-30 10:31 ` Adrian Hunter
2017-11-30 13:09 ` Ulf Hansson
0 siblings, 2 replies; 4+ messages in thread
From: Milan Stevanovic @ 2017-11-28 0:02 UTC (permalink / raw)
To: michal.simek, adrian.hunter, ulf.hansson
Cc: linux-arm-kernel, linux-mmc, linux-kernel, milan.o.stevanovic
The power register needs to have a valid voltage set
even when the power supply is managed by an external regulator.
Signed-off-by: Milan Stevanovic <milan.o.stevanovic@gmail.com>
---
drivers/mmc/host/sdhci-of-arasan.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 0720ea7..fb57206 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -262,6 +262,17 @@ static int sdhci_arasan_voltage_switch(struct mmc_host *mmc,
return -EINVAL;
}
+static void sdhci_arasan_set_power(struct sdhci_host *host, unsigned char mode,
+ unsigned short vdd)
+{
+ if (!IS_ERR(host->mmc->supply.vmmc)) {
+ struct mmc_host *mmc = host->mmc;
+
+ mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd);
+ }
+ sdhci_set_power_noreg(host, mode, vdd);
+}
+
static const struct sdhci_ops sdhci_arasan_ops = {
.set_clock = sdhci_arasan_set_clock,
.get_max_clock = sdhci_pltfm_clk_get_max_clock,
@@ -269,6 +280,7 @@ static const struct sdhci_ops sdhci_arasan_ops = {
.set_bus_width = sdhci_set_bus_width,
.reset = sdhci_arasan_reset,
.set_uhs_signaling = sdhci_set_uhs_signaling,
+ .set_power = sdhci_arasan_set_power,
};
static const struct sdhci_pltfm_data sdhci_arasan_pdata = {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: sdhci-of-arasan: Add sdhci_arasan_set_power
2017-11-28 0:02 [PATCH] mmc: sdhci-of-arasan: Add sdhci_arasan_set_power Milan Stevanovic
@ 2017-11-30 10:31 ` Adrian Hunter
2017-11-30 13:09 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Adrian Hunter @ 2017-11-30 10:31 UTC (permalink / raw)
To: Milan Stevanovic, michal.simek, ulf.hansson
Cc: linux-arm-kernel, linux-mmc, linux-kernel, Shawn Lin, Douglas Anderson
On 28/11/17 02:02, Milan Stevanovic wrote:
> The power register needs to have a valid voltage set
> even when the power supply is managed by an external regulator.
>
> Signed-off-by: Milan Stevanovic <milan.o.stevanovic@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 0720ea7..fb57206 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -262,6 +262,17 @@ static int sdhci_arasan_voltage_switch(struct mmc_host *mmc,
> return -EINVAL;
> }
>
> +static void sdhci_arasan_set_power(struct sdhci_host *host, unsigned char mode,
> + unsigned short vdd)
> +{
> + if (!IS_ERR(host->mmc->supply.vmmc)) {
> + struct mmc_host *mmc = host->mmc;
> +
> + mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd);
> + }
> + sdhci_set_power_noreg(host, mode, vdd);
> +}
> +
> static const struct sdhci_ops sdhci_arasan_ops = {
> .set_clock = sdhci_arasan_set_clock,
> .get_max_clock = sdhci_pltfm_clk_get_max_clock,
> @@ -269,6 +280,7 @@ static const struct sdhci_ops sdhci_arasan_ops = {
> .set_bus_width = sdhci_set_bus_width,
> .reset = sdhci_arasan_reset,
> .set_uhs_signaling = sdhci_set_uhs_signaling,
> + .set_power = sdhci_arasan_set_power,
> };
>
> static const struct sdhci_pltfm_data sdhci_arasan_pdata = {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: sdhci-of-arasan: Add sdhci_arasan_set_power
2017-11-28 0:02 [PATCH] mmc: sdhci-of-arasan: Add sdhci_arasan_set_power Milan Stevanovic
2017-11-30 10:31 ` Adrian Hunter
@ 2017-11-30 13:09 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2017-11-30 13:09 UTC (permalink / raw)
To: Milan Stevanovic
Cc: Michal Simek, Adrian Hunter, linux-arm-kernel, linux-mmc, linux-kernel
On 28 November 2017 at 01:02, Milan Stevanovic
<milan.o.stevanovic@gmail.com> wrote:
> The power register needs to have a valid voltage set
> even when the power supply is managed by an external regulator.
>
> Signed-off-by: Milan Stevanovic <milan.o.stevanovic@gmail.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 0720ea7..fb57206 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -262,6 +262,17 @@ static int sdhci_arasan_voltage_switch(struct mmc_host *mmc,
> return -EINVAL;
> }
>
> +static void sdhci_arasan_set_power(struct sdhci_host *host, unsigned char mode,
> + unsigned short vdd)
> +{
> + if (!IS_ERR(host->mmc->supply.vmmc)) {
> + struct mmc_host *mmc = host->mmc;
> +
> + mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd);
> + }
> + sdhci_set_power_noreg(host, mode, vdd);
> +}
> +
> static const struct sdhci_ops sdhci_arasan_ops = {
> .set_clock = sdhci_arasan_set_clock,
> .get_max_clock = sdhci_pltfm_clk_get_max_clock,
> @@ -269,6 +280,7 @@ static const struct sdhci_ops sdhci_arasan_ops = {
> .set_bus_width = sdhci_set_bus_width,
> .reset = sdhci_arasan_reset,
> .set_uhs_signaling = sdhci_set_uhs_signaling,
> + .set_power = sdhci_arasan_set_power,
> };
>
> static const struct sdhci_pltfm_data sdhci_arasan_pdata = {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mmc: sdhci-of-arasan: Add sdhci_arasan_set_power
@ 2017-11-27 23:51 Milan Stevanovic
0 siblings, 0 replies; 4+ messages in thread
From: Milan Stevanovic @ 2017-11-27 23:51 UTC (permalink / raw)
To: michal.simek, adrian.hunter, ulf.hansson
Cc: linux-arm-kernel, linux-mmc, linux-kernel, milan.o.stevanovic
The power register needs to have a valid voltage set
even when the power supply is managed by an external regulator.
Signed-off-by: Milan Stevanovic <milan.o.stevanovic@gmail.com>
---
drivers/mmc/host/sdhci-of-arasan.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 0720ea7..fb57206 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -262,6 +262,17 @@ static int sdhci_arasan_voltage_switch(struct mmc_host *mmc,
return -EINVAL;
}
+static void sdhci_arasan_set_power(struct sdhci_host *host, unsigned char mode,
+ unsigned short vdd)
+{
+ if (!IS_ERR(host->mmc->supply.vmmc)) {
+ struct mmc_host *mmc = host->mmc;
+
+ mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd);
+ }
+ sdhci_set_power_noreg(host, mode, vdd);
+}
+
static const struct sdhci_ops sdhci_arasan_ops = {
.set_clock = sdhci_arasan_set_clock,
.get_max_clock = sdhci_pltfm_clk_get_max_clock,
@@ -269,6 +280,7 @@ static const struct sdhci_ops sdhci_arasan_ops = {
.set_bus_width = sdhci_set_bus_width,
.reset = sdhci_arasan_reset,
.set_uhs_signaling = sdhci_set_uhs_signaling,
+ .set_power = sdhci_arasan_set_power,
};
static const struct sdhci_pltfm_data sdhci_arasan_pdata = {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-30 13:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 0:02 [PATCH] mmc: sdhci-of-arasan: Add sdhci_arasan_set_power Milan Stevanovic
2017-11-30 10:31 ` Adrian Hunter
2017-11-30 13:09 ` Ulf Hansson
-- strict thread matches above, loose matches on Subject: below --
2017-11-27 23:51 Milan Stevanovic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).