* [PATCH] clk: mvebu: armada-37xx-periph: Use PTR_ERR_OR_ZERO()
@ 2017-11-28 23:04 Vasyl Gomonovych
2017-12-28 22:56 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Vasyl Gomonovych @ 2017-11-28 23:04 UTC (permalink / raw)
To: linux-clk; +Cc: Vasyl Gomonovych, Michael Turquette, Stephen Boyd, linux-kernel
Fix ptr_ret.cocci warnings:
drivers/clk/mvebu/armada-37xx-periph.c:362:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/clk/mvebu/armada-37xx-periph.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c
index cecb0fdfaef6..72e2ce46f4b0 100644
--- a/drivers/clk/mvebu/armada-37xx-periph.c
+++ b/drivers/clk/mvebu/armada-37xx-periph.c
@@ -359,10 +359,7 @@ static int armada_3700_add_composite_clk(const struct clk_periph_data *data,
mux_ops, rate_hw, rate_ops,
gate_hw, gate_ops, CLK_IGNORE_UNUSED);
- if (IS_ERR(*hw))
- return PTR_ERR(*hw);
-
- return 0;
+ return PTR_ERR_OR_ZERO(*hw);
}
static int armada_3700_periph_clock_probe(struct platform_device *pdev)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: mvebu: armada-37xx-periph: Use PTR_ERR_OR_ZERO()
2017-11-28 23:04 [PATCH] clk: mvebu: armada-37xx-periph: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
@ 2017-12-28 22:56 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2017-12-28 22:56 UTC (permalink / raw)
To: Vasyl Gomonovych; +Cc: linux-clk, Michael Turquette, linux-kernel
On 11/29, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/clk/mvebu/armada-37xx-periph.c:362:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-28 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 23:04 [PATCH] clk: mvebu: armada-37xx-periph: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-12-28 22:56 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).