[PATCH v4 0/6] ARM: Add Variscite DART-MX6 SoM and Carrier-board support

[PATCH v4 0/6] ARM: Add Variscite DART-MX6 SoM and Carrier-board support

[Neil Armstrong]

This patchset adds support for the Variscite DART-MX6 SoM with :
- i.MX6 Quad or Dual Lite SoC
- 1Gb/2Gb LPDDR2
- 4-64 GB eMMC
- Camera Interface
- HDMI+CEC interface
- LVDS / DSI / Parallel RGB interfaces
- Ethernet RGMII interface
- On-SoM Wi-Fi/Bluetooth with WiLink wl1835 SDIO Module
- SD/MMC/SDIO interface
- USB Host + USB OTG interface
- I2C interfaces
- SPI interfaces
- PCI-Express 2.0 interface
- on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface
- Digital Audio interface
- S/PDIF interface

And the Carrier-Board with the following :
- LVDS interface for the VLCD-CAP-GLD-LVDS 7" LCD 800 x 480 touch display
- HDMI Connector
- USB Host + USB OTG Connector
- 10/100/1000 Mbps Ethernet
- miniPCI-Express slot
- SD Card connector
- Audio Headphone/Line In jack connectors
- On-board DMIC
- CAN bus header
- SPI header
- Camera Interfaces header
- 4xButtons, 2xLeds
- OnBoard RTC with Coin Backup battery socket
- RS232 Header + USB-Serial debug port

First patch contains a missing pinmux define used by the SoM.
Last patch contains configs used by the SoM DT like SERDEV or WL18XX support.

PCIe, On-Board DMIC and Camera Interfaces are not handled yet.

Changes since v3 at [3]:
- minor pcie dt fix
- added tags

Changes since v2 at [2]:
- Added bindings acks
- fixed enable-active-high regulators property
- moved hdmi dd-i2c-bus to son dtsi
- fixed pinmux IOMUX value
- add pcie reset-gpio

Changes since v1 at [1]:
- Add lvds display vendor prefix and bindings
- fix all gpio phandle arguments with correct ACTIVE_XXX define
- drop pcie support
- drop custom operating points
- fix arm/pu/soc vin-supply instead of &cpu node override
- fix can pinmux value
- changed button node name
- add revied-by tags on first and last patches

[1] http://lkml.kernel.org/r/1511281705-30849-1-git-send-email-narmstrong@baylibre.com
[2] http://lkml.kernel.org/r/1511348560-28505-1-git-send-email-narmstrong@baylibre.com
[3] http://lkml.kernel.org/r/1511785716-23492-1-git-send-email-narmstrong@baylibre.com

Neil Armstrong (6):
  ARM: dts: imx6qdl-pinfunc: Add missing
    MX6QDL_PAD_ENET_RXD0__OSC32K_32K_OUT
  dt-bindings: Add vendor prefix for Solomon Goldentek Display
    Corporation
  dt-bindings: display: Add bindings for SGD GKTW70SDAE4SE Panel
  ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support
  ARM: dts: imx6q: Add Variscite DART-MX6 Carrier-board support
  ARM: configs: Add missing config for DART-MX6 SoM

 .../bindings/display/panel/sgd,gktw70sdae4se.txt   |  41 ++
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/imx6dl-pinfunc.h                 |   1 +
 arch/arm/boot/dts/imx6q-pinfunc.h                  |   1 +
 arch/arm/boot/dts/imx6q-var-dt6customboard.dts     | 239 ++++++++++
 arch/arm/boot/dts/imx6qdl-var-dart.dtsi            | 504 +++++++++++++++++++++
 arch/arm/configs/imx_v6_v7_defconfig               |   6 +
 8 files changed, 794 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.txt
 create mode 100644 arch/arm/boot/dts/imx6q-var-dt6customboard.dts
 create mode 100644 arch/arm/boot/dts/imx6qdl-var-dart.dtsi

-- 
2.7.4

[PATCH v4 1/6] ARM: dts: imx6qdl-pinfunc: Add missing MX6QDL_PAD_ENET_RXD0__OSC32K_32K_OUT

[Neil Armstrong]

Add missing pinmux entry for OSC32K_32K_OUT on pad ENET_RXD0 used by the
Variscite DART-MX6 SoM.

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm/boot/dts/imx6dl-pinfunc.h | 1 +
 arch/arm/boot/dts/imx6q-pinfunc.h  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/imx6dl-pinfunc.h b/arch/arm/boot/dts/imx6dl-pinfunc.h
index 0ead323..37e430a 100644
--- a/arch/arm/boot/dts/imx6dl-pinfunc.h
+++ b/arch/arm/boot/dts/imx6dl-pinfunc.h
@@ -668,6 +668,7 @@
 #define MX6QDL_PAD_ENET_RX_ER__SPDIF_IN             0x1f4 0x5c4 0x8f0 0x3 0x1
 #define MX6QDL_PAD_ENET_RX_ER__ENET_1588_EVENT2_OUT 0x1f4 0x5c4 0x000 0x4 0x0
 #define MX6QDL_PAD_ENET_RX_ER__GPIO1_IO24           0x1f4 0x5c4 0x000 0x5 0x0
+#define MX6QDL_PAD_ENET_RXD0__OSC32K_32K_OUT        0x1f8 0x5c8 0x000 0x0 0x0
 #define MX6QDL_PAD_ENET_RXD0__ENET_RX_DATA0         0x1f8 0x5c8 0x818 0x1 0x0
 #define MX6QDL_PAD_ENET_RXD0__ESAI_TX_HF_CLK        0x1f8 0x5c8 0x838 0x2 0x0
 #define MX6QDL_PAD_ENET_RXD0__SPDIF_OUT             0x1f8 0x5c8 0x000 0x3 0x0
diff --git a/arch/arm/boot/dts/imx6q-pinfunc.h b/arch/arm/boot/dts/imx6q-pinfunc.h
index 9fc6120..cfb11d3 100644
--- a/arch/arm/boot/dts/imx6q-pinfunc.h
+++ b/arch/arm/boot/dts/imx6q-pinfunc.h
@@ -551,6 +551,7 @@
 #define MX6QDL_PAD_ENET_RXD1__ESAI_TX_FS            0x1e0 0x4f4 0x860 0x2 0x0
 #define MX6QDL_PAD_ENET_RXD1__ENET_1588_EVENT3_OUT  0x1e0 0x4f4 0x000 0x4 0x0
 #define MX6QDL_PAD_ENET_RXD1__GPIO1_IO26            0x1e0 0x4f4 0x000 0x5 0x0
+#define MX6QDL_PAD_ENET_RXD0__OSC32K_32K_OUT        0x1e4 0x4f8 0x000 0x0 0x0
 #define MX6QDL_PAD_ENET_RXD0__ENET_RX_DATA0         0x1e4 0x4f8 0x848 0x1 0x1
 #define MX6QDL_PAD_ENET_RXD0__ESAI_TX_HF_CLK        0x1e4 0x4f8 0x868 0x2 0x0
 #define MX6QDL_PAD_ENET_RXD0__SPDIF_OUT             0x1e4 0x4f8 0x000 0x3 0x0
-- 
2.7.4

[PATCH v4 2/6] dt-bindings: Add vendor prefix for Solomon Goldentek Display Corporation

[Neil Armstrong]

Solomon Goldentek Display Corporation is a Taiwanese LCD/LCM manufacturer.
Company Site: http://www.goldentek.com.tw

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 0994bdd..b0d3bef 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -305,6 +305,7 @@ seagate	Seagate Technology PLC
 semtech	Semtech Corporation
 sensirion	Sensirion AG
 sff	Small Form Factor Committee
+sgd	Solomon Goldentek Display Corporation
 sgx	SGX Sensortech
 sharp	Sharp Corporation
 shimafuji	Shimafuji Electric, Inc.
-- 
2.7.4

[PATCH v4 3/6] dt-bindings: display: Add bindings for SGD GKTW70SDAE4SE Panel

[Neil Armstrong]

The GKTW70SDAE4SE is an LVDS display panel.
Their bindings are modelled on the the LVDS panel bindings.

Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 .../bindings/display/panel/sgd,gktw70sdae4se.txt   | 41 ++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.txt

diff --git a/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.txt b/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.txt
new file mode 100644
index 0000000..d06644b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.txt
@@ -0,0 +1,41 @@
+Solomon Goldentek Display GKTW70SDAE4SE LVDS Display Panel
+==========================================================
+
+The GKTW70SDAE4SE is a 7" WVGA TFT-LCD display panel.
+
+These DT bindings follow the LVDS panel bindings defined in panel-lvds.txt
+with the following device-specific properties.
+
+Required properties:
+
+- compatible: Shall contain "sgd,gktw70sdae4se" and "panel-lvds", in that order.
+
+Example
+-------
+
+panel {
+	compatible = "sgd,gktw70sdae4se", "panel-lvds";
+
+	width-mm = <153>;
+	height-mm = <86>;
+
+	data-mapping = "jeida-18";
+
+	panel-timing {
+		clock-frequency = <32000000>;
+		hactive = <800>;
+		vactive = <480>;
+		hback-porch = <39>;
+		hfront-porch = <39>;
+		vback-porch = <29>;
+		vfront-porch = <13>;
+		hsync-len = <47>;
+		vsync-len = <2>;
+	};
+
+	port {
+		panel_in: endpoint {
+			remote-endpoint = <&lvds_encoder>;
+		};
+	};
+};
-- 
2.7.4

[PATCH v4 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support

[Neil Armstrong]

This patch adds support for the Variscite DART-MX6 SoM with :
- i.MX6 Quad or Dual Lite SoC
- 1Gb/2Gb LPDDR2
- 4-64 GB eMMC
- Camera Interface
- HDMI+CEC interface
- LVDS / DSI / Parallel RGB interfaces
- Ethernet RGMII interface
- On-SoM Wi-Fi/Bluetooth with WiLink wl1835 SDIO Module
- SD/MMC/SDIO interface
- USB Host + USB OTG interface
- I2C interfaces
- SPI interfaces
- PCI-Express 2.0 interface
- on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface
- Digital Audio interface
- S/PDIF interface

Product website : http://www.variscite.com/products/system-on-module-som/cortex-a9/dart-mx6-cpu-freescale-imx6

Support is handled with a SoM-centric dtsi exporting the default interfaces
along the default pinmuxing to be enabled by the board dts file.

Only board-independent devices like WiFi, eMMC or PMIC are enabled in the dtsi.

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 504 ++++++++++++++++++++++++++++++++
 1 file changed, 504 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6qdl-var-dart.dtsi

diff --git a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
new file mode 100644
index 0000000..fd2520b
--- /dev/null
+++ b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
@@ -0,0 +1,504 @@
+/*
+ * Support for Variscite DART-MX6 Module
+ *
+ * Copyright 2017 BayLibre, SAS
+ * Author: Neil Armstrong <narmstrong@baylibre.com>
+ *
+ * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/sound/fsl-imx-audmux.h>
+
+/ {
+	memory {
+		reg = <0x10000000 0x40000000>;
+	};
+
+	reg_3p3v: regulator-3p3v {
+		compatible = "regulator-fixed";
+		regulator-name = "3P3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+	};
+
+	reg_wl18xx_vmmc: regulator-wl18xx {
+		compatible = "regulator-fixed";
+		regulator-name = "vwl1807";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		gpio = <&gpio7 8 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+		startup-delay-us = <70000>;
+	};
+};
+
+&audmux {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_audmux>;
+	status = "okay";
+
+	ssi2 {
+		fsl,audmux-port = <1>;
+		fsl,port-config = <
+			(IMX_AUDMUX_V2_PTCR_SYN |
+			IMX_AUDMUX_V2_PTCR_TFSDIR |
+			IMX_AUDMUX_V2_PTCR_TFSEL(2) |
+			IMX_AUDMUX_V2_PTCR_TCLKDIR |
+			IMX_AUDMUX_V2_PTCR_TCSEL(2))
+			IMX_AUDMUX_V2_PDCR_RXDSEL(2)
+		>;
+	};
+
+	aud3 {
+		fsl,audmux-port = <2>;
+		fsl,port-config = <
+			IMX_AUDMUX_V2_PTCR_SYN
+			IMX_AUDMUX_V2_PDCR_RXDSEL(1)
+		>;
+	};
+};
+
+&can1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_flexcan1>;
+	status = "disabled";
+};
+
+&can2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_flexcan2>;
+	status = "disabled";
+};
+
+&ecspi1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_ecspi1>;
+	status = "disabled";
+};
+
+&fec {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_enet>;
+	phy-mode = "rgmii";
+	status = "disabled";
+};
+
+&hdmi {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hdmicec>;
+	ddc-i2c-bus = <&i2c1>;
+	status = "disabled";
+};
+
+&i2c1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "disabled";
+};
+
+&i2c2 {
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c2>;
+	status = "okay";
+
+	pmic@08 {
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_pmic>;
+		compatible = "fsl,pfuze100";
+		reg = <0x08>;
+
+		regulators {
+			sw1a_reg: sw1ab {
+				regulator-min-microvolt = <300000>;
+				regulator-max-microvolt = <1875000>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-ramp-delay = <6250>;
+			};
+
+			sw1c_reg: sw1c {
+				regulator-min-microvolt = <300000>;
+				regulator-max-microvolt = <1875000>;
+				regulator-boot-on;
+				regulator-always-on;
+				regulator-ramp-delay = <6250>;
+			};
+
+			sw2_reg: sw2 {
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			sw3a_reg: sw3a {
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <3950000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			sw3b_reg: sw3b {
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <3950000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			sw4_reg: sw4 {
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <3950000>;
+			};
+
+			snvs_reg: vsnvs {
+				regulator-min-microvolt = <1200000>;
+				regulator-max-microvolt = <3000000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			vref_reg: vrefddr {
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			vgen6_reg: vgen6 {
+				regulator-min-microvolt = <2800000>;
+				regulator-max-microvolt = <2800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+		};
+	};
+
+	codec: codec@1b {
+		compatible = "ti,tlv320aic3106";
+		reg = <0x1b>;
+		#sound-dai-cells = <0>;
+		DRVDD-supply = <&reg_3p3v>;
+		AVDD-supply = <&reg_3p3v>;
+		IOVDD-supply = <&reg_3p3v>;
+		DVDD-supply = <&reg_3p3v>;
+		ai3x-ocmv = <0>;
+		gpio-reset = <&gpio5 5 GPIO_ACTIVE_LOW>;
+	};
+};
+
+&i2c3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c3>;
+	status = "disabled";
+};
+
+&iomuxc {
+	pinctrl_audmux: audmux {
+		fsl,pins = <
+			MX6QDL_PAD_CSI0_DAT7__AUD3_RXD		0x130b0
+			MX6QDL_PAD_CSI0_DAT4__AUD3_TXC		0x130b0
+			MX6QDL_PAD_CSI0_DAT5__AUD3_TXD		0x110b0
+			MX6QDL_PAD_CSI0_DAT6__AUD3_TXFS		0x130b0
+			/* Audio Clock */
+			MX6QDL_PAD_GPIO_0__CCM_CLKO1		0x130b0
+		>;
+	};
+
+	pinctrl_bt: bt {
+		fsl,pins = <
+			/* Bluetooth enable */
+			MX6QDL_PAD_SD3_DAT6__GPIO6_IO18		0x1b0b1
+			/* Bluetooth Slow Clock */
+			MX6QDL_PAD_ENET_RXD0__OSC32K_32K_OUT	0x000b0
+		>;
+	};
+
+	pinctrl_ecspi1: ecspi1grp {
+		fsl,pins = <
+			MX6QDL_PAD_KEY_COL1__ECSPI1_MISO	0x100b1
+			MX6QDL_PAD_KEY_ROW0__ECSPI1_MOSI	0x100b1
+			MX6QDL_PAD_KEY_COL0__ECSPI1_SCLK	0x100b1
+			/* SPI1 CS0 */
+			MX6QDL_PAD_KEY_ROW1__GPIO4_IO09		0x1b0b0
+			/* SPI1 CS1 */
+			MX6QDL_PAD_KEY_COL2__GPIO4_IO10		0x1b0b0
+		>;
+	};
+
+	pinctrl_enet: enetgrp {
+		fsl,pins = <
+			MX6QDL_PAD_ENET_MDIO__ENET_MDIO		0x100b0
+			MX6QDL_PAD_ENET_MDC__ENET_MDC		0x100b0
+			MX6QDL_PAD_RGMII_TXC__RGMII_TXC		0x10030
+			MX6QDL_PAD_RGMII_TD0__RGMII_TD0		0x10030
+			MX6QDL_PAD_RGMII_TD1__RGMII_TD1		0x10030
+			MX6QDL_PAD_RGMII_TD2__RGMII_TD2		0x10030
+			MX6QDL_PAD_RGMII_TD3__RGMII_TD3		0x10030
+			MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL	0x10030
+			MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK	0x100b0
+			MX6QDL_PAD_RGMII_RXC__RGMII_RXC		0x1b030
+			MX6QDL_PAD_RGMII_RD0__RGMII_RD0		0x1b030
+			MX6QDL_PAD_RGMII_RD1__RGMII_RD1		0x1b030
+			MX6QDL_PAD_RGMII_RD2__RGMII_RD2		0x1b030
+			MX6QDL_PAD_RGMII_RD3__RGMII_RD3		0x1b030
+			MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL	0x1b030
+		>;
+	};
+
+	pinctrl_flexcan1: flexcan1grp {
+		fsl,pins = <
+			MX6QDL_PAD_GPIO_7__FLEXCAN1_TX	0x1b0b0
+			MX6QDL_PAD_GPIO_8__FLEXCAN1_RX	0x1b0b0
+		>;
+	};
+
+	pinctrl_flexcan2: flexcan2grp {
+		fsl,pins = <
+			MX6QDL_PAD_KEY_COL4__FLEXCAN2_TX	0x1b0b0
+			MX6QDL_PAD_KEY_ROW4__FLEXCAN2_RX	0x1b0b0
+		>;
+	};
+
+	pinctrl_hdmicec: hdmicecgrp {
+		fsl,pins = <
+			MX6QDL_PAD_KEY_ROW2__HDMI_TX_CEC_LINE	0x1f8b0
+		>;
+	};
+
+	pinctrl_i2c1: i2c1grp {
+		fsl,pins = <
+			MX6QDL_PAD_CSI0_DAT8__I2C1_SDA	0x4001b8b1
+			MX6QDL_PAD_CSI0_DAT9__I2C1_SCL	0x4001b8b1
+		>;
+	};
+
+	pinctrl_i2c2: i2c2grp {
+		fsl,pins = <
+			MX6QDL_PAD_KEY_COL3__I2C2_SCL	0x4001b8b1
+			MX6QDL_PAD_KEY_ROW3__I2C2_SDA	0x4001b8b1
+		>;
+	};
+
+	pinctrl_i2c3: i2c3grp {
+		fsl,pins = <
+			MX6QDL_PAD_GPIO_5__I2C3_SCL	0x4001b8b1
+			MX6QDL_PAD_GPIO_16__I2C3_SDA	0x4001b8b1
+		>;
+	};
+
+	pinctrl_pmic: pmicgrp {
+		fsl,pins = <
+			/* PMIC INT */
+			MX6QDL_PAD_GPIO_17__GPIO7_IO12	0x1b0b1
+		>;
+	};
+
+	pinctrl_pwm2: pwm2grp {
+		fsl,pins = <
+			MX6QDL_PAD_DISP0_DAT9__PWM2_OUT	0x1b0b1
+		>;
+	};
+
+	pinctrl_uart1: uart1grp {
+		fsl,pins = <
+			MX6QDL_PAD_CSI0_DAT11__UART1_RX_DATA 0x1b0b1
+			MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA 0x1b0b1
+		>;
+	};
+
+	pinctrl_uart2: uart2grp {
+		fsl,pins = <
+			MX6QDL_PAD_SD3_DAT4__UART2_RX_DATA	0x1b0b1
+			MX6QDL_PAD_SD3_DAT5__UART2_TX_DATA	0x1b0b1
+			MX6QDL_PAD_SD4_DAT6__UART2_CTS_B	0x1b0b1
+			MX6QDL_PAD_SD4_DAT5__UART2_RTS_B	0x1b0b1
+		>;
+	};
+
+	pinctrl_uart3: uart3grp {
+		fsl,pins = <
+			MX6QDL_PAD_EIM_D25__UART3_RX_DATA 0x1b0b1
+			MX6QDL_PAD_EIM_D24__UART3_TX_DATA 0x1b0b1
+			MX6QDL_PAD_EIM_D23__UART3_CTS_B   0x1b0b1
+			MX6QDL_PAD_EIM_EB3__UART3_RTS_B   0x1b0b1
+		>;
+	};
+
+	pinctrl_usbotg: usbotggrp {
+		fsl,pins = <
+			MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x17059
+		>;
+	};
+
+	pinctrl_usdhc1: usdhc1grp {
+		fsl,pins = <
+			MX6QDL_PAD_SD1_CMD__SD1_CMD	0x17059
+			MX6QDL_PAD_SD1_CLK__SD1_CLK	0x10059
+			MX6QDL_PAD_SD1_DAT0__SD1_DATA0	0x17059
+			MX6QDL_PAD_SD1_DAT1__SD1_DATA1	0x17059
+			MX6QDL_PAD_SD1_DAT2__SD1_DATA2	0x17059
+			MX6QDL_PAD_SD1_DAT3__SD1_DATA3	0x17059
+			/* WL_EN */
+			MX6QDL_PAD_SD3_DAT7__GPIO6_IO17 0x17071
+			/* WL_IRQ */
+			MX6QDL_PAD_SD3_RST__GPIO7_IO08  0x17071
+		>;
+	};
+
+	pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
+		fsl,pins = <
+			MX6QDL_PAD_SD1_CMD__SD1_CMD	0x170B9
+			MX6QDL_PAD_SD1_CLK__SD1_CLK	0x100B9
+			MX6QDL_PAD_SD1_DAT0__SD1_DATA0	0x170B9
+			MX6QDL_PAD_SD1_DAT1__SD1_DATA1	0x170B9
+			MX6QDL_PAD_SD1_DAT2__SD1_DATA2	0x170B9
+			MX6QDL_PAD_SD1_DAT3__SD1_DATA3	0x170B9
+		>;
+	};
+
+	pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
+		fsl,pins = <
+			MX6QDL_PAD_SD1_CMD__SD1_CMD	0x170F9
+			MX6QDL_PAD_SD1_CLK__SD1_CLK	0x100F9
+			MX6QDL_PAD_SD1_DAT0__SD1_DATA0	0x170F9
+			MX6QDL_PAD_SD1_DAT1__SD1_DATA1	0x170F9
+			MX6QDL_PAD_SD1_DAT2__SD1_DATA2	0x170F9
+			MX6QDL_PAD_SD1_DAT3__SD1_DATA3	0x170F9
+		>;
+	};
+
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX6QDL_PAD_SD2_CMD__SD2_CMD	0x17059
+			MX6QDL_PAD_SD2_CLK__SD2_CLK	0x10059
+			MX6QDL_PAD_SD2_DAT0__SD2_DATA0	0x17059
+			MX6QDL_PAD_SD2_DAT1__SD2_DATA1	0x17059
+			MX6QDL_PAD_SD2_DAT2__SD2_DATA2	0x17059
+			MX6QDL_PAD_SD2_DAT3__SD2_DATA3	0x17059
+		>;
+	};
+
+	pinctrl_usdhc3: usdhc3grp {
+		fsl,pins = <
+			MX6QDL_PAD_SD3_CMD__SD3_CMD	0x17059
+			MX6QDL_PAD_SD3_CLK__SD3_CLK	0x10059
+			MX6QDL_PAD_SD3_DAT0__SD3_DATA0	0x17059
+			MX6QDL_PAD_SD3_DAT1__SD3_DATA1	0x17059
+			MX6QDL_PAD_SD3_DAT2__SD3_DATA2	0x17059
+			MX6QDL_PAD_SD3_DAT3__SD3_DATA3	0x17059
+		>;
+	};
+};
+
+&pcie {
+	fsl,tx-swing-full = <103>;
+	fsl,tx-swing-low = <103>;
+	reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>;
+	status = "disabled";
+};
+
+&pwm2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_pwm2>;
+	status = "disabled";
+};
+
+&reg_arm {
+       vin-supply = <&sw1a_reg>;
+};
+
+&reg_pu {
+       vin-supply = <&sw1c_reg>;
+};
+
+&reg_soc {
+       vin-supply = <&sw1c_reg>;
+};
+
+&uart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart1>;
+	status = "disabled";
+};
+
+&uart2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart2 &pinctrl_bt>;
+	uart-has-rtscts;
+	status = "okay";
+
+	bluetooth {
+		compatible = "ti,wl1835-st";
+		enable-gpios = <&gpio6 18 GPIO_ACTIVE_HIGH>;
+	};
+};
+
+&uart3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart3>;
+	uart-has-rtscts;
+	status = "disabled";
+};
+
+&usbh1 {
+	status = "disabled";
+};
+
+&usbotg {
+	vbus-supply = <&reg_usb_otg_vbus>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usbotg>;
+	disable-over-current;
+	status = "disabled";
+};
+
+&usdhc1 {
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc1>;
+	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+	bus-width = <4>;
+	vmmc-supply = <&reg_wl18xx_vmmc>;
+	non-removable;
+	wakeup-source;
+	keep-power-in-suspend;
+	cap-power-off-card;
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+
+	wlcore: wlcore@2 {
+		compatible = "ti,wl1835";
+		reg = <2>;
+		interrupt-parent = <&gpio6>;
+		interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
+		ref-clock-frequency = <38400000>;
+	};
+};
+
+&usdhc2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usdhc2>;
+	no-1-8-v;
+	keep-power-in-suspend;
+	wakeup-source;
+	status = "disabled";
+};
+
+&usdhc3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usdhc3>;
+	non-removable;
+	keep-power-in-suspend;
+	wakeup-source;
+	status = "okay";
+};
+
+&ssi2 {
+	status = "okay";
+};
+
+&snvs_poweroff {
+	status = "okay";
+};
-- 
2.7.4

[PATCH v4 5/6] ARM: dts: imx6q: Add Variscite DART-MX6 Carrier-board support

[Neil Armstrong]

This patch adds support for the i.MX6 Quad variant of the Variscite DART-MX6
SoM Carrier-Board.

This Carrier-Board has the following :
- LVDS interface for the VLCD-CAP-GLD-LVDS 7" LCD 800 x 480 touch display
- HDMI Connector
- USB Host + USB OTG Connector
- 10/100/1000 Mbps Ethernet
- miniPCI-Express slot
- SD Card connector
- Audio Headphone/Line In jack connectors
- On-board DMIC
- CAN bus header
- SPI header
- Camera Interfaces header
- 4xButtons, 2xLeds
- OnBoard RTC with Coin Backup battery socket
- RS232 Header + USB-Serial debug port

Product Page : http://www.variscite.com/products/evaluation-kits/dart-mx6-kits

The board support is done with all on-board and header interfaces enabled.
7" LVDS Touchscreen is enabled by default along HDMI output.
Audio interface is supported with the "simple-card" bindings.

PCIe slot, On-Board DMIC and Camera Interfaces are not handled yet.

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/imx6q-var-dt6customboard.dts | 239 +++++++++++++++++++++++++
 2 files changed, 240 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6q-var-dt6customboard.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d0381e9..148ff15 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -470,6 +470,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
 	imx6q-tx6q-11x0-mb7.dtb \
 	imx6q-udoo.dtb \
 	imx6q-utilite-pro.dtb \
+	imx6q-var-dt6customboard.dtb \
 	imx6q-wandboard.dtb \
 	imx6q-wandboard-revb1.dtb \
 	imx6q-wandboard-revd1.dtb \
diff --git a/arch/arm/boot/dts/imx6q-var-dt6customboard.dts b/arch/arm/boot/dts/imx6q-var-dt6customboard.dts
new file mode 100644
index 0000000..76faaff
--- /dev/null
+++ b/arch/arm/boot/dts/imx6q-var-dt6customboard.dts
@@ -0,0 +1,239 @@
+/*
+ * Support for Variscite DART-MX6 Carrier-board
+ *
+ * Copyright 2017 BayLibre, SAS
+ * Author: Neil Armstrong <narmstrong@baylibre.com>
+ *
+ * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+ */
+
+/dts-v1/;
+
+#include "imx6q.dtsi"
+#include "imx6qdl-var-dart.dtsi"
+#include <dt-bindings/input/linux-event-codes.h>
+
+/ {
+	model = "Variscite DART-MX6 Carrier-board";
+	compatible = "variscite,dt6customboard", "fsl,imx6q";
+
+	backlight_lvds: backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pwm2 0 50000>;
+		brightness-levels = <0 4 8 16 32 64 128 248>;
+		default-brightness-level = <7>;
+		status = "okay";
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		autorepeat;
+
+		back {
+			gpios = <&gpio4 26 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_BACK>;
+			label = "Key Back";
+			linux,input-type = <1>;
+			debounce-interval = <100>;
+			gpio-key,wakeup;
+		};
+
+		home {
+			gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_HOME>;
+			label = "Key Home";
+			linux,input-type = <1>;
+			debounce-interval = <100>;
+			gpio-key,wakeup;
+		};
+
+		menu {
+			gpios = <&gpio4 25 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_MENU>;
+			label = "Key Menu";
+			linux,input-type = <1>;
+			debounce-interval = <100>;
+			gpio-key,wakeup;
+		};
+	};
+
+	gpio-leds {
+		compatible = "gpio-leds";
+
+		led1 {
+			gpios = <&gpio4 27 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+		};
+
+		led2 {
+			gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-on";
+		};
+	};
+
+	panel1: lvds-panel {
+		compatible = "sgd,gktw70sdae4se", "panel-lvds";
+		backlight = <&backlight_lvds>;
+
+		width-mm = <153>;
+		height-mm = <86>;
+
+		label = "gktw70sdae4se";
+
+		data-mapping = "jeida-18";
+
+		panel-timing {
+			clock-frequency = <32000000>;
+			hactive = <800>;
+			vactive = <480>;
+			hback-porch = <39>;
+			hfront-porch = <39>;
+			vback-porch = <29>;
+			vfront-porch = <13>;
+			hsync-len = <47>;
+			vsync-len = <2>;
+		};
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&lvds1_out>;
+			};
+		};
+	};
+
+	reg_usb_h1_vbus: regulator-usbh1vbus {
+		compatible = "regulator-fixed";
+		regulator-name = "usb_h1_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	reg_usb_otg_vbus: regulator-usbotgvbus {
+		compatible = "regulator-fixed";
+		regulator-name = "usb_otg_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	sound {
+		compatible = "simple-audio-card";
+		simple-audio-card,name = "dt6-customboard-audio";
+		simple-audio-card,format = "i2s";
+		simple-audio-card,bitclock-master = <&sound_codec>;
+		simple-audio-card,frame-master = <&sound_codec>;
+		simple-audio-card,widgets = "Headphone", "Headphone Jack",
+					    "Line", "Line In";
+		simple-audio-card,routing = "Headphone Jack", "HPLOUT",
+					    "Headphone Jack", "HPROUT",
+					    "LINE1L", "Line In",
+					    "LINE1R", "Line In";
+
+		sound_cpu: simple-audio-card,cpu {
+			sound-dai = <&ssi2>;
+		};
+
+		sound_codec: simple-audio-card,codec {
+			sound-dai = <&codec>;
+			clocks = <&clks IMX6QDL_CLK_CKO>;
+		};
+	};
+};
+
+&can1 {
+	status = "okay";
+};
+
+&ecspi1 {
+	cs-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>,
+		   <&gpio4 10 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
+&fec {
+	status = "okay";
+	phy-mode = "rgmii";
+	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+};
+
+&hdmi {
+	status = "okay";
+};
+
+&i2c1 {
+	clock-frequency = <100000>;
+	status = "okay";
+};
+
+&i2c3 {
+	clock-frequency = <100000>;
+	status = "okay";
+
+	touchscreen@38 {
+		compatible = "edt,edt-ft5x06";
+		reg = <0x38>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
+		touchscreen-size-x = <800>;
+		touchscreen-size-y = <480>;
+		touchscreen-inverted-x;
+		touchscreen-inverted-y;
+	};
+
+	rtc@68 {
+		compatible = "isil,isl12057";
+		reg = <0x68>;
+	};
+};
+
+&ldb {
+	status = "okay";
+
+	lvds-channel@1 {
+		status = "okay";
+
+		port@4 {
+			reg = <4>;
+
+			lvds1_out: endpoint {
+				remote-endpoint = <&panel_in>;
+			};
+		};
+	};
+};
+
+&pwm2 {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+};
+
+&uart3 {
+	status = "okay";
+};
+
+&usbh1 {
+	vbus-supply = <&reg_usb_h1_vbus>;
+	status = "okay";
+};
+
+&usbotg {
+	vbus-supply = <&reg_usb_otg_vbus>;
+	dr_mode = "otg";
+	srp-disable;
+	hnp-disable;
+	adp-disable;
+	status = "okay";
+};
+
+&usdhc2 {
+	cd-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
+	status = "okay";
+};
-- 
2.7.4

[PATCH v4 6/6] ARM: configs: Add missing config for DART-MX6 SoM

[Neil Armstrong]

This patch adds the missing configs for the DART-MX6 SoM support :
- SERDEV bluetooth driver + SERIAL_DEV_BUS configs
- WL18XX driver
- DEFAULT_ON Led Trigger

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm/configs/imx_v6_v7_defconfig | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 0d44949..abd06c3 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -80,6 +80,7 @@ CONFIG_CAN=y
 CONFIG_CAN_FLEXCAN=y
 CONFIG_BT=y
 CONFIG_BT_HCIUART=y
+CONFIG_BT_HCIUART_SERDEV=y
 CONFIG_BT_HCIUART_H4=y
 CONFIG_BT_HCIUART_LL=y
 CONFIG_CFG80211=y
@@ -155,6 +156,7 @@ CONFIG_USB_USBNET=y
 CONFIG_USB_NET_CDC_EEM=m
 CONFIG_BRCMFMAC=m
 CONFIG_WL12XX=m
+CONFIG_WL18XX=m
 CONFIG_WLCORE_SDIO=m
 # CONFIG_WILINK_PLATFORM_DATA is not set
 CONFIG_INPUT_EVDEV=y
@@ -185,6 +187,8 @@ CONFIG_SERIAL_IMX=y
 CONFIG_SERIAL_IMX_CONSOLE=y
 CONFIG_SERIAL_FSL_LPUART=y
 CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
+CONFIG_SERIAL_DEV_BUS=y
+CONFIG_SERIAL_DEV_CTRL_TTYPORT=y
 # CONFIG_I2C_COMPAT is not set
 CONFIG_I2C_CHARDEV=y
 CONFIG_I2C_MUX=y
@@ -248,6 +252,7 @@ CONFIG_VIDEO_OV5640=m
 CONFIG_SOC_CAMERA_OV2640=y
 CONFIG_IMX_IPUV3_CORE=y
 CONFIG_DRM=y
+CONFIG_DRM_PANEL_LVDS=y
 CONFIG_DRM_PANEL_SIMPLE=y
 CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
 CONFIG_DRM_DW_HDMI_CEC=y
@@ -340,6 +345,7 @@ CONFIG_LEDS_TRIGGER_ONESHOT=y
 CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_LEDS_TRIGGER_BACKLIGHT=y
 CONFIG_LEDS_TRIGGER_GPIO=y
+CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_INTF_DEV_UIE_EMUL=y
 CONFIG_RTC_DRV_DS1307=y
-- 
2.7.4

Re: [PATCH v4 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support

[Shawn Guo]

On Wed, Nov 29, 2017 at 11:20:55AM +0100, Neil Armstrong wrote:
> This patch adds support for the Variscite DART-MX6 SoM with :
> - i.MX6 Quad or Dual Lite SoC
> - 1Gb/2Gb LPDDR2
> - 4-64 GB eMMC
> - Camera Interface
> - HDMI+CEC interface
> - LVDS / DSI / Parallel RGB interfaces
> - Ethernet RGMII interface
> - On-SoM Wi-Fi/Bluetooth with WiLink wl1835 SDIO Module
> - SD/MMC/SDIO interface
> - USB Host + USB OTG interface
> - I2C interfaces
> - SPI interfaces
> - PCI-Express 2.0 interface
> - on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface
> - Digital Audio interface
> - S/PDIF interface
> 
> Product website : http://www.variscite.com/products/system-on-module-som/cortex-a9/dart-mx6-cpu-freescale-imx6
> 
> Support is handled with a SoM-centric dtsi exporting the default interfaces
> along the default pinmuxing to be enabled by the board dts file.
> 
> Only board-independent devices like WiFi, eMMC or PMIC are enabled in the dtsi.
> 
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Looks pretty good.  Only a couple of minor comments.

> ---
>  arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 504 ++++++++++++++++++++++++++++++++
>  1 file changed, 504 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx6qdl-var-dart.dtsi
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
> new file mode 100644
> index 0000000..fd2520b
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
> @@ -0,0 +1,504 @@
> +/*
> + * Support for Variscite DART-MX6 Module
> + *
> + * Copyright 2017 BayLibre, SAS
> + * Author: Neil Armstrong <narmstrong@baylibre.com>
> + *
> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> + */
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/sound/fsl-imx-audmux.h>
> +
> +/ {
> +	memory {
> +		reg = <0x10000000 0x40000000>;
> +	};
> +
> +	reg_3p3v: regulator-3p3v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "3P3V";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-always-on;
> +	};
> +
> +	reg_wl18xx_vmmc: regulator-wl18xx {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vwl1807";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		gpio = <&gpio7 8 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		startup-delay-us = <70000>;
> +	};
> +};
> +
> +&audmux {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_audmux>;
> +	status = "okay";
> +
> +	ssi2 {
> +		fsl,audmux-port = <1>;
> +		fsl,port-config = <
> +			(IMX_AUDMUX_V2_PTCR_SYN |
> +			IMX_AUDMUX_V2_PTCR_TFSDIR |
> +			IMX_AUDMUX_V2_PTCR_TFSEL(2) |
> +			IMX_AUDMUX_V2_PTCR_TCLKDIR |
> +			IMX_AUDMUX_V2_PTCR_TCSEL(2))
> +			IMX_AUDMUX_V2_PDCR_RXDSEL(2)
> +		>;
> +	};
> +
> +	aud3 {
> +		fsl,audmux-port = <2>;
> +		fsl,port-config = <
> +			IMX_AUDMUX_V2_PTCR_SYN
> +			IMX_AUDMUX_V2_PDCR_RXDSEL(1)
> +		>;
> +	};
> +};
> +
> +&can1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_flexcan1>;
> +	status = "disabled";
> +};
> +
> +&can2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_flexcan2>;
> +	status = "disabled";
> +};
> +
> +&ecspi1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_ecspi1>;
> +	status = "disabled";
> +};
> +
> +&fec {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_enet>;
> +	phy-mode = "rgmii";
> +	status = "disabled";
> +};
> +
> +&hdmi {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_hdmicec>;
> +	ddc-i2c-bus = <&i2c1>;
> +	status = "disabled";
> +};
> +
> +&i2c1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c1>;
> +	status = "disabled";
> +};
> +
> +&i2c2 {
> +	clock-frequency = <100000>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c2>;
> +	status = "okay";
> +
> +	pmic@08 {

Please drop the leading zero in unit-address.

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_pmic>;
> +		compatible = "fsl,pfuze100";
> +		reg = <0x08>;
> +
> +		regulators {
> +			sw1a_reg: sw1ab {
> +				regulator-min-microvolt = <300000>;
> +				regulator-max-microvolt = <1875000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-ramp-delay = <6250>;
> +			};
> +
> +			sw1c_reg: sw1c {
> +				regulator-min-microvolt = <300000>;
> +				regulator-max-microvolt = <1875000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-ramp-delay = <6250>;
> +			};
> +
> +			sw2_reg: sw2 {
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			sw3a_reg: sw3a {
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <3950000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			sw3b_reg: sw3b {
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <3950000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			sw4_reg: sw4 {
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <3950000>;
> +			};
> +
> +			snvs_reg: vsnvs {
> +				regulator-min-microvolt = <1200000>;
> +				regulator-max-microvolt = <3000000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			vref_reg: vrefddr {
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			vgen6_reg: vgen6 {
> +				regulator-min-microvolt = <2800000>;
> +				regulator-max-microvolt = <2800000>;
> +				regulator-always-on;
> +				regulator-boot-on;
> +			};
> +		};
> +	};
> +
> +	codec: codec@1b {

Label should be something specific, maybe tlv320aic3106?

> +		compatible = "ti,tlv320aic3106";
> +		reg = <0x1b>;
> +		#sound-dai-cells = <0>;
> +		DRVDD-supply = <&reg_3p3v>;
> +		AVDD-supply = <&reg_3p3v>;
> +		IOVDD-supply = <&reg_3p3v>;
> +		DVDD-supply = <&reg_3p3v>;
> +		ai3x-ocmv = <0>;
> +		gpio-reset = <&gpio5 5 GPIO_ACTIVE_LOW>;
> +	};
> +};
> +
> +&i2c3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c3>;
> +	status = "disabled";
> +};
> +
> +&iomuxc {
> +	pinctrl_audmux: audmux {
> +		fsl,pins = <
> +			MX6QDL_PAD_CSI0_DAT7__AUD3_RXD		0x130b0
> +			MX6QDL_PAD_CSI0_DAT4__AUD3_TXC		0x130b0
> +			MX6QDL_PAD_CSI0_DAT5__AUD3_TXD		0x110b0
> +			MX6QDL_PAD_CSI0_DAT6__AUD3_TXFS		0x130b0
> +			/* Audio Clock */
> +			MX6QDL_PAD_GPIO_0__CCM_CLKO1		0x130b0
> +		>;
> +	};
> +
> +	pinctrl_bt: bt {
> +		fsl,pins = <
> +			/* Bluetooth enable */
> +			MX6QDL_PAD_SD3_DAT6__GPIO6_IO18		0x1b0b1
> +			/* Bluetooth Slow Clock */
> +			MX6QDL_PAD_ENET_RXD0__OSC32K_32K_OUT	0x000b0
> +		>;
> +	};
> +
> +	pinctrl_ecspi1: ecspi1grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_KEY_COL1__ECSPI1_MISO	0x100b1
> +			MX6QDL_PAD_KEY_ROW0__ECSPI1_MOSI	0x100b1
> +			MX6QDL_PAD_KEY_COL0__ECSPI1_SCLK	0x100b1
> +			/* SPI1 CS0 */
> +			MX6QDL_PAD_KEY_ROW1__GPIO4_IO09		0x1b0b0
> +			/* SPI1 CS1 */
> +			MX6QDL_PAD_KEY_COL2__GPIO4_IO10		0x1b0b0
> +		>;
> +	};
> +
> +	pinctrl_enet: enetgrp {
> +		fsl,pins = <
> +			MX6QDL_PAD_ENET_MDIO__ENET_MDIO		0x100b0
> +			MX6QDL_PAD_ENET_MDC__ENET_MDC		0x100b0
> +			MX6QDL_PAD_RGMII_TXC__RGMII_TXC		0x10030
> +			MX6QDL_PAD_RGMII_TD0__RGMII_TD0		0x10030
> +			MX6QDL_PAD_RGMII_TD1__RGMII_TD1		0x10030
> +			MX6QDL_PAD_RGMII_TD2__RGMII_TD2		0x10030
> +			MX6QDL_PAD_RGMII_TD3__RGMII_TD3		0x10030
> +			MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL	0x10030
> +			MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK	0x100b0
> +			MX6QDL_PAD_RGMII_RXC__RGMII_RXC		0x1b030
> +			MX6QDL_PAD_RGMII_RD0__RGMII_RD0		0x1b030
> +			MX6QDL_PAD_RGMII_RD1__RGMII_RD1		0x1b030
> +			MX6QDL_PAD_RGMII_RD2__RGMII_RD2		0x1b030
> +			MX6QDL_PAD_RGMII_RD3__RGMII_RD3		0x1b030
> +			MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL	0x1b030
> +		>;
> +	};
> +
> +	pinctrl_flexcan1: flexcan1grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_GPIO_7__FLEXCAN1_TX	0x1b0b0
> +			MX6QDL_PAD_GPIO_8__FLEXCAN1_RX	0x1b0b0
> +		>;
> +	};
> +
> +	pinctrl_flexcan2: flexcan2grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_KEY_COL4__FLEXCAN2_TX	0x1b0b0
> +			MX6QDL_PAD_KEY_ROW4__FLEXCAN2_RX	0x1b0b0
> +		>;
> +	};
> +
> +	pinctrl_hdmicec: hdmicecgrp {
> +		fsl,pins = <
> +			MX6QDL_PAD_KEY_ROW2__HDMI_TX_CEC_LINE	0x1f8b0
> +		>;
> +	};
> +
> +	pinctrl_i2c1: i2c1grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_CSI0_DAT8__I2C1_SDA	0x4001b8b1
> +			MX6QDL_PAD_CSI0_DAT9__I2C1_SCL	0x4001b8b1
> +		>;
> +	};
> +
> +	pinctrl_i2c2: i2c2grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_KEY_COL3__I2C2_SCL	0x4001b8b1
> +			MX6QDL_PAD_KEY_ROW3__I2C2_SDA	0x4001b8b1
> +		>;
> +	};
> +
> +	pinctrl_i2c3: i2c3grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_GPIO_5__I2C3_SCL	0x4001b8b1
> +			MX6QDL_PAD_GPIO_16__I2C3_SDA	0x4001b8b1
> +		>;
> +	};
> +
> +	pinctrl_pmic: pmicgrp {
> +		fsl,pins = <
> +			/* PMIC INT */
> +			MX6QDL_PAD_GPIO_17__GPIO7_IO12	0x1b0b1
> +		>;
> +	};
> +
> +	pinctrl_pwm2: pwm2grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_DISP0_DAT9__PWM2_OUT	0x1b0b1
> +		>;
> +	};
> +
> +	pinctrl_uart1: uart1grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_CSI0_DAT11__UART1_RX_DATA 0x1b0b1
> +			MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA 0x1b0b1
> +		>;
> +	};
> +
> +	pinctrl_uart2: uart2grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_SD3_DAT4__UART2_RX_DATA	0x1b0b1
> +			MX6QDL_PAD_SD3_DAT5__UART2_TX_DATA	0x1b0b1
> +			MX6QDL_PAD_SD4_DAT6__UART2_CTS_B	0x1b0b1
> +			MX6QDL_PAD_SD4_DAT5__UART2_RTS_B	0x1b0b1
> +		>;
> +	};
> +
> +	pinctrl_uart3: uart3grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_EIM_D25__UART3_RX_DATA 0x1b0b1
> +			MX6QDL_PAD_EIM_D24__UART3_TX_DATA 0x1b0b1
> +			MX6QDL_PAD_EIM_D23__UART3_CTS_B   0x1b0b1
> +			MX6QDL_PAD_EIM_EB3__UART3_RTS_B   0x1b0b1
> +		>;
> +	};
> +
> +	pinctrl_usbotg: usbotggrp {
> +		fsl,pins = <
> +			MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x17059
> +		>;
> +	};
> +
> +	pinctrl_usdhc1: usdhc1grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_SD1_CMD__SD1_CMD	0x17059
> +			MX6QDL_PAD_SD1_CLK__SD1_CLK	0x10059
> +			MX6QDL_PAD_SD1_DAT0__SD1_DATA0	0x17059
> +			MX6QDL_PAD_SD1_DAT1__SD1_DATA1	0x17059
> +			MX6QDL_PAD_SD1_DAT2__SD1_DATA2	0x17059
> +			MX6QDL_PAD_SD1_DAT3__SD1_DATA3	0x17059
> +			/* WL_EN */
> +			MX6QDL_PAD_SD3_DAT7__GPIO6_IO17 0x17071
> +			/* WL_IRQ */
> +			MX6QDL_PAD_SD3_RST__GPIO7_IO08  0x17071
> +		>;
> +	};
> +
> +	pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
> +		fsl,pins = <
> +			MX6QDL_PAD_SD1_CMD__SD1_CMD	0x170B9
> +			MX6QDL_PAD_SD1_CLK__SD1_CLK	0x100B9
> +			MX6QDL_PAD_SD1_DAT0__SD1_DATA0	0x170B9
> +			MX6QDL_PAD_SD1_DAT1__SD1_DATA1	0x170B9
> +			MX6QDL_PAD_SD1_DAT2__SD1_DATA2	0x170B9
> +			MX6QDL_PAD_SD1_DAT3__SD1_DATA3	0x170B9
> +		>;
> +	};
> +
> +	pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
> +		fsl,pins = <
> +			MX6QDL_PAD_SD1_CMD__SD1_CMD	0x170F9
> +			MX6QDL_PAD_SD1_CLK__SD1_CLK	0x100F9
> +			MX6QDL_PAD_SD1_DAT0__SD1_DATA0	0x170F9
> +			MX6QDL_PAD_SD1_DAT1__SD1_DATA1	0x170F9
> +			MX6QDL_PAD_SD1_DAT2__SD1_DATA2	0x170F9
> +			MX6QDL_PAD_SD1_DAT3__SD1_DATA3	0x170F9
> +		>;
> +	};
> +
> +	pinctrl_usdhc2: usdhc2grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_SD2_CMD__SD2_CMD	0x17059
> +			MX6QDL_PAD_SD2_CLK__SD2_CLK	0x10059
> +			MX6QDL_PAD_SD2_DAT0__SD2_DATA0	0x17059
> +			MX6QDL_PAD_SD2_DAT1__SD2_DATA1	0x17059
> +			MX6QDL_PAD_SD2_DAT2__SD2_DATA2	0x17059
> +			MX6QDL_PAD_SD2_DAT3__SD2_DATA3	0x17059
> +		>;
> +	};
> +
> +	pinctrl_usdhc3: usdhc3grp {
> +		fsl,pins = <
> +			MX6QDL_PAD_SD3_CMD__SD3_CMD	0x17059
> +			MX6QDL_PAD_SD3_CLK__SD3_CLK	0x10059
> +			MX6QDL_PAD_SD3_DAT0__SD3_DATA0	0x17059
> +			MX6QDL_PAD_SD3_DAT1__SD3_DATA1	0x17059
> +			MX6QDL_PAD_SD3_DAT2__SD3_DATA2	0x17059
> +			MX6QDL_PAD_SD3_DAT3__SD3_DATA3	0x17059
> +		>;
> +	};
> +};
> +
> +&pcie {
> +	fsl,tx-swing-full = <103>;
> +	fsl,tx-swing-low = <103>;
> +	reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>;
> +	status = "disabled";
> +};
> +
> +&pwm2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pwm2>;
> +	status = "disabled";
> +};
> +
> +&reg_arm {
> +       vin-supply = <&sw1a_reg>;
> +};
> +
> +&reg_pu {
> +       vin-supply = <&sw1c_reg>;
> +};
> +
> +&reg_soc {
> +       vin-supply = <&sw1c_reg>;
> +};
> +
> +&uart1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart1>;
> +	status = "disabled";
> +};
> +
> +&uart2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart2 &pinctrl_bt>;
> +	uart-has-rtscts;
> +	status = "okay";
> +
> +	bluetooth {
> +		compatible = "ti,wl1835-st";
> +		enable-gpios = <&gpio6 18 GPIO_ACTIVE_HIGH>;
> +	};
> +};
> +
> +&uart3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart3>;
> +	uart-has-rtscts;
> +	status = "disabled";
> +};
> +
> +&usbh1 {
> +	status = "disabled";
> +};
> +
> +&usbotg {
> +	vbus-supply = <&reg_usb_otg_vbus>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usbotg>;
> +	disable-over-current;
> +	status = "disabled";
> +};
> +
> +&usdhc1 {
> +	pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +	pinctrl-0 = <&pinctrl_usdhc1>;
> +	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
> +	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
> +	bus-width = <4>;
> +	vmmc-supply = <&reg_wl18xx_vmmc>;
> +	non-removable;
> +	wakeup-source;
> +	keep-power-in-suspend;
> +	cap-power-off-card;
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +
> +	wlcore: wlcore@2 {
> +		compatible = "ti,wl1835";
> +		reg = <2>;
> +		interrupt-parent = <&gpio6>;
> +		interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
> +		ref-clock-frequency = <38400000>;
> +	};
> +};
> +
> +&usdhc2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usdhc2>;
> +	no-1-8-v;
> +	keep-power-in-suspend;
> +	wakeup-source;
> +	status = "disabled";
> +};
> +
> +&usdhc3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usdhc3>;
> +	non-removable;
> +	keep-power-in-suspend;
> +	wakeup-source;
> +	status = "okay";
> +};
> +
> +&ssi2 {
> +	status = "okay";
> +};
> +
> +&snvs_poweroff {
> +	status = "okay";
> +};

The last two nodes break the alphabetical order.

Shawn
> -- 
> 2.7.4
> 

Re: [PATCH v4 5/6] ARM: dts: imx6q: Add Variscite DART-MX6 Carrier-board support

[Shawn Guo]

On Wed, Nov 29, 2017 at 11:20:56AM +0100, Neil Armstrong wrote:
> This patch adds support for the i.MX6 Quad variant of the Variscite DART-MX6
> SoM Carrier-Board.
> 
> This Carrier-Board has the following :
> - LVDS interface for the VLCD-CAP-GLD-LVDS 7" LCD 800 x 480 touch display
> - HDMI Connector
> - USB Host + USB OTG Connector
> - 10/100/1000 Mbps Ethernet
> - miniPCI-Express slot
> - SD Card connector
> - Audio Headphone/Line In jack connectors
> - On-board DMIC
> - CAN bus header
> - SPI header
> - Camera Interfaces header
> - 4xButtons, 2xLeds
> - OnBoard RTC with Coin Backup battery socket
> - RS232 Header + USB-Serial debug port
> 
> Product Page : http://www.variscite.com/products/evaluation-kits/dart-mx6-kits
> 
> The board support is done with all on-board and header interfaces enabled.
> 7" LVDS Touchscreen is enabled by default along HDMI output.
> Audio interface is supported with the "simple-card" bindings.
> 
> PCIe slot, On-Board DMIC and Camera Interfaces are not handled yet.
> 
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  arch/arm/boot/dts/Makefile                     |   1 +
>  arch/arm/boot/dts/imx6q-var-dt6customboard.dts | 239 +++++++++++++++++++++++++
>  2 files changed, 240 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx6q-var-dt6customboard.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d0381e9..148ff15 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -470,6 +470,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>  	imx6q-tx6q-11x0-mb7.dtb \
>  	imx6q-udoo.dtb \
>  	imx6q-utilite-pro.dtb \
> +	imx6q-var-dt6customboard.dtb \
>  	imx6q-wandboard.dtb \
>  	imx6q-wandboard-revb1.dtb \
>  	imx6q-wandboard-revd1.dtb \
> diff --git a/arch/arm/boot/dts/imx6q-var-dt6customboard.dts b/arch/arm/boot/dts/imx6q-var-dt6customboard.dts
> new file mode 100644
> index 0000000..76faaff
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6q-var-dt6customboard.dts
> @@ -0,0 +1,239 @@
> +/*
> + * Support for Variscite DART-MX6 Carrier-board
> + *
> + * Copyright 2017 BayLibre, SAS
> + * Author: Neil Armstrong <narmstrong@baylibre.com>
> + *
> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6q.dtsi"
> +#include "imx6qdl-var-dart.dtsi"
> +#include <dt-bindings/input/linux-event-codes.h>
> +
> +/ {
> +	model = "Variscite DART-MX6 Carrier-board";
> +	compatible = "variscite,dt6customboard", "fsl,imx6q";
> +
> +	backlight_lvds: backlight {
> +		compatible = "pwm-backlight";
> +		pwms = <&pwm2 0 50000>;
> +		brightness-levels = <0 4 8 16 32 64 128 248>;
> +		default-brightness-level = <7>;
> +		status = "okay";
> +	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		autorepeat;
> +
> +		back {
> +			gpios = <&gpio4 26 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_BACK>;
> +			label = "Key Back";
> +			linux,input-type = <1>;
> +			debounce-interval = <100>;
> +			gpio-key,wakeup;

The gpio-key,wakeup is legacy one.  Use wakeup-source instead.

> +		};
> +
> +		home {
> +			gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_HOME>;
> +			label = "Key Home";
> +			linux,input-type = <1>;
> +			debounce-interval = <100>;
> +			gpio-key,wakeup;
> +		};
> +
> +		menu {
> +			gpios = <&gpio4 25 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_MENU>;
> +			label = "Key Menu";
> +			linux,input-type = <1>;
> +			debounce-interval = <100>;
> +			gpio-key,wakeup;
> +		};
> +	};
> +
> +	gpio-leds {
> +		compatible = "gpio-leds";
> +
> +		led1 {
> +			gpios = <&gpio4 27 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "heartbeat";
> +		};
> +
> +		led2 {
> +			gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "default-on";
> +		};
> +	};
> +
> +	panel1: lvds-panel {
> +		compatible = "sgd,gktw70sdae4se", "panel-lvds";
> +		backlight = <&backlight_lvds>;
> +
> +		width-mm = <153>;
> +		height-mm = <86>;
> +
> +		label = "gktw70sdae4se";
> +

Nit: these lines in middle of property list is not really necessary.
Can we drop them?

Shawn

> +		data-mapping = "jeida-18";
> +
> +		panel-timing {
> +			clock-frequency = <32000000>;
> +			hactive = <800>;
> +			vactive = <480>;
> +			hback-porch = <39>;
> +			hfront-porch = <39>;
> +			vback-porch = <29>;
> +			vfront-porch = <13>;
> +			hsync-len = <47>;
> +			vsync-len = <2>;
> +		};
> +
> +		port {
> +			panel_in: endpoint {
> +				remote-endpoint = <&lvds1_out>;
> +			};
> +		};
> +	};
> +
> +	reg_usb_h1_vbus: regulator-usbh1vbus {
> +		compatible = "regulator-fixed";
> +		regulator-name = "usb_h1_vbus";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
> +
> +	reg_usb_otg_vbus: regulator-usbotgvbus {
> +		compatible = "regulator-fixed";
> +		regulator-name = "usb_otg_vbus";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
> +
> +	sound {
> +		compatible = "simple-audio-card";
> +		simple-audio-card,name = "dt6-customboard-audio";
> +		simple-audio-card,format = "i2s";
> +		simple-audio-card,bitclock-master = <&sound_codec>;
> +		simple-audio-card,frame-master = <&sound_codec>;
> +		simple-audio-card,widgets = "Headphone", "Headphone Jack",
> +					    "Line", "Line In";
> +		simple-audio-card,routing = "Headphone Jack", "HPLOUT",
> +					    "Headphone Jack", "HPROUT",
> +					    "LINE1L", "Line In",
> +					    "LINE1R", "Line In";
> +
> +		sound_cpu: simple-audio-card,cpu {
> +			sound-dai = <&ssi2>;
> +		};
> +
> +		sound_codec: simple-audio-card,codec {
> +			sound-dai = <&codec>;
> +			clocks = <&clks IMX6QDL_CLK_CKO>;
> +		};
> +	};
> +};
> +
> +&can1 {
> +	status = "okay";
> +};
> +
> +&ecspi1 {
> +	cs-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>,
> +		   <&gpio4 10 GPIO_ACTIVE_HIGH>;
> +	status = "okay";
> +};
> +
> +&fec {
> +	status = "okay";
> +	phy-mode = "rgmii";
> +	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> +};
> +
> +&hdmi {
> +	status = "okay";
> +};
> +
> +&i2c1 {
> +	clock-frequency = <100000>;
> +	status = "okay";
> +};
> +
> +&i2c3 {
> +	clock-frequency = <100000>;
> +	status = "okay";
> +
> +	touchscreen@38 {
> +		compatible = "edt,edt-ft5x06";
> +		reg = <0x38>;
> +		interrupt-parent = <&gpio1>;
> +		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> +		touchscreen-size-x = <800>;
> +		touchscreen-size-y = <480>;
> +		touchscreen-inverted-x;
> +		touchscreen-inverted-y;
> +	};
> +
> +	rtc@68 {
> +		compatible = "isil,isl12057";
> +		reg = <0x68>;
> +	};
> +};
> +
> +&ldb {
> +	status = "okay";
> +
> +	lvds-channel@1 {
> +		status = "okay";
> +
> +		port@4 {
> +			reg = <4>;
> +
> +			lvds1_out: endpoint {
> +				remote-endpoint = <&panel_in>;
> +			};
> +		};
> +	};
> +};
> +
> +&pwm2 {
> +	status = "okay";
> +};
> +
> +&uart1 {
> +	status = "okay";
> +};
> +
> +&uart3 {
> +	status = "okay";
> +};
> +
> +&usbh1 {
> +	vbus-supply = <&reg_usb_h1_vbus>;
> +	status = "okay";
> +};
> +
> +&usbotg {
> +	vbus-supply = <&reg_usb_otg_vbus>;
> +	dr_mode = "otg";
> +	srp-disable;
> +	hnp-disable;
> +	adp-disable;
> +	status = "okay";
> +};
> +
> +&usdhc2 {
> +	cd-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
> +	status = "okay";
> +};
> -- 
> 2.7.4
> 

Re: [PATCH v4 6/6] ARM: configs: Add missing config for DART-MX6 SoM

[Shawn Guo]

On Wed, Nov 29, 2017 at 11:20:57AM +0100, Neil Armstrong wrote:
> This patch adds the missing configs for the DART-MX6 SoM support :
> - SERDEV bluetooth driver + SERIAL_DEV_BUS configs
> - WL18XX driver
> - DEFAULT_ON Led Trigger
> 
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

'ARM: imx_v6_v7_defconfig: ...' or 'ARM: imx: defconfig: ...' please.

Shawn

> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 0d44949..abd06c3 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -80,6 +80,7 @@ CONFIG_CAN=y
>  CONFIG_CAN_FLEXCAN=y
>  CONFIG_BT=y
>  CONFIG_BT_HCIUART=y
> +CONFIG_BT_HCIUART_SERDEV=y
>  CONFIG_BT_HCIUART_H4=y
>  CONFIG_BT_HCIUART_LL=y
>  CONFIG_CFG80211=y
> @@ -155,6 +156,7 @@ CONFIG_USB_USBNET=y
>  CONFIG_USB_NET_CDC_EEM=m
>  CONFIG_BRCMFMAC=m
>  CONFIG_WL12XX=m
> +CONFIG_WL18XX=m
>  CONFIG_WLCORE_SDIO=m
>  # CONFIG_WILINK_PLATFORM_DATA is not set
>  CONFIG_INPUT_EVDEV=y
> @@ -185,6 +187,8 @@ CONFIG_SERIAL_IMX=y
>  CONFIG_SERIAL_IMX_CONSOLE=y
>  CONFIG_SERIAL_FSL_LPUART=y
>  CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
> +CONFIG_SERIAL_DEV_BUS=y
> +CONFIG_SERIAL_DEV_CTRL_TTYPORT=y
>  # CONFIG_I2C_COMPAT is not set
>  CONFIG_I2C_CHARDEV=y
>  CONFIG_I2C_MUX=y
> @@ -248,6 +252,7 @@ CONFIG_VIDEO_OV5640=m
>  CONFIG_SOC_CAMERA_OV2640=y
>  CONFIG_IMX_IPUV3_CORE=y
>  CONFIG_DRM=y
> +CONFIG_DRM_PANEL_LVDS=y
>  CONFIG_DRM_PANEL_SIMPLE=y
>  CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
>  CONFIG_DRM_DW_HDMI_CEC=y
> @@ -340,6 +345,7 @@ CONFIG_LEDS_TRIGGER_ONESHOT=y
>  CONFIG_LEDS_TRIGGER_HEARTBEAT=y
>  CONFIG_LEDS_TRIGGER_BACKLIGHT=y
>  CONFIG_LEDS_TRIGGER_GPIO=y
> +CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_INTF_DEV_UIE_EMUL=y
>  CONFIG_RTC_DRV_DS1307=y
> -- 
> 2.7.4
> 

Re: [PATCH v4 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support

[Neil Armstrong]

On 30/11/2017 01:39, Shawn Guo wrote:
> On Wed, Nov 29, 2017 at 11:20:55AM +0100, Neil Armstrong wrote:
>> This patch adds support for the Variscite DART-MX6 SoM with :
>> - i.MX6 Quad or Dual Lite SoC
>> - 1Gb/2Gb LPDDR2
>> - 4-64 GB eMMC
>> - Camera Interface
>> - HDMI+CEC interface
>> - LVDS / DSI / Parallel RGB interfaces
>> - Ethernet RGMII interface
>> - On-SoM Wi-Fi/Bluetooth with WiLink wl1835 SDIO Module
>> - SD/MMC/SDIO interface
>> - USB Host + USB OTG interface
>> - I2C interfaces
>> - SPI interfaces
>> - PCI-Express 2.0 interface
>> - on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface
>> - Digital Audio interface
>> - S/PDIF interface
>>
>> Product website : http://www.variscite.com/products/system-on-module-som/cortex-a9/dart-mx6-cpu-freescale-imx6
>>
>> Support is handled with a SoM-centric dtsi exporting the default interfaces
>> along the default pinmuxing to be enabled by the board dts file.
>>
>> Only board-independent devices like WiFi, eMMC or PMIC are enabled in the dtsi.
>>
>> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> 
> Looks pretty good.  Only a couple of minor comments.
> 
>> ---
>>  arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 504 ++++++++++++++++++++++++++++++++
>>  1 file changed, 504 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>> new file mode 100644
>> index 0000000..fd2520b
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>> @@ -0,0 +1,504 @@
>> +/*
>> + * Support for Variscite DART-MX6 Module
>> + *
>> + * Copyright 2017 BayLibre, SAS
>> + * Author: Neil Armstrong <narmstrong@baylibre.com>
>> + *
>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> + */
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/sound/fsl-imx-audmux.h>
>> +
>> +/ {
>> +	memory {
>> +		reg = <0x10000000 0x40000000>;
>> +	};
>> +
>> +	reg_3p3v: regulator-3p3v {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "3P3V";
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +		regulator-always-on;
>> +	};
>> +
>> +	reg_wl18xx_vmmc: regulator-wl18xx {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vwl1807";
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +		gpio = <&gpio7 8 GPIO_ACTIVE_HIGH>;
>> +		enable-active-high;
>> +		startup-delay-us = <70000>;
>> +	};
>> +};
>> +
>> +&audmux {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_audmux>;
>> +	status = "okay";
>> +
>> +	ssi2 {
>> +		fsl,audmux-port = <1>;
>> +		fsl,port-config = <
>> +			(IMX_AUDMUX_V2_PTCR_SYN |
>> +			IMX_AUDMUX_V2_PTCR_TFSDIR |
>> +			IMX_AUDMUX_V2_PTCR_TFSEL(2) |
>> +			IMX_AUDMUX_V2_PTCR_TCLKDIR |
>> +			IMX_AUDMUX_V2_PTCR_TCSEL(2))
>> +			IMX_AUDMUX_V2_PDCR_RXDSEL(2)
>> +		>;
>> +	};
>> +
>> +	aud3 {
>> +		fsl,audmux-port = <2>;
>> +		fsl,port-config = <
>> +			IMX_AUDMUX_V2_PTCR_SYN
>> +			IMX_AUDMUX_V2_PDCR_RXDSEL(1)
>> +		>;
>> +	};
>> +};
>> +
>> +&can1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_flexcan1>;
>> +	status = "disabled";
>> +};
>> +
>> +&can2 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_flexcan2>;
>> +	status = "disabled";
>> +};
>> +
>> +&ecspi1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_ecspi1>;
>> +	status = "disabled";
>> +};
>> +
>> +&fec {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_enet>;
>> +	phy-mode = "rgmii";
>> +	status = "disabled";
>> +};
>> +
>> +&hdmi {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_hdmicec>;
>> +	ddc-i2c-bus = <&i2c1>;
>> +	status = "disabled";
>> +};
>> +
>> +&i2c1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_i2c1>;
>> +	status = "disabled";
>> +};
>> +
>> +&i2c2 {
>> +	clock-frequency = <100000>;
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_i2c2>;
>> +	status = "okay";
>> +
>> +	pmic@08 {
> 
> Please drop the leading zero in unit-address.

Fixed

> 
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pinctrl_pmic>;
>> +		compatible = "fsl,pfuze100";
>> +		reg = <0x08>;
>> +
>> +		regulators {
>> +			sw1a_reg: sw1ab {
>> +				regulator-min-microvolt = <300000>;
>> +				regulator-max-microvolt = <1875000>;
>> +				regulator-boot-on;
>> +				regulator-always-on;
>> +				regulator-ramp-delay = <6250>;
>> +			};
>> +
>> +			sw1c_reg: sw1c {
>> +				regulator-min-microvolt = <300000>;
>> +				regulator-max-microvolt = <1875000>;
>> +				regulator-boot-on;
>> +				regulator-always-on;
>> +				regulator-ramp-delay = <6250>;
>> +			};
>> +
>> +			sw2_reg: sw2 {
>> +				regulator-min-microvolt = <800000>;
>> +				regulator-max-microvolt = <3300000>;
>> +				regulator-boot-on;
>> +				regulator-always-on;
>> +			};
>> +
>> +			sw3a_reg: sw3a {
>> +				regulator-min-microvolt = <800000>;
>> +				regulator-max-microvolt = <3950000>;
>> +				regulator-boot-on;
>> +				regulator-always-on;
>> +			};
>> +
>> +			sw3b_reg: sw3b {
>> +				regulator-min-microvolt = <800000>;
>> +				regulator-max-microvolt = <3950000>;
>> +				regulator-boot-on;
>> +				regulator-always-on;
>> +			};
>> +
>> +			sw4_reg: sw4 {
>> +				regulator-min-microvolt = <800000>;
>> +				regulator-max-microvolt = <3950000>;
>> +			};
>> +
>> +			snvs_reg: vsnvs {
>> +				regulator-min-microvolt = <1200000>;
>> +				regulator-max-microvolt = <3000000>;
>> +				regulator-boot-on;
>> +				regulator-always-on;
>> +			};
>> +
>> +			vref_reg: vrefddr {
>> +				regulator-boot-on;
>> +				regulator-always-on;
>> +			};
>> +
>> +			vgen6_reg: vgen6 {
>> +				regulator-min-microvolt = <2800000>;
>> +				regulator-max-microvolt = <2800000>;
>> +				regulator-always-on;
>> +				regulator-boot-on;
>> +			};
>> +		};
>> +	};
>> +
>> +	codec: codec@1b {
> 
> Label should be something specific, maybe tlv320aic3106?

Changed to tlv320aic3106 and in the dts file

> 
>> +		compatible = "ti,tlv320aic3106";
>> +		reg = <0x1b>;
>> +		#sound-dai-cells = <0>;
>> +		DRVDD-supply = <&reg_3p3v>;
>> +		AVDD-supply = <&reg_3p3v>;
>> +		IOVDD-supply = <&reg_3p3v>;
>> +		DVDD-supply = <&reg_3p3v>;
>> +		ai3x-ocmv = <0>;
>> +		gpio-reset = <&gpio5 5 GPIO_ACTIVE_LOW>;
>> +	};
>> +};
>> +
>> +&i2c3 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_i2c3>;
>> +	status = "disabled";
>> +};
>> +
>> +&iomuxc {
>> +	pinctrl_audmux: audmux {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_CSI0_DAT7__AUD3_RXD		0x130b0
>> +			MX6QDL_PAD_CSI0_DAT4__AUD3_TXC		0x130b0
>> +			MX6QDL_PAD_CSI0_DAT5__AUD3_TXD		0x110b0
>> +			MX6QDL_PAD_CSI0_DAT6__AUD3_TXFS		0x130b0
>> +			/* Audio Clock */
>> +			MX6QDL_PAD_GPIO_0__CCM_CLKO1		0x130b0
>> +		>;
>> +	};
>> +
>> +	pinctrl_bt: bt {
>> +		fsl,pins = <
>> +			/* Bluetooth enable */
>> +			MX6QDL_PAD_SD3_DAT6__GPIO6_IO18		0x1b0b1
>> +			/* Bluetooth Slow Clock */
>> +			MX6QDL_PAD_ENET_RXD0__OSC32K_32K_OUT	0x000b0
>> +		>;
>> +	};
>> +
>> +	pinctrl_ecspi1: ecspi1grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_KEY_COL1__ECSPI1_MISO	0x100b1
>> +			MX6QDL_PAD_KEY_ROW0__ECSPI1_MOSI	0x100b1
>> +			MX6QDL_PAD_KEY_COL0__ECSPI1_SCLK	0x100b1
>> +			/* SPI1 CS0 */
>> +			MX6QDL_PAD_KEY_ROW1__GPIO4_IO09		0x1b0b0
>> +			/* SPI1 CS1 */
>> +			MX6QDL_PAD_KEY_COL2__GPIO4_IO10		0x1b0b0
>> +		>;
>> +	};
>> +
>> +	pinctrl_enet: enetgrp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_ENET_MDIO__ENET_MDIO		0x100b0
>> +			MX6QDL_PAD_ENET_MDC__ENET_MDC		0x100b0
>> +			MX6QDL_PAD_RGMII_TXC__RGMII_TXC		0x10030
>> +			MX6QDL_PAD_RGMII_TD0__RGMII_TD0		0x10030
>> +			MX6QDL_PAD_RGMII_TD1__RGMII_TD1		0x10030
>> +			MX6QDL_PAD_RGMII_TD2__RGMII_TD2		0x10030
>> +			MX6QDL_PAD_RGMII_TD3__RGMII_TD3		0x10030
>> +			MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL	0x10030
>> +			MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK	0x100b0
>> +			MX6QDL_PAD_RGMII_RXC__RGMII_RXC		0x1b030
>> +			MX6QDL_PAD_RGMII_RD0__RGMII_RD0		0x1b030
>> +			MX6QDL_PAD_RGMII_RD1__RGMII_RD1		0x1b030
>> +			MX6QDL_PAD_RGMII_RD2__RGMII_RD2		0x1b030
>> +			MX6QDL_PAD_RGMII_RD3__RGMII_RD3		0x1b030
>> +			MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL	0x1b030
>> +		>;
>> +	};
>> +
>> +	pinctrl_flexcan1: flexcan1grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_GPIO_7__FLEXCAN1_TX	0x1b0b0
>> +			MX6QDL_PAD_GPIO_8__FLEXCAN1_RX	0x1b0b0
>> +		>;
>> +	};
>> +
>> +	pinctrl_flexcan2: flexcan2grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_KEY_COL4__FLEXCAN2_TX	0x1b0b0
>> +			MX6QDL_PAD_KEY_ROW4__FLEXCAN2_RX	0x1b0b0
>> +		>;
>> +	};
>> +
>> +	pinctrl_hdmicec: hdmicecgrp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_KEY_ROW2__HDMI_TX_CEC_LINE	0x1f8b0
>> +		>;
>> +	};
>> +
>> +	pinctrl_i2c1: i2c1grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_CSI0_DAT8__I2C1_SDA	0x4001b8b1
>> +			MX6QDL_PAD_CSI0_DAT9__I2C1_SCL	0x4001b8b1
>> +		>;
>> +	};
>> +
>> +	pinctrl_i2c2: i2c2grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_KEY_COL3__I2C2_SCL	0x4001b8b1
>> +			MX6QDL_PAD_KEY_ROW3__I2C2_SDA	0x4001b8b1
>> +		>;
>> +	};
>> +
>> +	pinctrl_i2c3: i2c3grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_GPIO_5__I2C3_SCL	0x4001b8b1
>> +			MX6QDL_PAD_GPIO_16__I2C3_SDA	0x4001b8b1
>> +		>;
>> +	};
>> +
>> +	pinctrl_pmic: pmicgrp {
>> +		fsl,pins = <
>> +			/* PMIC INT */
>> +			MX6QDL_PAD_GPIO_17__GPIO7_IO12	0x1b0b1
>> +		>;
>> +	};
>> +
>> +	pinctrl_pwm2: pwm2grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_DISP0_DAT9__PWM2_OUT	0x1b0b1
>> +		>;
>> +	};
>> +
>> +	pinctrl_uart1: uart1grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_CSI0_DAT11__UART1_RX_DATA 0x1b0b1
>> +			MX6QDL_PAD_CSI0_DAT10__UART1_TX_DATA 0x1b0b1
>> +		>;
>> +	};
>> +
>> +	pinctrl_uart2: uart2grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_SD3_DAT4__UART2_RX_DATA	0x1b0b1
>> +			MX6QDL_PAD_SD3_DAT5__UART2_TX_DATA	0x1b0b1
>> +			MX6QDL_PAD_SD4_DAT6__UART2_CTS_B	0x1b0b1
>> +			MX6QDL_PAD_SD4_DAT5__UART2_RTS_B	0x1b0b1
>> +		>;
>> +	};
>> +
>> +	pinctrl_uart3: uart3grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_EIM_D25__UART3_RX_DATA 0x1b0b1
>> +			MX6QDL_PAD_EIM_D24__UART3_TX_DATA 0x1b0b1
>> +			MX6QDL_PAD_EIM_D23__UART3_CTS_B   0x1b0b1
>> +			MX6QDL_PAD_EIM_EB3__UART3_RTS_B   0x1b0b1
>> +		>;
>> +	};
>> +
>> +	pinctrl_usbotg: usbotggrp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x17059
>> +		>;
>> +	};
>> +
>> +	pinctrl_usdhc1: usdhc1grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_SD1_CMD__SD1_CMD	0x17059
>> +			MX6QDL_PAD_SD1_CLK__SD1_CLK	0x10059
>> +			MX6QDL_PAD_SD1_DAT0__SD1_DATA0	0x17059
>> +			MX6QDL_PAD_SD1_DAT1__SD1_DATA1	0x17059
>> +			MX6QDL_PAD_SD1_DAT2__SD1_DATA2	0x17059
>> +			MX6QDL_PAD_SD1_DAT3__SD1_DATA3	0x17059
>> +			/* WL_EN */
>> +			MX6QDL_PAD_SD3_DAT7__GPIO6_IO17 0x17071
>> +			/* WL_IRQ */
>> +			MX6QDL_PAD_SD3_RST__GPIO7_IO08  0x17071
>> +		>;
>> +	};
>> +
>> +	pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_SD1_CMD__SD1_CMD	0x170B9
>> +			MX6QDL_PAD_SD1_CLK__SD1_CLK	0x100B9
>> +			MX6QDL_PAD_SD1_DAT0__SD1_DATA0	0x170B9
>> +			MX6QDL_PAD_SD1_DAT1__SD1_DATA1	0x170B9
>> +			MX6QDL_PAD_SD1_DAT2__SD1_DATA2	0x170B9
>> +			MX6QDL_PAD_SD1_DAT3__SD1_DATA3	0x170B9
>> +		>;
>> +	};
>> +
>> +	pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_SD1_CMD__SD1_CMD	0x170F9
>> +			MX6QDL_PAD_SD1_CLK__SD1_CLK	0x100F9
>> +			MX6QDL_PAD_SD1_DAT0__SD1_DATA0	0x170F9
>> +			MX6QDL_PAD_SD1_DAT1__SD1_DATA1	0x170F9
>> +			MX6QDL_PAD_SD1_DAT2__SD1_DATA2	0x170F9
>> +			MX6QDL_PAD_SD1_DAT3__SD1_DATA3	0x170F9
>> +		>;
>> +	};
>> +
>> +	pinctrl_usdhc2: usdhc2grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_SD2_CMD__SD2_CMD	0x17059
>> +			MX6QDL_PAD_SD2_CLK__SD2_CLK	0x10059
>> +			MX6QDL_PAD_SD2_DAT0__SD2_DATA0	0x17059
>> +			MX6QDL_PAD_SD2_DAT1__SD2_DATA1	0x17059
>> +			MX6QDL_PAD_SD2_DAT2__SD2_DATA2	0x17059
>> +			MX6QDL_PAD_SD2_DAT3__SD2_DATA3	0x17059
>> +		>;
>> +	};
>> +
>> +	pinctrl_usdhc3: usdhc3grp {
>> +		fsl,pins = <
>> +			MX6QDL_PAD_SD3_CMD__SD3_CMD	0x17059
>> +			MX6QDL_PAD_SD3_CLK__SD3_CLK	0x10059
>> +			MX6QDL_PAD_SD3_DAT0__SD3_DATA0	0x17059
>> +			MX6QDL_PAD_SD3_DAT1__SD3_DATA1	0x17059
>> +			MX6QDL_PAD_SD3_DAT2__SD3_DATA2	0x17059
>> +			MX6QDL_PAD_SD3_DAT3__SD3_DATA3	0x17059
>> +		>;
>> +	};
>> +};
>> +
>> +&pcie {
>> +	fsl,tx-swing-full = <103>;
>> +	fsl,tx-swing-low = <103>;
>> +	reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>;
>> +	status = "disabled";
>> +};
>> +
>> +&pwm2 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_pwm2>;
>> +	status = "disabled";
>> +};
>> +
>> +&reg_arm {
>> +       vin-supply = <&sw1a_reg>;
>> +};
>> +
>> +&reg_pu {
>> +       vin-supply = <&sw1c_reg>;
>> +};
>> +
>> +&reg_soc {
>> +       vin-supply = <&sw1c_reg>;
>> +};
>> +
>> +&uart1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_uart1>;
>> +	status = "disabled";
>> +};
>> +
>> +&uart2 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_uart2 &pinctrl_bt>;
>> +	uart-has-rtscts;
>> +	status = "okay";
>> +
>> +	bluetooth {
>> +		compatible = "ti,wl1835-st";
>> +		enable-gpios = <&gpio6 18 GPIO_ACTIVE_HIGH>;
>> +	};
>> +};
>> +
>> +&uart3 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_uart3>;
>> +	uart-has-rtscts;
>> +	status = "disabled";
>> +};
>> +
>> +&usbh1 {
>> +	status = "disabled";
>> +};
>> +
>> +&usbotg {
>> +	vbus-supply = <&reg_usb_otg_vbus>;
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_usbotg>;
>> +	disable-over-current;
>> +	status = "disabled";
>> +};
>> +
>> +&usdhc1 {
>> +	pinctrl-names = "default", "state_100mhz", "state_200mhz";
>> +	pinctrl-0 = <&pinctrl_usdhc1>;
>> +	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
>> +	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
>> +	bus-width = <4>;
>> +	vmmc-supply = <&reg_wl18xx_vmmc>;
>> +	non-removable;
>> +	wakeup-source;
>> +	keep-power-in-suspend;
>> +	cap-power-off-card;
>> +	#address-cells = <1>;
>> +	#size-cells = <0>;
>> +	status = "okay";
>> +
>> +	wlcore: wlcore@2 {
>> +		compatible = "ti,wl1835";
>> +		reg = <2>;
>> +		interrupt-parent = <&gpio6>;
>> +		interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
>> +		ref-clock-frequency = <38400000>;
>> +	};
>> +};
>> +
>> +&usdhc2 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_usdhc2>;
>> +	no-1-8-v;
>> +	keep-power-in-suspend;
>> +	wakeup-source;
>> +	status = "disabled";
>> +};
>> +
>> +&usdhc3 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_usdhc3>;
>> +	non-removable;
>> +	keep-power-in-suspend;
>> +	wakeup-source;
>> +	status = "okay";
>> +};
>> +
>> +&ssi2 {
>> +	status = "okay";
>> +};
>> +
>> +&snvs_poweroff {
>> +	status = "okay";
>> +};
> 
> The last two nodes break the alphabetical order.

Fixed

> 
> Shawn
>> -- 
>> 2.7.4
>>

Re: [PATCH v4 5/6] ARM: dts: imx6q: Add Variscite DART-MX6 Carrier-board support

[Neil Armstrong]

Hi Shawn,

On 30/11/2017 01:43, Shawn Guo wrote:
> On Wed, Nov 29, 2017 at 11:20:56AM +0100, Neil Armstrong wrote:
>> This patch adds support for the i.MX6 Quad variant of the Variscite DART-MX6
>> SoM Carrier-Board.
>>
>> This Carrier-Board has the following :
>> - LVDS interface for the VLCD-CAP-GLD-LVDS 7" LCD 800 x 480 touch display
>> - HDMI Connector
>> - USB Host + USB OTG Connector
>> - 10/100/1000 Mbps Ethernet
>> - miniPCI-Express slot
>> - SD Card connector
>> - Audio Headphone/Line In jack connectors
>> - On-board DMIC
>> - CAN bus header
>> - SPI header
>> - Camera Interfaces header
>> - 4xButtons, 2xLeds
>> - OnBoard RTC with Coin Backup battery socket
>> - RS232 Header + USB-Serial debug port
>>
>> Product Page : http://www.variscite.com/products/evaluation-kits/dart-mx6-kits
>>
>> The board support is done with all on-board and header interfaces enabled.
>> 7" LVDS Touchscreen is enabled by default along HDMI output.
>> Audio interface is supported with the "simple-card" bindings.
>>
>> PCIe slot, On-Board DMIC and Camera Interfaces are not handled yet.
>>
>> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  arch/arm/boot/dts/Makefile                     |   1 +
>>  arch/arm/boot/dts/imx6q-var-dt6customboard.dts | 239 +++++++++++++++++++++++++
>>  2 files changed, 240 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/imx6q-var-dt6customboard.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index d0381e9..148ff15 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -470,6 +470,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>>  	imx6q-tx6q-11x0-mb7.dtb \
>>  	imx6q-udoo.dtb \
>>  	imx6q-utilite-pro.dtb \
>> +	imx6q-var-dt6customboard.dtb \
>>  	imx6q-wandboard.dtb \
>>  	imx6q-wandboard-revb1.dtb \
>>  	imx6q-wandboard-revd1.dtb \
>> diff --git a/arch/arm/boot/dts/imx6q-var-dt6customboard.dts b/arch/arm/boot/dts/imx6q-var-dt6customboard.dts
>> new file mode 100644
>> index 0000000..76faaff
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx6q-var-dt6customboard.dts
>> @@ -0,0 +1,239 @@
>> +/*
>> + * Support for Variscite DART-MX6 Carrier-board
>> + *
>> + * Copyright 2017 BayLibre, SAS
>> + * Author: Neil Armstrong <narmstrong@baylibre.com>
>> + *
>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "imx6q.dtsi"
>> +#include "imx6qdl-var-dart.dtsi"
>> +#include <dt-bindings/input/linux-event-codes.h>
>> +
>> +/ {
>> +	model = "Variscite DART-MX6 Carrier-board";
>> +	compatible = "variscite,dt6customboard", "fsl,imx6q";
>> +
>> +	backlight_lvds: backlight {
>> +		compatible = "pwm-backlight";
>> +		pwms = <&pwm2 0 50000>;
>> +		brightness-levels = <0 4 8 16 32 64 128 248>;
>> +		default-brightness-level = <7>;
>> +		status = "okay";
>> +	};
>> +
>> +	gpio-keys {
>> +		compatible = "gpio-keys";
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +		autorepeat;
>> +
>> +		back {
>> +			gpios = <&gpio4 26 GPIO_ACTIVE_LOW>;
>> +			linux,code = <KEY_BACK>;
>> +			label = "Key Back";
>> +			linux,input-type = <1>;
>> +			debounce-interval = <100>;
>> +			gpio-key,wakeup;
> 
> The gpio-key,wakeup is legacy one.  Use wakeup-source instead.

Fixed

> 
>> +		};
>> +
>> +		home {
>> +			gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;
>> +			linux,code = <KEY_HOME>;
>> +			label = "Key Home";
>> +			linux,input-type = <1>;
>> +			debounce-interval = <100>;
>> +			gpio-key,wakeup;
>> +		};
>> +
>> +		menu {
>> +			gpios = <&gpio4 25 GPIO_ACTIVE_LOW>;
>> +			linux,code = <KEY_MENU>;
>> +			label = "Key Menu";
>> +			linux,input-type = <1>;
>> +			debounce-interval = <100>;
>> +			gpio-key,wakeup;
>> +		};
>> +	};
>> +
>> +	gpio-leds {
>> +		compatible = "gpio-leds";
>> +
>> +		led1 {
>> +			gpios = <&gpio4 27 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "heartbeat";
>> +		};
>> +
>> +		led2 {
>> +			gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "default-on";
>> +		};
>> +	};
>> +
>> +	panel1: lvds-panel {
>> +		compatible = "sgd,gktw70sdae4se", "panel-lvds";
>> +		backlight = <&backlight_lvds>;
>> +
>> +		width-mm = <153>;
>> +		height-mm = <86>;
>> +
>> +		label = "gktw70sdae4se";
>> +
> 
> Nit: these lines in middle of property list is not really necessary.
> Can we drop them?

Dropped

Thanks,
Neil

> 
> Shawn
> 
>> +		data-mapping = "jeida-18";
>> +
>> +		panel-timing {
>> +			clock-frequency = <32000000>;
>> +			hactive = <800>;
>> +			vactive = <480>;
>> +			hback-porch = <39>;
>> +			hfront-porch = <39>;
>> +			vback-porch = <29>;
>> +			vfront-porch = <13>;
>> +			hsync-len = <47>;
>> +			vsync-len = <2>;
>> +		};
>> +
>> +		port {
>> +			panel_in: endpoint {
>> +				remote-endpoint = <&lvds1_out>;
>> +			};
>> +		};
>> +	};
>> +
>> +	reg_usb_h1_vbus: regulator-usbh1vbus {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "usb_h1_vbus";
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-max-microvolt = <5000000>;
>> +		gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> +		enable-active-high;
>> +	};
>> +
>> +	reg_usb_otg_vbus: regulator-usbotgvbus {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "usb_otg_vbus";
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-max-microvolt = <5000000>;
>> +		gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;
>> +		enable-active-high;
>> +	};
>> +
>> +	sound {
>> +		compatible = "simple-audio-card";
>> +		simple-audio-card,name = "dt6-customboard-audio";
>> +		simple-audio-card,format = "i2s";
>> +		simple-audio-card,bitclock-master = <&sound_codec>;
>> +		simple-audio-card,frame-master = <&sound_codec>;
>> +		simple-audio-card,widgets = "Headphone", "Headphone Jack",
>> +					    "Line", "Line In";
>> +		simple-audio-card,routing = "Headphone Jack", "HPLOUT",
>> +					    "Headphone Jack", "HPROUT",
>> +					    "LINE1L", "Line In",
>> +					    "LINE1R", "Line In";
>> +
>> +		sound_cpu: simple-audio-card,cpu {
>> +			sound-dai = <&ssi2>;
>> +		};
>> +
>> +		sound_codec: simple-audio-card,codec {
>> +			sound-dai = <&codec>;

Changed with <&tlv320aic3106> here.

>> +			clocks = <&clks IMX6QDL_CLK_CKO>;
>> +		};
>> +	};
>> +};
>> +
>> +&can1 {
>> +	status = "okay";
>> +};
>> +
>> +&ecspi1 {
>> +	cs-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>,
>> +		   <&gpio4 10 GPIO_ACTIVE_HIGH>;
>> +	status = "okay";
>> +};
>> +
>> +&fec {
>> +	status = "okay";
>> +	phy-mode = "rgmii";
>> +	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
>> +};
>> +
>> +&hdmi {
>> +	status = "okay";
>> +};
>> +
>> +&i2c1 {
>> +	clock-frequency = <100000>;
>> +	status = "okay";
>> +};
>> +
>> +&i2c3 {
>> +	clock-frequency = <100000>;
>> +	status = "okay";
>> +
>> +	touchscreen@38 {
>> +		compatible = "edt,edt-ft5x06";
>> +		reg = <0x38>;
>> +		interrupt-parent = <&gpio1>;
>> +		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
>> +		touchscreen-size-x = <800>;
>> +		touchscreen-size-y = <480>;
>> +		touchscreen-inverted-x;
>> +		touchscreen-inverted-y;
>> +	};
>> +
>> +	rtc@68 {
>> +		compatible = "isil,isl12057";
>> +		reg = <0x68>;
>> +	};
>> +};
>> +
>> +&ldb {
>> +	status = "okay";
>> +
>> +	lvds-channel@1 {
>> +		status = "okay";
>> +
>> +		port@4 {
>> +			reg = <4>;
>> +
>> +			lvds1_out: endpoint {
>> +				remote-endpoint = <&panel_in>;
>> +			};
>> +		};
>> +	};
>> +};
>> +
>> +&pwm2 {
>> +	status = "okay";
>> +};
>> +
>> +&uart1 {
>> +	status = "okay";
>> +};
>> +
>> +&uart3 {
>> +	status = "okay";
>> +};
>> +
>> +&usbh1 {
>> +	vbus-supply = <&reg_usb_h1_vbus>;
>> +	status = "okay";
>> +};
>> +
>> +&usbotg {
>> +	vbus-supply = <&reg_usb_otg_vbus>;
>> +	dr_mode = "otg";
>> +	srp-disable;
>> +	hnp-disable;
>> +	adp-disable;
>> +	status = "okay";
>> +};
>> +
>> +&usdhc2 {
>> +	cd-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
>> +	status = "okay";
>> +};
>> -- 
>> 2.7.4
>>

Re: [PATCH v4 6/6] ARM: configs: Add missing config for DART-MX6 SoM

[Neil Armstrong]

Hi Shawn,

On 30/11/2017 01:46, Shawn Guo wrote:
> On Wed, Nov 29, 2017 at 11:20:57AM +0100, Neil Armstrong wrote:
>> This patch adds the missing configs for the DART-MX6 SoM support :
>> - SERDEV bluetooth driver + SERIAL_DEV_BUS configs
>> - WL18XX driver
>> - DEFAULT_ON Led Trigger
>>
>> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> 
> 'ARM: imx_v6_v7_defconfig: ...' or 'ARM: imx: defconfig: ...' please.
> 

Ok done.

Thanks for the review,

Neil

> Shawn
> 
>> ---
>>  arch/arm/configs/imx_v6_v7_defconfig | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
>> index 0d44949..abd06c3 100644
>> --- a/arch/arm/configs/imx_v6_v7_defconfig
>> +++ b/arch/arm/configs/imx_v6_v7_defconfig
>> @@ -80,6 +80,7 @@ CONFIG_CAN=y
>>  CONFIG_CAN_FLEXCAN=y
>>  CONFIG_BT=y
>>  CONFIG_BT_HCIUART=y
>> +CONFIG_BT_HCIUART_SERDEV=y
>>  CONFIG_BT_HCIUART_H4=y
>>  CONFIG_BT_HCIUART_LL=y
>>  CONFIG_CFG80211=y
>> @@ -155,6 +156,7 @@ CONFIG_USB_USBNET=y
>>  CONFIG_USB_NET_CDC_EEM=m
>>  CONFIG_BRCMFMAC=m
>>  CONFIG_WL12XX=m
>> +CONFIG_WL18XX=m
>>  CONFIG_WLCORE_SDIO=m
>>  # CONFIG_WILINK_PLATFORM_DATA is not set
>>  CONFIG_INPUT_EVDEV=y
>> @@ -185,6 +187,8 @@ CONFIG_SERIAL_IMX=y
>>  CONFIG_SERIAL_IMX_CONSOLE=y
>>  CONFIG_SERIAL_FSL_LPUART=y
>>  CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
>> +CONFIG_SERIAL_DEV_BUS=y
>> +CONFIG_SERIAL_DEV_CTRL_TTYPORT=y
>>  # CONFIG_I2C_COMPAT is not set
>>  CONFIG_I2C_CHARDEV=y
>>  CONFIG_I2C_MUX=y
>> @@ -248,6 +252,7 @@ CONFIG_VIDEO_OV5640=m
>>  CONFIG_SOC_CAMERA_OV2640=y
>>  CONFIG_IMX_IPUV3_CORE=y
>>  CONFIG_DRM=y
>> +CONFIG_DRM_PANEL_LVDS=y
>>  CONFIG_DRM_PANEL_SIMPLE=y
>>  CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
>>  CONFIG_DRM_DW_HDMI_CEC=y
>> @@ -340,6 +345,7 @@ CONFIG_LEDS_TRIGGER_ONESHOT=y
>>  CONFIG_LEDS_TRIGGER_HEARTBEAT=y
>>  CONFIG_LEDS_TRIGGER_BACKLIGHT=y
>>  CONFIG_LEDS_TRIGGER_GPIO=y
>> +CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
>>  CONFIG_RTC_CLASS=y
>>  CONFIG_RTC_INTF_DEV_UIE_EMUL=y
>>  CONFIG_RTC_DRV_DS1307=y
>> -- 
>> 2.7.4
>>

Re: [PATCH v4 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support

[Philippe Ombredanne]

On Fri, Dec 1, 2017 at 9:54 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
> On 30/11/2017 01:39, Shawn Guo wrote:
>> On Wed, Nov 29, 2017 at 11:20:55AM +0100, Neil Armstrong wrote:
>>> This patch adds support for the Variscite DART-MX6 SoM with :
>>> - i.MX6 Quad or Dual Lite SoC
>>> - 1Gb/2Gb LPDDR2
>>> - 4-64 GB eMMC
>>> - Camera Interface
>>> - HDMI+CEC interface
>>> - LVDS / DSI / Parallel RGB interfaces
>>> - Ethernet RGMII interface
>>> - On-SoM Wi-Fi/Bluetooth with WiLink wl1835 SDIO Module
>>> - SD/MMC/SDIO interface
>>> - USB Host + USB OTG interface
>>> - I2C interfaces
>>> - SPI interfaces
>>> - PCI-Express 2.0 interface
>>> - on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface
>>> - Digital Audio interface
>>> - S/PDIF interface
>>>
>>> Product website : http://www.variscite.com/products/system-on-module-som/cortex-a9/dart-mx6-cpu-freescale-imx6
>>>
>>> Support is handled with a SoM-centric dtsi exporting the default interfaces
>>> along the default pinmuxing to be enabled by the board dts file.
>>>
>>> Only board-independent devices like WiFi, eMMC or PMIC are enabled in the dtsi.
>>>
>>> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>
>> Looks pretty good.  Only a couple of minor comments.
>>
>>> ---
>>>  arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 504 ++++++++++++++++++++++++++++++++
>>>  1 file changed, 504 insertions(+)
>>>  create mode 100644 arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>
>>> diff --git a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>> new file mode 100644
>>> index 0000000..fd2520b
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>> @@ -0,0 +1,504 @@
>>> +/*
>>> + * Support for Variscite DART-MX6 Module
>>> + *
>>> + * Copyright 2017 BayLibre, SAS
>>> + * Author: Neil Armstrong <narmstrong@baylibre.com>
>>> + *
>>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>> + */

Should this be instead on the first line with a // comment style if
possible, right?

>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)

Thomas has sent a first doc patch [1] set and is working on an updated
version.  Jonathan also wrote a nice background article on the topic
at LWN [2].

Linus explained why he wants the // comment style and a first line
location on the list too.

[1] https://marc.info/?l=linux-kernel&m=151051532322831&w=2
[2] https://lwn.net/SubscriberLink/739183/262749cbe307ddc7/

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v4 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support

[Neil Armstrong]

Hi Philippe,

On 01/12/2017 10:02, Philippe Ombredanne wrote:
> On Fri, Dec 1, 2017 at 9:54 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> On 30/11/2017 01:39, Shawn Guo wrote:
>>> On Wed, Nov 29, 2017 at 11:20:55AM +0100, Neil Armstrong wrote:
>>>> This patch adds support for the Variscite DART-MX6 SoM with :
>>>> - i.MX6 Quad or Dual Lite SoC
>>>> - 1Gb/2Gb LPDDR2
>>>> - 4-64 GB eMMC
>>>> - Camera Interface
>>>> - HDMI+CEC interface
>>>> - LVDS / DSI / Parallel RGB interfaces
>>>> - Ethernet RGMII interface
>>>> - On-SoM Wi-Fi/Bluetooth with WiLink wl1835 SDIO Module
>>>> - SD/MMC/SDIO interface
>>>> - USB Host + USB OTG interface
>>>> - I2C interfaces
>>>> - SPI interfaces
>>>> - PCI-Express 2.0 interface
>>>> - on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface
>>>> - Digital Audio interface
>>>> - S/PDIF interface
>>>>
>>>> Product website : http://www.variscite.com/products/system-on-module-som/cortex-a9/dart-mx6-cpu-freescale-imx6
>>>>
>>>> Support is handled with a SoM-centric dtsi exporting the default interfaces
>>>> along the default pinmuxing to be enabled by the board dts file.
>>>>
>>>> Only board-independent devices like WiFi, eMMC or PMIC are enabled in the dtsi.
>>>>
>>>> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>
>>> Looks pretty good.  Only a couple of minor comments.
>>>
>>>> ---
>>>>  arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 504 ++++++++++++++++++++++++++++++++
>>>>  1 file changed, 504 insertions(+)
>>>>  create mode 100644 arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>>
>>>> diff --git a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>> new file mode 100644
>>>> index 0000000..fd2520b
>>>> --- /dev/null
>>>> +++ b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>> @@ -0,0 +1,504 @@
>>>> +/*
>>>> + * Support for Variscite DART-MX6 Module
>>>> + *
>>>> + * Copyright 2017 BayLibre, SAS
>>>> + * Author: Neil Armstrong <narmstrong@baylibre.com>
>>>> + *
>>>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>>> + */
> 
> Should this be instead on the first line with a // comment style if
> possible, right?

I just saw this right now.

Damn, I just sent a v5...

> 
>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> 
> Thomas has sent a first doc patch [1] set and is working on an updated
> version.  Jonathan also wrote a nice background article on the topic
> at LWN [2].
> 
> Linus explained why he wants the // comment style and a first line
> location on the list too.
> 
> [1] https://marc.info/?l=linux-kernel&m=151051532322831&w=2
> [2] https://lwn.net/SubscriberLink/739183/262749cbe307ddc7/
> 

Neil

Re: [PATCH v4 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support

[Philippe Ombredanne]

Neil,

On Fri, Dec 1, 2017 at 10:19 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
> Hi Philippe,
>
> On 01/12/2017 10:02, Philippe Ombredanne wrote:
>> On Fri, Dec 1, 2017 at 9:54 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>> On 30/11/2017 01:39, Shawn Guo wrote:
>>>> On Wed, Nov 29, 2017 at 11:20:55AM +0100, Neil Armstrong wrote:
>>>>> This patch adds support for the Variscite DART-MX6 SoM with :
>>>>> - i.MX6 Quad or Dual Lite SoC
>>>>> - 1Gb/2Gb LPDDR2
>>>>> - 4-64 GB eMMC
>>>>> - Camera Interface
>>>>> - HDMI+CEC interface
>>>>> - LVDS / DSI / Parallel RGB interfaces
>>>>> - Ethernet RGMII interface
>>>>> - On-SoM Wi-Fi/Bluetooth with WiLink wl1835 SDIO Module
>>>>> - SD/MMC/SDIO interface
>>>>> - USB Host + USB OTG interface
>>>>> - I2C interfaces
>>>>> - SPI interfaces
>>>>> - PCI-Express 2.0 interface
>>>>> - on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface
>>>>> - Digital Audio interface
>>>>> - S/PDIF interface
>>>>>
>>>>> Product website : http://www.variscite.com/products/system-on-module-som/cortex-a9/dart-mx6-cpu-freescale-imx6
>>>>>
>>>>> Support is handled with a SoM-centric dtsi exporting the default interfaces
>>>>> along the default pinmuxing to be enabled by the board dts file.
>>>>>
>>>>> Only board-independent devices like WiFi, eMMC or PMIC are enabled in the dtsi.
>>>>>
>>>>> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>
>>>> Looks pretty good.  Only a couple of minor comments.
>>>>
>>>>> ---
>>>>>  arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 504 ++++++++++++++++++++++++++++++++
>>>>>  1 file changed, 504 insertions(+)
>>>>>  create mode 100644 arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>>> new file mode 100644
>>>>> index 0000000..fd2520b
>>>>> --- /dev/null
>>>>> +++ b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>>> @@ -0,0 +1,504 @@
>>>>> +/*
>>>>> + * Support for Variscite DART-MX6 Module
>>>>> + *
>>>>> + * Copyright 2017 BayLibre, SAS
>>>>> + * Author: Neil Armstrong <narmstrong@baylibre.com>
>>>>> + *
>>>>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>>>> + */
>>
>> Should this be instead on the first line with a // comment style if
>> possible, right?
>
> I just saw this right now.
>
> Damn, I just sent a v5...
>
>>
>>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>
>> Thomas has sent a first doc patch [1] set and is working on an updated
>> version.  Jonathan also wrote a nice background article on the topic
>> at LWN [2].
>>
>> Linus explained why he wants the // comment style and a first line
>> location on the list too.
>>
>> [1] https://marc.info/?l=linux-kernel&m=151051532322831&w=2
>> [2] https://lwn.net/SubscriberLink/739183/262749cbe307ddc7/
>>

Sorry for wrecking your workflow with a smallish comment related
comment and I am grateful that you consider this.

Thomas (tglx) is working on updated doc patches as soon as his real
time clock yields a few ticks for doc work...
The point is that Greg pushed already 10K+ file updates with proper
SPDX ids.... I chipped in a bit there and there are still eventually
60k+ files to go to have a uniform and simplified licensing
kernel-wide.

So, every little bit to help avoiding drift and regress is helpful.
Linus request for using // is to make this unambiguously greppable.

The selfish benefit to me is that  eventually I will be able to send
to the trash my license scanner in the future [1] (we use it to help
cleanup the kernel FWIW) and replace this with a good' ole grep once
everyone on earth use clean and greppable licensing... The kernel is
setting the pace there for the whole FLOSS world and I hope this will
snow ball, but hope is not a strategy! Once the kernel is done, I will
have only more or less 100 billion+ file left to clean after that ;)

[1] https://github.com/nexB/scancode-toolkit

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v4 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support

[Neil Armstrong]

On 01/12/2017 10:40, Philippe Ombredanne wrote:
> Neil,
> 
> On Fri, Dec 1, 2017 at 10:19 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> Hi Philippe,
>>
>> On 01/12/2017 10:02, Philippe Ombredanne wrote:
>>> On Fri, Dec 1, 2017 at 9:54 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>>> On 30/11/2017 01:39, Shawn Guo wrote:
>>>>> On Wed, Nov 29, 2017 at 11:20:55AM +0100, Neil Armstrong wrote:
>>>>>> This patch adds support for the Variscite DART-MX6 SoM with :
>>>>>> - i.MX6 Quad or Dual Lite SoC
>>>>>> - 1Gb/2Gb LPDDR2
>>>>>> - 4-64 GB eMMC
>>>>>> - Camera Interface
>>>>>> - HDMI+CEC interface
>>>>>> - LVDS / DSI / Parallel RGB interfaces
>>>>>> - Ethernet RGMII interface
>>>>>> - On-SoM Wi-Fi/Bluetooth with WiLink wl1835 SDIO Module
>>>>>> - SD/MMC/SDIO interface
>>>>>> - USB Host + USB OTG interface
>>>>>> - I2C interfaces
>>>>>> - SPI interfaces
>>>>>> - PCI-Express 2.0 interface
>>>>>> - on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface
>>>>>> - Digital Audio interface
>>>>>> - S/PDIF interface
>>>>>>
>>>>>> Product website : http://www.variscite.com/products/system-on-module-som/cortex-a9/dart-mx6-cpu-freescale-imx6
>>>>>>
>>>>>> Support is handled with a SoM-centric dtsi exporting the default interfaces
>>>>>> along the default pinmuxing to be enabled by the board dts file.
>>>>>>
>>>>>> Only board-independent devices like WiFi, eMMC or PMIC are enabled in the dtsi.
>>>>>>
>>>>>> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
>>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>>
>>>>> Looks pretty good.  Only a couple of minor comments.
>>>>>
>>>>>> ---
>>>>>>  arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 504 ++++++++++++++++++++++++++++++++
>>>>>>  1 file changed, 504 insertions(+)
>>>>>>  create mode 100644 arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/imx6qdl-var-dart.dtsi b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>>>> new file mode 100644
>>>>>> index 0000000..fd2520b
>>>>>> --- /dev/null
>>>>>> +++ b/arch/arm/boot/dts/imx6qdl-var-dart.dtsi
>>>>>> @@ -0,0 +1,504 @@
>>>>>> +/*
>>>>>> + * Support for Variscite DART-MX6 Module
>>>>>> + *
>>>>>> + * Copyright 2017 BayLibre, SAS
>>>>>> + * Author: Neil Armstrong <narmstrong@baylibre.com>
>>>>>> + *
>>>>>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>>>>> + */
>>>
>>> Should this be instead on the first line with a // comment style if
>>> possible, right?
>>
>> I just saw this right now.
>>
>> Damn, I just sent a v5...
>>
>>>
>>>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>>
>>> Thomas has sent a first doc patch [1] set and is working on an updated
>>> version.  Jonathan also wrote a nice background article on the topic
>>> at LWN [2].
>>>
>>> Linus explained why he wants the // comment style and a first line
>>> location on the list too.
>>>
>>> [1] https://marc.info/?l=linux-kernel&m=151051532322831&w=2
>>> [2] https://lwn.net/SubscriberLink/739183/262749cbe307ddc7/
>>>
> 
> Sorry for wrecking your workflow with a smallish comment related
> comment and I am grateful that you consider this.

No problem, I understand your PoV even if the // comment is still dumb
to use in /* */ only commented files.

> 
> Thomas (tglx) is working on updated doc patches as soon as his real
> time clock yields a few ticks for doc work...
> The point is that Greg pushed already 10K+ file updates with proper
> SPDX ids.... I chipped in a bit there and there are still eventually
> 60k+ files to go to have a uniform and simplified licensing
> kernel-wide.

No problem, but maybe it would be time to actually tell all the maintainers
about this new policy, so we can start applying it.

> 
> So, every little bit to help avoiding drift and regress is helpful.
> Linus request for using // is to make this unambiguously greppable.

Well the "SPDX-Licence-Identifier: (.*)$" seems pretty greppable for
me... anyway we will comply.

> 
> The selfish benefit to me is that  eventually I will be able to send
> to the trash my license scanner in the future [1] (we use it to help
> cleanup the kernel FWIW) and replace this with a good' ole grep once
> everyone on earth use clean and greppable licensing... The kernel is
> setting the pace there for the whole FLOSS world and I hope this will
> snow ball, but hope is not a strategy! Once the kernel is done, I will
> have only more or less 100 billion+ file left to clean after that ;)
> 
> [1] https://github.com/nexB/scancode-toolkit
> 

Neil