* [PATCH 0/3] Misc fixes up for MT7623 mmc
@ 2017-11-29 10:10 sean.wang
2017-11-29 10:10 ` [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC sean.wang
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: sean.wang @ 2017-11-29 10:10 UTC (permalink / raw)
To: robh+dt, matthias.bgg, mark.rutland, devicetree, linux-mediatek
Cc: linux-arm-kernel, linux-kernel, Sean Wang
From: Sean Wang <sean.wang@mediatek.com>
Just add some fixes up for the current MT7623 support
Patch 1) complement the missing dt-bindings definitions
Patch 2) pick up the proper falling back as patch 1 defines.
Patch 3) SD-card detection issue caused by the wrong polarity is being fixed up
Sean Wang (3):
mmc: dt-bindings: add mmc support to MT7623 SoC
arm: dts: mt7623: update mmc related nodes with the appropriate
fallback
arm: dts: mt7623: fix card detection issue on bananapi-r2
Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++
arch/arm/boot/dts/mt7623.dtsi | 4 ++--
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC 2017-11-29 10:10 [PATCH 0/3] Misc fixes up for MT7623 mmc sean.wang @ 2017-11-29 10:10 ` sean.wang 2017-12-01 2:06 ` Rob Herring 2017-11-29 10:10 ` [PATCH 2/3] arm: dts: mt7623: update mmc related nodes with the appropriate fallback sean.wang 2017-11-29 10:10 ` [PATCH 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 sean.wang 2 siblings, 1 reply; 7+ messages in thread From: sean.wang @ 2017-11-29 10:10 UTC (permalink / raw) To: robh+dt, matthias.bgg, mark.rutland, devicetree, linux-mediatek Cc: linux-arm-kernel, linux-kernel, Sean Wang From: Sean Wang <sean.wang@mediatek.com> Add the devicetree binding for MT7623 SoC using MT2701 as the fallback. Cc: devicetree@vger.kernel.org Signed-off-by: Sean Wang <sean.wang@mediatek.com> --- Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt index 72d2a73..1732588 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt @@ -12,6 +12,8 @@ Required properties: "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 + "mediatek,mt7623-mmc", + "mediatek,mt2701-mmc": for mmc host ip compatible with mt7623 - reg: physical base address of the controller and length - interrupts: Should contain MSDC interrupt number - clocks: Should contain phandle for the clock feeding the MMC controller -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC 2017-11-29 10:10 ` [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC sean.wang @ 2017-12-01 2:06 ` Rob Herring 2017-12-01 2:23 ` Sean Wang 0 siblings, 1 reply; 7+ messages in thread From: Rob Herring @ 2017-12-01 2:06 UTC (permalink / raw) To: sean.wang Cc: matthias.bgg, mark.rutland, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel On Wed, Nov 29, 2017 at 06:10:35PM +0800, sean.wang@mediatek.com wrote: > From: Sean Wang <sean.wang@mediatek.com> > > Add the devicetree binding for MT7623 SoC using MT2701 as the fallback. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 72d2a73..1732588 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -12,6 +12,8 @@ Required properties: > "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > + "mediatek,mt7623-mmc", > + "mediatek,mt2701-mmc": for mmc host ip compatible with mt7623 Those should be on 1 line ideally. BTW, I find "for mmc host ip compatible with mt7623" to be mostly redundant. Either way, Acked-by: Rob Herring <robh@kernel.org> > - reg: physical base address of the controller and length > - interrupts: Should contain MSDC interrupt number > - clocks: Should contain phandle for the clock feeding the MMC controller > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC 2017-12-01 2:06 ` Rob Herring @ 2017-12-01 2:23 ` Sean Wang 0 siblings, 0 replies; 7+ messages in thread From: Sean Wang @ 2017-12-01 2:23 UTC (permalink / raw) To: Rob Herring Cc: matthias.bgg, mark.rutland, devicetree, linux-mediatek, linux-arm-kernel, linux-kernel On Thu, 2017-11-30 at 20:06 -0600, Rob Herring wrote: > On Wed, Nov 29, 2017 at 06:10:35PM +0800, sean.wang@mediatek.com wrote: > > From: Sean Wang <sean.wang@mediatek.com> > > > > Add the devicetree binding for MT7623 SoC using MT2701 as the fallback. > > > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > index 72d2a73..1732588 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > > @@ -12,6 +12,8 @@ Required properties: > > "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 > > "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701 > > "mediatek,mt2712-mmc": for mmc host ip compatible with mt2712 > > + "mediatek,mt7623-mmc", > > + "mediatek,mt2701-mmc": for mmc host ip compatible with mt7623 > > Those should be on 1 line ideally. > > BTW, I find "for mmc host ip compatible with mt7623" to be mostly > redundant. > Either way, > > Acked-by: Rob Herring <robh@kernel.org> > > okay, thanks for your careful guide These will be fixed with "mediatek,mt7623-mmc", "mediatek,mt2701-mmc": for MT7623 SoC in the next version Sean > > - reg: physical base address of the controller and length > > - interrupts: Should contain MSDC interrupt number > > - clocks: Should contain phandle for the clock feeding the MMC controller > > -- > > 2.7.4 > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] arm: dts: mt7623: update mmc related nodes with the appropriate fallback 2017-11-29 10:10 [PATCH 0/3] Misc fixes up for MT7623 mmc sean.wang 2017-11-29 10:10 ` [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC sean.wang @ 2017-11-29 10:10 ` sean.wang 2017-11-29 10:10 ` [PATCH 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 sean.wang 2 siblings, 0 replies; 7+ messages in thread From: sean.wang @ 2017-11-29 10:10 UTC (permalink / raw) To: robh+dt, matthias.bgg, mark.rutland, devicetree, linux-mediatek Cc: linux-arm-kernel, linux-kernel, Sean Wang From: Sean Wang <sean.wang@mediatek.com> The current mmc related nodes should be falling back to MT2701 as the dt-binding defines and which has more appropriate setup for MT7623. Signed-off-by: Sean Wang <sean.wang@mediatek.com> --- arch/arm/boot/dts/mt7623.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi index 0640fb7..343d3b1 100644 --- a/arch/arm/boot/dts/mt7623.dtsi +++ b/arch/arm/boot/dts/mt7623.dtsi @@ -641,7 +641,7 @@ mmc0: mmc@11230000 { compatible = "mediatek,mt7623-mmc", - "mediatek,mt8135-mmc"; + "mediatek,mt2701-mmc"; reg = <0 0x11230000 0 0x1000>; interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_LOW>; clocks = <&pericfg CLK_PERI_MSDC30_0>, @@ -652,7 +652,7 @@ mmc1: mmc@11240000 { compatible = "mediatek,mt7623-mmc", - "mediatek,mt8135-mmc"; + "mediatek,mt2701-mmc"; reg = <0 0x11240000 0 0x1000>; interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_LOW>; clocks = <&pericfg CLK_PERI_MSDC30_1>, -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 2017-11-29 10:10 [PATCH 0/3] Misc fixes up for MT7623 mmc sean.wang 2017-11-29 10:10 ` [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC sean.wang 2017-11-29 10:10 ` [PATCH 2/3] arm: dts: mt7623: update mmc related nodes with the appropriate fallback sean.wang @ 2017-11-29 10:10 ` sean.wang 2017-12-01 11:42 ` Matthias Brugger 2 siblings, 1 reply; 7+ messages in thread From: sean.wang @ 2017-11-29 10:10 UTC (permalink / raw) To: robh+dt, matthias.bgg, mark.rutland, devicetree, linux-mediatek Cc: linux-arm-kernel, linux-kernel, Sean Wang From: Sean Wang <sean.wang@mediatek.com> Fix that bananapi-r2 booting from SD-card would fail since incorrect polarity is applied to the previous setup with GPIO_ACTIVE_HIGH. Cc: stable@vger.kernel.org # v4.14+ Fixes: 0eed8d097612 ("arm: dts: mt7623: Add SD-card and EMMC to bananapi-r2") Signed-off-by: Sean Wang <sean.wang@mediatek.com> --- arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts index 688a863..7bf5aa2 100644 --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts @@ -204,7 +204,7 @@ bus-width = <4>; max-frequency = <50000000>; cap-sd-highspeed; - cd-gpios = <&pio 261 0>; + cd-gpios = <&pio 261 GPIO_ACTIVE_LOW>; vmmc-supply = <&mt6323_vmch_reg>; vqmmc-supply = <&mt6323_vio18_reg>; }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 2017-11-29 10:10 ` [PATCH 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 sean.wang @ 2017-12-01 11:42 ` Matthias Brugger 0 siblings, 0 replies; 7+ messages in thread From: Matthias Brugger @ 2017-12-01 11:42 UTC (permalink / raw) To: sean.wang, robh+dt, mark.rutland, devicetree, linux-mediatek Cc: linux-arm-kernel, linux-kernel On 11/29/2017 11:10 AM, sean.wang@mediatek.com wrote: > From: Sean Wang <sean.wang@mediatek.com> > > Fix that bananapi-r2 booting from SD-card would fail since incorrect > polarity is applied to the previous setup with GPIO_ACTIVE_HIGH. > > Cc: stable@vger.kernel.org # v4.14+ > Fixes: 0eed8d097612 ("arm: dts: mt7623: Add SD-card and EMMC to bananapi-r2") > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > --- Tested-by: Matthias Brugger <matthias.bgg@gmail.com> > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > index 688a863..7bf5aa2 100644 > --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > @@ -204,7 +204,7 @@ > bus-width = <4>; > max-frequency = <50000000>; > cap-sd-highspeed; > - cd-gpios = <&pio 261 0>; > + cd-gpios = <&pio 261 GPIO_ACTIVE_LOW>; > vmmc-supply = <&mt6323_vmch_reg>; > vqmmc-supply = <&mt6323_vio18_reg>; > }; > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-12-01 11:42 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-11-29 10:10 [PATCH 0/3] Misc fixes up for MT7623 mmc sean.wang 2017-11-29 10:10 ` [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC sean.wang 2017-12-01 2:06 ` Rob Herring 2017-12-01 2:23 ` Sean Wang 2017-11-29 10:10 ` [PATCH 2/3] arm: dts: mt7623: update mmc related nodes with the appropriate fallback sean.wang 2017-11-29 10:10 ` [PATCH 3/3] arm: dts: mt7623: fix card detection issue on bananapi-r2 sean.wang 2017-12-01 11:42 ` Matthias Brugger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).