From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Olof Johansson <olof@lixom.net>,
Kevin Hilman <khilman@baylibre.com>,
"Nori, Sekhar" <nsekhar@ti.com>
Subject: Re: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem
Date: Mon, 31 Oct 2016 19:24:46 +0100 [thread overview]
Message-ID: <1512445.DtnT51NQqg@amdc3058> (raw)
In-Reply-To: <2291876.8LAt3RcuXX@amdc3058>
On Monday, October 31, 2016 07:14:13 PM Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Monday, October 31, 2016 03:46:22 PM Russell King - ARM Linux wrote:
> > On Wed, Oct 26, 2016 at 07:01:12PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > >
> > > Hi,
> > >
> > > On Wednesday, July 13, 2016 04:37:31 PM Arnd Bergmann wrote:
> > > > On Wednesday, July 13, 2016 12:59:23 PM CEST Bartlomiej Zolnierkiewicz wrote:
> > > > >
> > > > > On Friday, July 08, 2016 10:23:48 PM Arnd Bergmann wrote:
> > > > > > On Friday, July 8, 2016 5:24:41 PM CEST Bartlomiej Zolnierkiewicz wrote:
> > > > > > > This patch disables deprecated IDE subsystem in assabet_defconfig
> > > > > > > (no IDE host drivers are selected in this config so there is no
> > > > > > > valid reason to enable IDE subsystem itself).
> > > > > > >
> > > > > > > Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> > > > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > > > >
> > > > > > I think the series makes a lot of sense. I have checked your assertions
> > > > > > in the changelogs and found no flaws in your logic, so I think we should
> > > > > > take them all through arm-soc unless there are other concerns.
> > > > >
> > > > > Thank you.
> > > > >
> > > > > Should I resend everything or just patches that were not reposted yet
> > > > > (the ones that were marked as RFT initially and got no feedback)?
> > > >
> > > > I'd be fine with just getting a pull request with all the patches that
> > > > had no negative feedback and that were not already applied (if any).
> > >
> > > Here it is (sorry for taking so long).
> >
> > I've just been digging in the dmesg logs from when I was using the
> > Assabet+Neponset as my firewall, and it was having to use the IDE
> > ide-cs driver rather than the pata pcmcia driver.
> >
> > I don't recall whether the pata pcmcia driver was a problem or not,
> > as the PCMCIA interface can't cope with _any_ 32-bit accesses. I
> > think PATA tries to use the "highest" possible access size by
> > default...
>
> It doesn't actually - it defaults to 16-bits for PIO data access and
> you must explicitly enable 32-bits using ATA_PFLAG_PIO32 port flag
> (pata_pcmcia doesn't set it so it should be okay). Also taskfile
> registers are accessed using 8-bits access by default transport
> functions (which are used by pata_pcmcia).
Please also note that:
- assebet_defconfig currently doesn't even enable ide-cs
(CONFIG_BLK_DEV_IDECS) in the mainline kernel
- neponset_defconfig doesn't even enable IDE (CONFIG_IDE)
in the mainline kernel
so there is no risk of breaking anything.. :-)
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2016-10-31 18:24 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 15:24 [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: badge4_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: cerfcube_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: colibri_pxa270_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-16 9:01 ` Robert Jarzmik
2016-07-08 15:24 ` [RESEND PATCH] arm: lart_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: lpda270_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [PATCH v2] arm: mainstone_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: pxa255-idp_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: shannon_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 15:24 ` [RESEND PATCH] arm: trizeps4_defconfig: " Bartlomiej Zolnierkiewicz
2016-07-08 20:23 ` [RESEND PATCH] arm: assabet_defconfig: " Arnd Bergmann
2016-07-13 10:59 ` Bartlomiej Zolnierkiewicz
2016-07-13 14:37 ` Arnd Bergmann
2016-07-13 17:45 ` Russell King - ARM Linux
2016-07-14 9:59 ` Bartlomiej Zolnierkiewicz
2016-07-15 15:15 ` Kevin Hilman
2016-07-18 14:45 ` Sekhar Nori
2016-12-12 12:45 ` Bartlomiej Zolnierkiewicz
2016-12-12 13:54 ` Sekhar Nori
2017-03-07 17:51 ` Bartlomiej Zolnierkiewicz
2017-03-08 15:00 ` Sekhar Nori
2017-03-09 8:39 ` Sekhar Nori
2017-03-09 9:25 ` Sergei Shtylyov
2017-03-09 12:20 ` Sekhar Nori
2017-03-09 12:24 ` Sergei Shtylyov
2017-03-09 13:57 ` Russell King - ARM Linux
[not found] ` <CGME20170309144309epcas1p17e601ea2747d5587e4fecf61cc670812@epcas1p1.samsung.com>
2017-03-09 14:42 ` Bartlomiej Zolnierkiewicz
2017-03-09 14:51 ` Russell King - ARM Linux
[not found] ` <CGME20170309145745epcas5p331cf5418a586b8d435a508626cbf7af9@epcas5p3.samsung.com>
2017-03-09 14:57 ` Bartlomiej Zolnierkiewicz
2017-03-09 15:08 ` Russell King - ARM Linux
[not found] ` <CGME20170309154131epcas5p1f9c668855ee33c1634d4491d8664848b@epcas5p1.samsung.com>
2017-03-09 15:41 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20170309145219epcas5p38b1af654dd0a4b04bd02a488051c065f@epcas5p3.samsung.com>
2017-03-09 14:52 ` Bartlomiej Zolnierkiewicz
2017-03-09 16:22 ` Sergei Shtylyov
[not found] ` <CGME20170310171153epcas5p259bf9353fd1194dd131350fc59c3423a@epcas5p2.samsung.com>
2017-03-10 17:11 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20170309122125epcas5p415b1f2266f68d5b999d2eb4ced94e9f3@epcas5p4.samsung.com>
2017-03-09 12:21 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20170309114756epcas5p3761bce85d5a8e3a095cb3a876c484ea6@epcas5p3.samsung.com>
2017-03-09 11:47 ` Bartlomiej Zolnierkiewicz
2017-03-09 11:57 ` Sekhar Nori
[not found] ` <CGME20170309121425epcas1p119ed8e5e27e3f7d8bfc71d0173cd301b@epcas1p1.samsung.com>
2017-03-09 12:14 ` Bartlomiej Zolnierkiewicz
2016-10-26 17:01 ` Bartlomiej Zolnierkiewicz
2016-10-31 15:46 ` Russell King - ARM Linux
2016-10-31 18:14 ` Bartlomiej Zolnierkiewicz
2016-10-31 18:24 ` Bartlomiej Zolnierkiewicz [this message]
2016-11-25 22:22 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512445.DtnT51NQqg@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=arnd@arndb.de \
--cc=dbaryshkov@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nsekhar@ti.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).