From: Joe Perches <joe@perches.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>,
SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-mips@linux-mips.org, "Ralf Bächle" <ralf@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] TC: Delete an error message for a failed memory allocation in tc_bus_add_devices()
Date: Sun, 10 Dec 2017 18:05:31 -0800 [thread overview]
Message-ID: <1512957931.26342.31.camel@perches.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1712102140570.4266@eddie.linux-mips.org>
On Sun, 2017-12-10 at 21:41 +0000, Maciej W. Rozycki wrote:
> On Sun, 10 Dec 2017, SF Markus Elfring wrote:
>
> > Omit an extra message for a memory allocation failure in this function.
> >
> > This issue was detected by using the Coccinelle software.
>
> And the problem here is?
Markus' terrible commit messages.
Generically, any OOM via a malloc like call has a dump_stack()
which shows a stack trace unless __GFP_NOWARN is used.
So this message is generally unnecessary as the dump_stack()
will show the tc_bus_add_devices function name and (now hashed)
value of the function address.
What will be different is the particular slot # of the tc_dev
will no longer be shown.
Really though, if there's an OOM on the init, there are larger
problems and the system will be unusable.
next prev parent reply other threads:[~2017-12-11 2:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-10 17:48 [PATCH] TC: Delete an error message for a failed memory allocation in tc_bus_add_devices() SF Markus Elfring
2017-12-10 21:41 ` Maciej W. Rozycki
2017-12-11 2:05 ` Joe Perches [this message]
2017-12-11 13:17 ` Maciej W. Rozycki
2017-12-11 13:38 ` SF Markus Elfring
2017-12-11 8:15 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512957931.26342.31.camel@perches.com \
--to=joe@perches.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).