From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "Maciej W. Rozycki" <macro@linux-mips.org>, linux-mips@linux-mips.org
Cc: "Joe Perches" <joe@perches.com>,
"Ralf Bächle" <ralf@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] TC: Delete an error message for a failed memory allocation in tc_bus_add_devices()
Date: Mon, 11 Dec 2017 14:38:52 +0100 [thread overview]
Message-ID: <b553c094-238a-663b-a374-a7075feb9f4b@users.sourceforge.net> (raw)
In-Reply-To: <alpine.LFD.2.21.1712110244450.4266@eddie.linux-mips.org>
> However I would indeed prefer that a commit description is at least
> exhaustive enough for such a dumb reviewer as I am to understand what is
> going on right away.
I can follow your desire in principle.
> So please make it say at least:
>
> "Remove an extraneous message that duplicates the diagnostic already
> provided by `kzalloc' for a memory allocation failure in this function."
How much clarification can such a wording bring to the software situation
if the desired data structures might be still unclear for “the diagnostic”?
> or suchlike in v2 for me to apply a Reviewed-by: tag.
Are you interested in a safe description for a default Linux allocation
failure report?
How do you think about corresponding reference documentation
(besides source code)?
Regards,
Markus
next prev parent reply other threads:[~2017-12-11 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-10 17:48 [PATCH] TC: Delete an error message for a failed memory allocation in tc_bus_add_devices() SF Markus Elfring
2017-12-10 21:41 ` Maciej W. Rozycki
2017-12-11 2:05 ` Joe Perches
2017-12-11 13:17 ` Maciej W. Rozycki
2017-12-11 13:38 ` SF Markus Elfring [this message]
2017-12-11 8:15 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b553c094-238a-663b-a374-a7075feb9f4b@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).