[PATCH 1/2] padata: Remove FSF address

[PATCH 1/2] padata: Remove FSF address

[Cheah Kok Cheong]

Remove FSF address otherwise checkpatch will flag my next patch.

Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
---
 kernel/padata.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/kernel/padata.c b/kernel/padata.c
index 57c0074..9d91909 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -14,10 +14,6 @@
  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
 #include <linux/export.h>
-- 
2.7.4

[PATCH 2/2] padata: Remove redundant export.h header

[Cheah Kok Cheong]

It is already included in module.h, see
commit f50169324df4 ("module.h: split out the EXPORT_SYMBOL into export.h")
for their relationship.

Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
---
 kernel/padata.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/padata.c b/kernel/padata.c
index 9d91909..e265953 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -16,7 +16,6 @@
  * more details.
  */
 
-#include <linux/export.h>
 #include <linux/cpumask.h>
 #include <linux/err.h>
 #include <linux/cpu.h>
-- 
2.7.4

Re: [PATCH 1/2] padata: Remove FSF address

[Philippe Ombredanne]

On Wed, Dec 20, 2017 at 9:15 PM, Cheah Kok Cheong <thrust73@gmail.com> wrote:
> Remove FSF address otherwise checkpatch will flag my next patch.
>
> Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
> ---
>  kernel/padata.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/kernel/padata.c b/kernel/padata.c
> index 57c0074..9d91909 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -14,10 +14,6 @@
>   * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
>   * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
>   * more details.
> - *
> - * You should have received a copy of the GNU General Public License along with
> - * this program; if not, write to the Free Software Foundation, Inc.,
> - * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
>   */
>
>  #include <linux/export.h>
> --
> 2.7.4
>


Why not use instead the simpler SPDX ids?
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/2] padata: Remove FSF address

[Cheah Kok Cheong]

On Wed, Dec 20, 2017 at 09:20:48PM +0100, Philippe Ombredanne wrote:
> On Wed, Dec 20, 2017 at 9:15 PM, Cheah Kok Cheong <thrust73@gmail.com> wrote:
> > Remove FSF address otherwise checkpatch will flag my next patch.
> >
> > Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
> > ---
> >  kernel/padata.c | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/kernel/padata.c b/kernel/padata.c
> > index 57c0074..9d91909 100644
> > --- a/kernel/padata.c
> > +++ b/kernel/padata.c
> > @@ -14,10 +14,6 @@
> >   * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> >   * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> >   * more details.
> > - *
> > - * You should have received a copy of the GNU General Public License along with
> > - * this program; if not, write to the Free Software Foundation, Inc.,
> > - * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
> >   */
> >
> >  #include <linux/export.h>
> > --
> > 2.7.4
> >
> 
> 
> Why not use instead the simpler SPDX ids?
> -- 
> Cordially
> Philippe Ombredanne

Hi Philippe,
  Adding the SPDX id can be the subject of a separate patch.
Believe you are part of the team doing an audit in this matter.
I shall leave adding the SPDX id to you guys the professionals.
Looks like you guys are using script to do this en masse.

But if you insist and our maintainer is agreeable, I can send
another patch to add the SPDX id.

Thanks.
Brgds,
CheahKC 

Re: [PATCH 1/2] padata: Remove FSF address

[Philippe Ombredanne]

Dear CheahKC,

On Wed, Dec 20, 2017 at 10:17 PM, Cheah Kok Cheong <thrust73@gmail.com> wrote:
> On Wed, Dec 20, 2017 at 09:20:48PM +0100, Philippe Ombredanne wrote:
>> On Wed, Dec 20, 2017 at 9:15 PM, Cheah Kok Cheong <thrust73@gmail.com> wrote:
>> > Remove FSF address otherwise checkpatch will flag my next patch.
>> >
>> > Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
>> > ---
>> >  kernel/padata.c | 4 ----
>> >  1 file changed, 4 deletions(-)
>> >
>> > diff --git a/kernel/padata.c b/kernel/padata.c
>> > index 57c0074..9d91909 100644
>> > --- a/kernel/padata.c
>> > +++ b/kernel/padata.c
>> > @@ -14,10 +14,6 @@
>> >   * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
>> >   * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
>> >   * more details.
>> > - *
>> > - * You should have received a copy of the GNU General Public License along with
>> > - * this program; if not, write to the Free Software Foundation, Inc.,
>> > - * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
>> >   */
>> >
>> >  #include <linux/export.h>
>> > --
>> > 2.7.4
>> >
>>
>>
>> Why not use instead the simpler SPDX ids?
>> --
>> Cordially
>> Philippe Ombredanne
>
> Hi Philippe,
>   Adding the SPDX id can be the subject of a separate patch.
> Believe you are part of the team doing an audit in this matter.
> I shall leave adding the SPDX id to you guys the professionals.
> Looks like you guys are using script to do this en masse.
>
> But if you insist and our maintainer is agreeable, I can send
> another patch to add the SPDX id.

If you could work it out directly that would be best. There are a lot
of files in the kernel and each one needs a careful review even with
best license detection script (which . So tagging files on the go when
they are updated is the best way to help!

Thank you.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/2] padata: Remove FSF address

[Cheah Kok Cheong]

On Thu, Dec 21, 2017 at 08:34:37AM +0100, Philippe Ombredanne wrote:
> Dear CheahKC,
> 
> On Wed, Dec 20, 2017 at 10:17 PM, Cheah Kok Cheong <thrust73@gmail.com> wrote:
> > On Wed, Dec 20, 2017 at 09:20:48PM +0100, Philippe Ombredanne wrote:
> >> On Wed, Dec 20, 2017 at 9:15 PM, Cheah Kok Cheong <thrust73@gmail.com> wrote:
> >> > Remove FSF address otherwise checkpatch will flag my next patch.
> >> >
> >> > Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
> >> > ---
> >> >  kernel/padata.c | 4 ----
> >> >  1 file changed, 4 deletions(-)
> >> >
> >> > diff --git a/kernel/padata.c b/kernel/padata.c
> >> > index 57c0074..9d91909 100644
> >> > --- a/kernel/padata.c
> >> > +++ b/kernel/padata.c
> >> > @@ -14,10 +14,6 @@
> >> >   * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> >> >   * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> >> >   * more details.
> >> > - *
> >> > - * You should have received a copy of the GNU General Public License along with
> >> > - * this program; if not, write to the Free Software Foundation, Inc.,
> >> > - * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
> >> >   */
> >> >
> >> >  #include <linux/export.h>
> >> > --
> >> > 2.7.4
> >> >
> >>
> >>
> >> Why not use instead the simpler SPDX ids?
> >> --
> >> Cordially
> >> Philippe Ombredanne
> >
> > Hi Philippe,
> >   Adding the SPDX id can be the subject of a separate patch.
> > Believe you are part of the team doing an audit in this matter.
> > I shall leave adding the SPDX id to you guys the professionals.
> > Looks like you guys are using script to do this en masse.
> >
> > But if you insist and our maintainer is agreeable, I can send
> > another patch to add the SPDX id.
> 
> If you could work it out directly that would be best. There are a lot
> of files in the kernel and each one needs a careful review even with
> best license detection script (which . So tagging files on the go when
> they are updated is the best way to help!
> 
> Thank you.
> 
> -- 
> Cordially
> Philippe Ombredanne
>
Ok I'll send a separate patch to add the SPDX id. Glad to help.

Thank you.

Brgds,
CheahKC

[PATCH] padata: add SPDX identifier

[Cheah Kok Cheong]

Add SPDX license identifier according to the type of license text found
in the file.

Cc: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
---
 kernel/padata.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/padata.c b/kernel/padata.c
index e265953..eb9a9d9 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * padata.c - generic interface to process data streams in parallel
  *
-- 
2.7.4

Re: [PATCH] padata: add SPDX identifier

[Herbert Xu]

Cheah Kok Cheong <thrust73@gmail.com> wrote:
> Add SPDX license identifier according to the type of license text found
> in the file.
> 
> Cc: Philippe Ombredanne <pombredanne@nexb.com>
> Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
> ---
> kernel/padata.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/padata.c b/kernel/padata.c
> index e265953..eb9a9d9 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
>  * padata.c - generic interface to process data streams in parallel
>  *

Steffen, are you OK with this patch?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] padata: add SPDX identifier

[Steffen Klassert]

On Thu, Dec 28, 2017 at 05:53:27PM +1100, Herbert Xu wrote:
> Cheah Kok Cheong <thrust73@gmail.com> wrote:
> > Add SPDX license identifier according to the type of license text found
> > in the file.
> > 
> > Cc: Philippe Ombredanne <pombredanne@nexb.com>
> > Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
> > ---
> > kernel/padata.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/kernel/padata.c b/kernel/padata.c
> > index e265953..eb9a9d9 100644
> > --- a/kernel/padata.c
> > +++ b/kernel/padata.c
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > /*
> >  * padata.c - generic interface to process data streams in parallel
> >  *
> 
> Steffen, are you OK with this patch?

Yes, I'm ok with this.

Acked-by: Steffen Klassert <steffen.klassert@secunet.com>

Re: padata: add SPDX identifier

[Herbert Xu]

On Thu, Dec 21, 2017 at 07:35:30PM +0800, Cheah Kok Cheong wrote:
> Add SPDX license identifier according to the type of license text found
> in the file.
> 
> Cc: Philippe Ombredanne <pombredanne@nexb.com>
> Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
> Acked-by: Steffen Klassert <steffen.klassert@secunet.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt