* media: tc358743: clk_disable_unprepare(refclk) missed
@ 2018-01-12 22:35 Alexey Khoroshilov
0 siblings, 0 replies; only message in thread
From: Alexey Khoroshilov @ 2018-01-12 22:35 UTC (permalink / raw)
To: Mats Randgaard, Mauro Carvalho Chehab
Cc: Alexey Khoroshilov, linux-media, linux-kernel, ldv-project
Hello,
tc358743_probe_of() enables refclk and disables it on its error paths.
But there is no clk_disable_unprepare(refclk) in tc358743_remove()
and on error paths in tc358743_probe(). Is it a problem?
If we should fix it, is adding struct clk *refclk; to tc358743_state
the reasonable way to keep clk easily available?
Found by Linux Driver Verification project (linuxtesting.org).
--
Alexey Khoroshilov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-01-12 22:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-12 22:35 media: tc358743: clk_disable_unprepare(refclk) missed Alexey Khoroshilov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).