From: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To: "awallis@codeaurora.org" <awallis@codeaurora.org>,
"vinod.koul@intel.com" <vinod.koul@intel.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zheng, Joey" <yu.zheng@hxt-semitech.com>,
"okaya@codeaurora.org" <okaya@codeaurora.org>,
"graham.moore@linux.intel.com" <graham.moore@linux.intel.com>
Subject: Re: [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback
Date: Wed, 24 Jan 2018 01:47:52 +0000 [thread overview]
Message-ID: <1516758463.2764.2.camel@hxt-semitech.com> (raw)
In-Reply-To: <65509b03-7efb-c4ae-0965-8f2f659ddf1a@codeaurora.org>
Hi, Adam
On Tue, 2018-01-23 at 09:32 -0500, Adam Wallis wrote:
> On 1/22/2018 2:28 AM, Yang Shunyong wrote:
> >
> > The type of arg passed to dmatest_callback is struct dmatest_done.
> > It refers to test_done in struct dmatest_thread, not done_wait.
> >
> > Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> > Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> > ---
> > drivers/dma/dmatest.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> > index ec5f9d2bc820..906e85d6dedc 100644
> > --- a/drivers/dma/dmatest.c
> > +++ b/drivers/dma/dmatest.c
> > @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
> > {
> > struct dmatest_done *done = arg;
> > struct dmatest_thread *thread =
> > - container_of(arg, struct dmatest_thread,
> > done_wait);
> > + container_of(arg, struct dmatest_thread,
> > test_done);
> > if (!thread->done) {
> > done->done = true;
> > wake_up_all(done->wait);
> >
> Thanks for the catch
>
> Acked-by: Adam Wallis <awallis@codeaurora.org>
Thanks!
Shunyong
next prev parent reply other threads:[~2018-01-24 1:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 7:28 [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback Yang Shunyong
2018-01-23 14:32 ` Adam Wallis
2018-01-24 1:47 ` Yang, Shunyong [this message]
2018-01-24 18:34 ` Adam Wallis
2018-02-11 9:28 ` Wen He
2018-02-13 5:54 ` Yang, Shunyong
2018-01-29 4:45 ` Vinod Koul
2018-01-29 6:21 ` Yang, Shunyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516758463.2764.2.camel@hxt-semitech.com \
--to=shunyong.yang@hxt-semitech.com \
--cc=awallis@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=graham.moore@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=vinod.koul@intel.com \
--cc=yu.zheng@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).