From: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To: "vinod.koul@intel.com" <vinod.koul@intel.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"awallis@codeaurora.org" <awallis@codeaurora.org>,
"Zheng, Joey" <yu.zheng@hxt-semitech.com>
Subject: Re: [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback
Date: Mon, 29 Jan 2018 06:21:09 +0000 [thread overview]
Message-ID: <1517206860.2845.2.camel@hxt-semitech.com> (raw)
In-Reply-To: <20180129044547.GK18649@localhost>
Hi, Vinod,
On Mon, 2018-01-29 at 10:15 +0530, Vinod Koul wrote:
> On Mon, Jan 22, 2018 at 03:28:28PM +0800, Yang Shunyong wrote:
> >
> > The type of arg passed to dmatest_callback is struct dmatest_done.
> > It refers to test_done in struct dmatest_thread, not done_wait.
> >
> > Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> > Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> > ---
> > drivers/dma/dmatest.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> > index ec5f9d2bc820..906e85d6dedc 100644
> > --- a/drivers/dma/dmatest.c
> > +++ b/drivers/dma/dmatest.c
> > @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
> > {
> > struct dmatest_done *done = arg;
> > struct dmatest_thread *thread =
> > - container_of(arg, struct dmatest_thread,
> > done_wait);
> > + container_of(arg, struct dmatest_thread,
> > test_done);
> This fixes it but one of the reason why compilers didn't catch this
> was the void arg. I just tested and used 'done' as the argument here
> rather than 'arg' and compiler was quick to point out the error.
>
> So a better fix IMO would be:
>
> -- >8 --
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index ec5f9d2bc820..80cc2be6483c 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
> {
> struct dmatest_done *done = arg;
> struct dmatest_thread *thread =
> - container_of(arg, struct dmatest_thread, done_wait);
> + container_of(done, struct dmatest_thread, test_done);
> if (!thread->done) {
> done->done = true;
> wake_up_all(done->wait);
>
Thanks. I will send out v2 patch soon.
Shunyong
prev parent reply other threads:[~2018-01-29 6:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 7:28 [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback Yang Shunyong
2018-01-23 14:32 ` Adam Wallis
2018-01-24 1:47 ` Yang, Shunyong
2018-01-24 18:34 ` Adam Wallis
2018-02-11 9:28 ` Wen He
2018-02-13 5:54 ` Yang, Shunyong
2018-01-29 4:45 ` Vinod Koul
2018-01-29 6:21 ` Yang, Shunyong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517206860.2845.2.camel@hxt-semitech.com \
--to=shunyong.yang@hxt-semitech.com \
--cc=awallis@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=yu.zheng@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).