linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] scsi: ufs: Enable quirk to ignore sending WRITE_SAME command
@ 2018-01-24  4:22 Asutosh Das
  2018-01-31  2:21 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Asutosh Das @ 2018-01-24  4:22 UTC (permalink / raw)
  To: subhashj, cang, vivek.gautam, vinholikatti, jejb, martin.petersen
  Cc: linux-scsi, Sujit Reddy Thumma, Asutosh Das, open list

From: Sujit Reddy Thumma <sthumma@codeaurora.org>

WRITE_SAME command is not supported by UFS. Enable a quirk for
the upper level drivers to not send WRITE SAME command.

Signed-off-by: Sujit Reddy Thumma <sthumma@codeaurora.org>
Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
---
 drivers/scsi/ufs/ufshcd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 8af2af3..5a8dc3b 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4356,6 +4356,9 @@ static int ufshcd_slave_alloc(struct scsi_device *sdev)
 	/* WRITE_SAME command is not supported*/
 	sdev->no_write_same = 1;
 
+	/* WRITE_SAME command is not supported*/
+	sdev->no_write_same = 1;
+
 	ufshcd_set_queue_depth(sdev);
 
 	ufshcd_get_lu_power_on_wp_status(hba, sdev);
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] scsi: ufs: Enable quirk to ignore sending WRITE_SAME command
  2018-01-24  4:22 [PATCH 1/1] scsi: ufs: Enable quirk to ignore sending WRITE_SAME command Asutosh Das
@ 2018-01-31  2:21 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2018-01-31  2:21 UTC (permalink / raw)
  To: Asutosh Das
  Cc: subhashj, cang, vivek.gautam, vinholikatti, jejb,
	martin.petersen, linux-scsi, Sujit Reddy Thumma, open list


Asutosh,

>  	/* WRITE_SAME command is not supported*/
>  	sdev->no_write_same = 1;
>  
> +	/* WRITE_SAME command is not supported*/
> +	sdev->no_write_same = 1;
> +

Uhm...

I applied this change to 4.16/scsi-fixes by hand.

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-31  2:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-24  4:22 [PATCH 1/1] scsi: ufs: Enable quirk to ignore sending WRITE_SAME command Asutosh Das
2018-01-31  2:21 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).