[PATCH 1/2] perf kmem: Document a missing option & an argument

[PATCH 1/2] perf kmem: Document a missing option & an argument

[Sangwon Hong]

First, perf kmem has --force option, but didn't document it on the man
page. So add missing --force option.

Second, --time option has to get a value, but didn't specify it on the
man page. So describe --time option's argument.

Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Taeung Song <treeze.taeung@gmail.com>
Signed-off-by: Sangwon Hong <qpakzk@gmail.com>
---
 tools/perf/Documentation/perf-kmem.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-kmem.txt b/tools/perf/Documentation/perf-kmem.txt
index 479fc32..c4aa843 100644
--- a/tools/perf/Documentation/perf-kmem.txt
+++ b/tools/perf/Documentation/perf-kmem.txt
@@ -25,6 +25,9 @@ OPTIONS
 --input=<file>::
 	Select the input file (default: perf.data unless stdin is a fifo)
 
+-f::
+--force::
+	Don't do ownership validation
 -v::
 --verbose::
         Be more verbose. (show symbol address, etc)
@@ -61,7 +64,7 @@ OPTIONS
 	default, but this option shows live (currently allocated) pages
 	instead.  (This option works with --page option only)
 
---time::
+--time=<start>,<stop>::
 	Only analyze samples within given time window: <start>,<stop>. Times
 	have the format seconds.microseconds. If start is not given (i.e., time
 	string is ',x.y') then analysis starts at the beginning of the file. If
-- 
2.7.4

[PATCH 2/2] perf mem: Document a missing option

[Sangwon Hong]

Add the missing --force option on the man page.

Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Taeung Song <treeze.taeung@gmail.com>
Signed-off-by: Sangwon Hong <qpakzk@gmail.com>
---
 tools/perf/Documentation/perf-mem.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/perf/Documentation/perf-mem.txt b/tools/perf/Documentation/perf-mem.txt
index 4be08a1..b021141 100644
--- a/tools/perf/Documentation/perf-mem.txt
+++ b/tools/perf/Documentation/perf-mem.txt
@@ -28,6 +28,10 @@ OPTIONS
 <command>...::
 	Any command you can specify in a shell.
 
+-f::
+--force::
+	Don't do ownership validation
+
 -t::
 --type=::
 	Select the memory operation type: load or store (default: load,store)
-- 
2.7.4

Re: [PATCH 1/2] perf kmem: Document a missing option & an argument

[Namhyung Kim]

On Mon, Feb 12, 2018 at 05:38:36AM +0900, Sangwon Hong wrote:
> First, perf kmem has --force option, but didn't document it on the man
> page. So add missing --force option.
> 
> Second, --time option has to get a value, but didn't specify it on the
> man page. So describe --time option's argument.
> 
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Taeung Song <treeze.taeung@gmail.com>
> Signed-off-by: Sangwon Hong <qpakzk@gmail.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

A nit below though..


> ---
>  tools/perf/Documentation/perf-kmem.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Documentation/perf-kmem.txt b/tools/perf/Documentation/perf-kmem.txt
> index 479fc32..c4aa843 100644
> --- a/tools/perf/Documentation/perf-kmem.txt
> +++ b/tools/perf/Documentation/perf-kmem.txt
> @@ -25,6 +25,9 @@ OPTIONS
>  --input=<file>::
>  	Select the input file (default: perf.data unless stdin is a fifo)
>  
> +-f::
> +--force::
> +	Don't do ownership validation

Please add a blank line here

Thanks,
Namhyung


>  -v::
>  --verbose::
>          Be more verbose. (show symbol address, etc)
> @@ -61,7 +64,7 @@ OPTIONS
>  	default, but this option shows live (currently allocated) pages
>  	instead.  (This option works with --page option only)
>  
> ---time::
> +--time=<start>,<stop>::
>  	Only analyze samples within given time window: <start>,<stop>. Times
>  	have the format seconds.microseconds. If start is not given (i.e., time
>  	string is ',x.y') then analysis starts at the beginning of the file. If
> -- 
> 2.7.4
> 

Re: [PATCH 2/2] perf mem: Document a missing option

[Namhyung Kim]

On Mon, Feb 12, 2018 at 05:38:37AM +0900, Sangwon Hong wrote:
> Add the missing --force option on the man page.
> 
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Taeung Song <treeze.taeung@gmail.com>
> Signed-off-by: Sangwon Hong <qpakzk@gmail.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>  tools/perf/Documentation/perf-mem.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/Documentation/perf-mem.txt b/tools/perf/Documentation/perf-mem.txt
> index 4be08a1..b021141 100644
> --- a/tools/perf/Documentation/perf-mem.txt
> +++ b/tools/perf/Documentation/perf-mem.txt
> @@ -28,6 +28,10 @@ OPTIONS
>  <command>...::
>  	Any command you can specify in a shell.
>  
> +-f::
> +--force::
> +	Don't do ownership validation
> +
>  -t::
>  --type=::
>  	Select the memory operation type: load or store (default: load,store)
> -- 
> 2.7.4
> 

Re: [PATCH 1/2] perf kmem: Document a missing option & an argument

[Arnaldo Carvalho de Melo]

Em Mon, Feb 12, 2018 at 10:51:28AM +0900, Namhyung Kim escreveu:
> On Mon, Feb 12, 2018 at 05:38:36AM +0900, Sangwon Hong wrote:
> > First, perf kmem has --force option, but didn't document it on the man
> > page. So add missing --force option.
> > 
> > Second, --time option has to get a value, but didn't specify it on the
> > man page. So describe --time option's argument.
> > 
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Taeung Song <treeze.taeung@gmail.com>
> > Signed-off-by: Sangwon Hong <qpakzk@gmail.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> 
> A nit below though..
> 
> 
> > ---
> >  tools/perf/Documentation/perf-kmem.txt | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/Documentation/perf-kmem.txt b/tools/perf/Documentation/perf-kmem.txt
> > index 479fc32..c4aa843 100644
> > --- a/tools/perf/Documentation/perf-kmem.txt
> > +++ b/tools/perf/Documentation/perf-kmem.txt
> > @@ -25,6 +25,9 @@ OPTIONS
> >  --input=<file>::
> >  	Select the input file (default: perf.data unless stdin is a fifo)
> >  
> > +-f::
> > +--force::
> > +	Don't do ownership validation
> 
> Please add a blank line here

Done
 
> Thanks,
> Namhyung
> 
> 
> >  -v::
> >  --verbose::
> >          Be more verbose. (show symbol address, etc)
> > @@ -61,7 +64,7 @@ OPTIONS
> >  	default, but this option shows live (currently allocated) pages
> >  	instead.  (This option works with --page option only)
> >  
> > ---time::
> > +--time=<start>,<stop>::
> >  	Only analyze samples within given time window: <start>,<stop>. Times
> >  	have the format seconds.microseconds. If start is not given (i.e., time
> >  	string is ',x.y') then analysis starts at the beginning of the file. If
> > -- 
> > 2.7.4
> > 

[tip:perf/core] perf kmem: Document a missing option & an argument

[tip-bot for Sangwon Hong]

Commit-ID:  577980a00063935815a55f461601579fd5e61f59
Gitweb:     https://git.kernel.org/tip/577980a00063935815a55f461601579fd5e61f59
Author:     Sangwon Hong <qpakzk@gmail.com>
AuthorDate: Mon, 12 Feb 2018 05:38:36 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 16 Feb 2018 14:55:42 -0300

perf kmem: Document a missing option & an argument

First, 'perf kmem' has a '--force' option, but didn't document it on the
man page. So add it.

Second, the '--time' option has to get a value, but isn't documented on
the man page. Describe it.

Signed-off-by: Sangwon Hong <qpakzk@gmail.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Taeung Song <treeze.taeung@gmail.com>
Link: http://lkml.kernel.org/r/1518381517-30766-1-git-send-email-qpakzk@gmail.com
[ Add blank like after --force block, as requested by Namhyung ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-kmem.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-kmem.txt b/tools/perf/Documentation/perf-kmem.txt
index 479fc32..85b8ac6 100644
--- a/tools/perf/Documentation/perf-kmem.txt
+++ b/tools/perf/Documentation/perf-kmem.txt
@@ -25,6 +25,10 @@ OPTIONS
 --input=<file>::
 	Select the input file (default: perf.data unless stdin is a fifo)
 
+-f::
+--force::
+	Don't do ownership validation
+
 -v::
 --verbose::
         Be more verbose. (show symbol address, etc)
@@ -61,7 +65,7 @@ OPTIONS
 	default, but this option shows live (currently allocated) pages
 	instead.  (This option works with --page option only)
 
---time::
+--time=<start>,<stop>::
 	Only analyze samples within given time window: <start>,<stop>. Times
 	have the format seconds.microseconds. If start is not given (i.e., time
 	string is ',x.y') then analysis starts at the beginning of the file. If

[tip:perf/core] perf mem: Document a missing option

[tip-bot for Sangwon Hong]

Commit-ID:  7e99b1972263c2f611d7f2fb67d09f3384006593
Gitweb:     https://git.kernel.org/tip/7e99b1972263c2f611d7f2fb67d09f3384006593
Author:     Sangwon Hong <qpakzk@gmail.com>
AuthorDate: Mon, 12 Feb 2018 05:38:37 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 16 Feb 2018 14:55:42 -0300

perf mem: Document a missing option

Add the missing --force option on the man page.

Signed-off-by: Sangwon Hong <qpakzk@gmail.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Taeung Song <treeze.taeung@gmail.com>
Link: http://lkml.kernel.org/r/1518381517-30766-2-git-send-email-qpakzk@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-mem.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/perf/Documentation/perf-mem.txt b/tools/perf/Documentation/perf-mem.txt
index 4be08a1..b021141 100644
--- a/tools/perf/Documentation/perf-mem.txt
+++ b/tools/perf/Documentation/perf-mem.txt
@@ -28,6 +28,10 @@ OPTIONS
 <command>...::
 	Any command you can specify in a shell.
 
+-f::
+--force::
+	Don't do ownership validation
+
 -t::
 --type=::
 	Select the memory operation type: load or store (default: load,store)