* [PATCH] emulex/benet: Constify *be_misconfig_evt_port_state[]
@ 2018-02-27 22:29 Hernán Gonzalez
2018-02-28 16:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hernán Gonzalez @ 2018-02-27 22:29 UTC (permalink / raw)
To: sathya.perla, ajit.khaparde, sriharsha.basavapatna,
somnath.kotur, netdev, linux-kernel, hernan
Note: This is compile only tested as I have no access to the hw.
No benefit gained except for some self-documenting.
add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
Function old new delta
Total: Before=2757703, After=2757703, chg +0.00%
Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar>
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 2 +-
drivers/net/ethernet/emulex/benet/be_cmds.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c
index 1a49297..ff92ab1 100644
--- a/drivers/net/ethernet/emulex/benet/be_cmds.c
+++ b/drivers/net/ethernet/emulex/benet/be_cmds.c
@@ -19,7 +19,7 @@
#include "be.h"
#include "be_cmds.h"
-char *be_misconfig_evt_port_state[] = {
+const char * const be_misconfig_evt_port_state[] = {
"Physical Link is functional",
"Optics faulted/incorrectly installed/not installed - Reseat optics. If issue not resolved, replace.",
"Optics of two types installed – Remove one optic or install matching pair of optics.",
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.h b/drivers/net/ethernet/emulex/benet/be_cmds.h
index 09da2d8..e8b43cf 100644
--- a/drivers/net/ethernet/emulex/benet/be_cmds.h
+++ b/drivers/net/ethernet/emulex/benet/be_cmds.h
@@ -201,7 +201,7 @@ enum {
phy_state == BE_PHY_UNQUALIFIED || \
phy_state == BE_PHY_UNCERTIFIED)
-extern char *be_misconfig_evt_port_state[];
+extern const char * const be_misconfig_evt_port_state[];
/* async event indicating misconfigured port */
struct be_async_event_misconfig_port {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] emulex/benet: Constify *be_misconfig_evt_port_state[]
2018-02-27 22:29 [PATCH] emulex/benet: Constify *be_misconfig_evt_port_state[] Hernán Gonzalez
@ 2018-02-28 16:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-02-28 16:39 UTC (permalink / raw)
To: hernan
Cc: sathya.perla, ajit.khaparde, sriharsha.basavapatna,
somnath.kotur, netdev, linux-kernel
From: Hernán Gonzalez <hernan@vanguardiasur.com.ar>
Date: Tue, 27 Feb 2018 19:29:23 -0300
> Note: This is compile only tested as I have no access to the hw.
> No benefit gained except for some self-documenting.
>
> add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0)
> Function old new delta
> Total: Before=2757703, After=2757703, chg +0.00%
>
> Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar>
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-28 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-27 22:29 [PATCH] emulex/benet: Constify *be_misconfig_evt_port_state[] Hernán Gonzalez
2018-02-28 16:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).