From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>, "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Linux PCI <linux-pci@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/4] x86/pci: Re-use new dmi_get_bios_year() helper
Date: Wed, 28 Feb 2018 21:34:21 +0200 [thread overview]
Message-ID: <1519846461.10722.309.camel@linux.intel.com> (raw)
In-Reply-To: <20180228202144.2ae8149f@endymion>
On Wed, 2018-02-28 at 20:21 +0100, Jean Delvare wrote:
> On Wed, 28 Feb 2018 11:33:39 +0100, Rafael J. Wysocki wrote:
> > On Wed, Feb 28, 2018 at 11:29 AM, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > I would assume that no BIOS date is related to prehistoric
> > > firmwares and
> > > using _CRS would sound weird on them.
> >
> > Careful here.
> >
> > You seem to be assuming that the DMI information is always valid
> > and/or complete which is know to not be the case sometimes.
>
> True. While the BIOS date is not the worst offender when it comes to
> broken DMI data, you must remember that the date comes as a string,
> and
> older SMBIOS specifications did not even recommend a specific format
> for that string. As a matter of fact, my collection of DMI tables
> includes a few creative samples like "Jul 7 2016" or "09-16-08" which
> the kernel fails to parse.
>
> So the default behavior at the driver level shouldn't be based on what
> older systems are most likely to enjoy. The default behavior must be
> the safest option, regardless of the age of the system.
Yep.
And here is a very good question which path is more safer: use _CRS, or
not?
Rafael, do you know any consequences of not using _CRS for PCI on older
and newer machines?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-02-28 19:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 12:59 [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper Andy Shevchenko
2018-02-22 12:59 ` [PATCH v1 2/4] x86/pci: Re-use new " Andy Shevchenko
2018-02-23 8:25 ` [tip:x86/platform] x86/pci: Simplify code by using the " tip-bot for Andy Shevchenko
2018-02-23 21:39 ` [PATCH v1 2/4] x86/pci: Re-use " Bjorn Helgaas
2018-02-26 16:28 ` Jean Delvare
2018-02-28 10:29 ` Andy Shevchenko
2018-02-28 10:33 ` Rafael J. Wysocki
2018-02-28 19:21 ` Jean Delvare
2018-02-28 19:34 ` Andy Shevchenko [this message]
2018-02-22 12:59 ` [PATCH v1 3/4] ACPI / sleep: " Andy Shevchenko
2018-02-23 8:25 ` [tip:x86/platform] ACPI/sleep: Simplify code by using the " tip-bot for Andy Shevchenko
2018-02-26 16:31 ` [PATCH v1 3/4] ACPI / sleep: Re-use " Jean Delvare
2018-02-22 12:59 ` [PATCH v1 4/4] pci: " Andy Shevchenko
2018-02-23 8:26 ` [tip:x86/platform] pci: Simplify code by using the " tip-bot for Andy Shevchenko
2018-02-23 21:40 ` [PATCH v1 4/4] pci: Re-use " Bjorn Helgaas
2018-02-25 13:27 ` Andy Shevchenko
2018-02-26 18:19 ` Bjorn Helgaas
2018-02-28 10:12 ` Andy Shevchenko
2018-02-28 15:17 ` Bjorn Helgaas
2018-02-26 20:40 ` Jean Delvare
2018-02-23 8:24 ` [tip:x86/platform] dmi: Introduce the dmi_get_bios_year() helper function tip-bot for Andy Shevchenko
2018-02-23 21:35 ` [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper Bjorn Helgaas
2018-02-25 13:23 ` Andy Shevchenko
2018-02-26 9:29 ` Rafael J. Wysocki
2018-02-28 10:14 ` Andy Shevchenko
2018-02-27 9:14 ` Jean Delvare
2018-02-28 10:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519846461.10722.309.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).