From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/4] pci: Re-use new dmi_get_bios_year() helper
Date: Fri, 23 Feb 2018 15:40:51 -0600 [thread overview]
Message-ID: <20180223214051.GN14632@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20180222125923.57385-4-andriy.shevchenko@linux.intel.com>
Please use
PCI: Re-use ...
to match the prevailing drivers/pci style.
On Thu, Feb 22, 2018 at 02:59:23PM +0200, Andy Shevchenko wrote:
> ...instead of open coding its functionality.
Same comment about making the changelog complete, independent of the
subject.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Let me know if you want me to take the series. Otherwise I'll assume it
goes elsewhere.
> ---
> drivers/pci/pci.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index f6a4dd10d9b0..ae654e21439d 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -2258,8 +2258,6 @@ void pci_config_pm_runtime_put(struct pci_dev *pdev)
> */
> bool pci_bridge_d3_possible(struct pci_dev *bridge)
> {
> - unsigned int year;
> -
> if (!pci_is_pcie(bridge))
> return false;
>
> @@ -2287,10 +2285,8 @@ bool pci_bridge_d3_possible(struct pci_dev *bridge)
> * It should be safe to put PCIe ports from 2015 or newer
> * to D3.
> */
> - if (dmi_get_date(DMI_BIOS_DATE, &year, NULL, NULL) &&
> - year >= 2015) {
> + if (dmi_get_bios_year() >= 2015)
> return true;
> - }
> break;
> }
>
> --
> 2.16.1
>
next prev parent reply other threads:[~2018-02-23 21:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 12:59 [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper Andy Shevchenko
2018-02-22 12:59 ` [PATCH v1 2/4] x86/pci: Re-use new " Andy Shevchenko
2018-02-23 8:25 ` [tip:x86/platform] x86/pci: Simplify code by using the " tip-bot for Andy Shevchenko
2018-02-23 21:39 ` [PATCH v1 2/4] x86/pci: Re-use " Bjorn Helgaas
2018-02-26 16:28 ` Jean Delvare
2018-02-28 10:29 ` Andy Shevchenko
2018-02-28 10:33 ` Rafael J. Wysocki
2018-02-28 19:21 ` Jean Delvare
2018-02-28 19:34 ` Andy Shevchenko
2018-02-22 12:59 ` [PATCH v1 3/4] ACPI / sleep: " Andy Shevchenko
2018-02-23 8:25 ` [tip:x86/platform] ACPI/sleep: Simplify code by using the " tip-bot for Andy Shevchenko
2018-02-26 16:31 ` [PATCH v1 3/4] ACPI / sleep: Re-use " Jean Delvare
2018-02-22 12:59 ` [PATCH v1 4/4] pci: " Andy Shevchenko
2018-02-23 8:26 ` [tip:x86/platform] pci: Simplify code by using the " tip-bot for Andy Shevchenko
2018-02-23 21:40 ` Bjorn Helgaas [this message]
2018-02-25 13:27 ` [PATCH v1 4/4] pci: Re-use " Andy Shevchenko
2018-02-26 18:19 ` Bjorn Helgaas
2018-02-28 10:12 ` Andy Shevchenko
2018-02-28 15:17 ` Bjorn Helgaas
2018-02-26 20:40 ` Jean Delvare
2018-02-23 8:24 ` [tip:x86/platform] dmi: Introduce the dmi_get_bios_year() helper function tip-bot for Andy Shevchenko
2018-02-23 21:35 ` [PATCH v1 1/4] dmi: Introduce dmi_get_bios_year() helper Bjorn Helgaas
2018-02-25 13:23 ` Andy Shevchenko
2018-02-26 9:29 ` Rafael J. Wysocki
2018-02-28 10:14 ` Andy Shevchenko
2018-02-27 9:14 ` Jean Delvare
2018-02-28 10:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223214051.GN14632@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).