* [PATCH] rtc: at91sam: add 'depends on HAS_IOMEM' to fix unmet dependency
@ 2018-03-06 11:08 Masahiro Yamada
2018-03-06 14:49 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2018-03-06 11:08 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, linux-rtc
Cc: Arnd Bergmann, Masahiro Yamada, linux-kernel
This config select's MFD_SYSCON, but does not depend on HAS_IOMEM.
Compile testing on architecture without HAS_IOMEM causes "unmet
direct dependencies" in Kconfig phase.
Detected by "make ARCH=score allyesconfig".
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Arnd Bergmann and I discussed how to fix unmet dependency of MFD_SYSCON.
https://lkml.org/lkml/2018/2/27/284
We agreed to add 'depends on HAS_IOMEM' to drivers causing
unmet dependency.
drivers/rtc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 8ab5f0a5..d826e5d 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1413,6 +1413,7 @@ config RTC_DRV_AT91RM9200
config RTC_DRV_AT91SAM9
tristate "AT91SAM9 RTT as RTC"
depends on ARCH_AT91 || COMPILE_TEST
+ depends on HAS_IOMEM
select MFD_SYSCON
help
Some AT91SAM9 SoCs provide an RTT (Real Time Timer) block which
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: at91sam: add 'depends on HAS_IOMEM' to fix unmet dependency
2018-03-06 11:08 [PATCH] rtc: at91sam: add 'depends on HAS_IOMEM' to fix unmet dependency Masahiro Yamada
@ 2018-03-06 14:49 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2018-03-06 14:49 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Alessandro Zummo, linux-rtc, Arnd Bergmann, linux-kernel
On 06/03/2018 at 20:08:11 +0900, Masahiro Yamada wrote:
> This config select's MFD_SYSCON, but does not depend on HAS_IOMEM.
>
> Compile testing on architecture without HAS_IOMEM causes "unmet
> direct dependencies" in Kconfig phase.
>
> Detected by "make ARCH=score allyesconfig".
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Arnd Bergmann and I discussed how to fix unmet dependency of MFD_SYSCON.
> https://lkml.org/lkml/2018/2/27/284
>
> We agreed to add 'depends on HAS_IOMEM' to drivers causing
> unmet dependency.
>
>
> drivers/rtc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-06 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-06 11:08 [PATCH] rtc: at91sam: add 'depends on HAS_IOMEM' to fix unmet dependency Masahiro Yamada
2018-03-06 14:49 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).