* [PATCH] reset: imx7: add 'depends on HAS_IOMEM' to fix unmet dependency
@ 2018-03-06 11:15 Masahiro Yamada
2018-03-06 13:21 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2018-03-06 11:15 UTC (permalink / raw)
To: Philipp Zabel; +Cc: Arnd Bergmann, Masahiro Yamada, linux-kernel
This config select's MFD_SYSCON, but does not depend on HAS_IOMEM.
Compile testing on architecture without HAS_IOMEM causes "unmet
direct dependencies" in Kconfig phase.
Detected by "make ARCH=score allyesconfig".
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Arnd Bergmann and I discussed how to fix unmet dependency of MFD_SYSCON.
https://lkml.org/lkml/2018/2/27/284
We agreed to add 'depends on HAS_IOMEM' to drivers causing
unmet dependency.
drivers/reset/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 7fc7769..b1008b9 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -49,6 +49,7 @@ config RESET_HSDK
config RESET_IMX7
bool "i.MX7 Reset Driver" if COMPILE_TEST
+ depends on HAS_IOMEM
default SOC_IMX7D
select MFD_SYSCON
help
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] reset: imx7: add 'depends on HAS_IOMEM' to fix unmet dependency
2018-03-06 11:15 [PATCH] reset: imx7: add 'depends on HAS_IOMEM' to fix unmet dependency Masahiro Yamada
@ 2018-03-06 13:21 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2018-03-06 13:21 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Arnd Bergmann, linux-kernel
Hi Masahiro,
On Tue, 2018-03-06 at 20:15 +0900, Masahiro Yamada wrote:
> This config select's MFD_SYSCON, but does not depend on HAS_IOMEM.
>
> Compile testing on architecture without HAS_IOMEM causes "unmet
> direct dependencies" in Kconfig phase.
>
> Detected by "make ARCH=score allyesconfig".
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Thank you, applied to reset/next.
>
> ---
>
> Arnd Bergmann and I discussed how to fix unmet dependency of MFD_SYSCON.
> https://lkml.org/lkml/2018/2/27/284
>
> We agreed to add 'depends on HAS_IOMEM' to drivers causing
> unmet dependency.
Agreed, RESET_TI_SYSCON already does the same. Thanks for the context.
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-06 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-06 11:15 [PATCH] reset: imx7: add 'depends on HAS_IOMEM' to fix unmet dependency Masahiro Yamada
2018-03-06 13:21 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).