* [PATCH v3] ssb: use put_device() if device_register fail
@ 2018-03-08 6:23 Arvind Yadav
2018-03-13 16:48 ` [v3] " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2018-03-08 6:23 UTC (permalink / raw)
To: m; +Cc: linux-kernel, linux-wireless
Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2:
Removed kfree() call for @dev.
changes in v3:
Add put_device() in place of kfree().
drivers/ssb/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 65420a9..e732fd3 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -522,7 +522,7 @@ static int ssb_devices_register(struct ssb_bus *bus)
/* Set dev to NULL to not unregister
* dev on error unwinding. */
sdev->dev = NULL;
- kfree(devwrap);
+ put_device(dev);
goto error;
}
dev_idx++;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [v3] ssb: use put_device() if device_register fail
2018-03-08 6:23 [PATCH v3] ssb: use put_device() if device_register fail Arvind Yadav
@ 2018-03-13 16:48 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2018-03-13 16:48 UTC (permalink / raw)
To: Arvind Yadav; +Cc: m, linux-kernel, linux-wireless
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> Never directly free @dev after calling device_register(), even
> if it returned an error! Always use put_device() to give up the
> reference initialized.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
a24853aab591 ssb: use put_device() if device_register fail
--
https://patchwork.kernel.org/patch/10266711/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-13 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-08 6:23 [PATCH v3] ssb: use put_device() if device_register fail Arvind Yadav
2018-03-13 16:48 ` [v3] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).