* drivers/net/sk98lin/skproc.c undefined root_dev
@ 2001-08-06 4:33 Keith Owens
2001-08-06 5:43 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Keith Owens @ 2001-08-06 4:33 UTC (permalink / raw)
To: linux-kernel; +Cc: Mirko Lindner
drivers/net/sk98lin/skproc.c:extern struct net_device *root_dev
Defined extern, all other definitions of root_dev are static, except in
sparc. CONFIG_SK98LIN is not limited to sparc. Either the config is
wrong or the code in skproc is wrong.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: drivers/net/sk98lin/skproc.c undefined root_dev
2001-08-06 4:33 drivers/net/sk98lin/skproc.c undefined root_dev Keith Owens
@ 2001-08-06 5:43 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2001-08-06 5:43 UTC (permalink / raw)
To: Keith Owens; +Cc: linux-kernel, Mirko Lindner
Keith Owens writes:
> drivers/net/sk98lin/skproc.c:extern struct net_device *root_dev
> Defined extern, all other definitions of root_dev are static, except in
> sparc. CONFIG_SK98LIN is not limited to sparc. Either the config is
> wrong or the code in skproc is wrong.
I think two things are wrong here, nice spotting:
1) root_dev in the sk98lin driver needs another name if it is
going to be exported to multiple objects within the driver.
Something like sk98lin_root_dev.
2) It should be non-static in skge.c
I distinctly remember it compiling and working correctly on x86
sometime earlier in the 2.4.x series, so perhaps this brokenness
is recent.
Later,
David S. Miller
davem@redhat.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-08-06 5:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-06 4:33 drivers/net/sk98lin/skproc.c undefined root_dev Keith Owens
2001-08-06 5:43 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).