* [PATCH -next] powerpc: Fix error return code in ppc4xx_msi_probe()
@ 2018-03-26 14:43 Wei Yongjun
2018-03-31 14:04 ` [-next] " Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-03-26 14:43 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Rob Herring, Markus Elfring, Tyrel Datwyler
Cc: Wei Yongjun, linuxppc-dev, linux-kernel, kernel-janitors
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
arch/powerpc/platforms/4xx/msi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/4xx/msi.c b/arch/powerpc/platforms/4xx/msi.c
index 4b859c8..0b71c52 100644
--- a/arch/powerpc/platforms/4xx/msi.c
+++ b/arch/powerpc/platforms/4xx/msi.c
@@ -241,7 +241,8 @@ static int ppc4xx_msi_probe(struct platform_device *dev)
if (!msi_irqs)
return -ENODEV;
- if (ppc4xx_setup_pcieh_hw(dev, res, msi))
+ err = ppc4xx_setup_pcieh_hw(dev, res, msi)
+ if (err)
goto error_out;
err = ppc4xx_msi_init_allocator(dev, msi);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [-next] powerpc: Fix error return code in ppc4xx_msi_probe()
2018-03-26 14:43 [PATCH -next] powerpc: Fix error return code in ppc4xx_msi_probe() Wei Yongjun
@ 2018-03-31 14:04 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2018-03-31 14:04 UTC (permalink / raw)
To: Wei Yongjun, Benjamin Herrenschmidt, Paul Mackerras, Rob Herring,
Markus Elfring, Tyrel Datwyler
Cc: linuxppc-dev, kernel-janitors, Wei Yongjun, linux-kernel
On Mon, 2018-03-26 at 14:43:09 UTC, Wei Yongjun wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/9a2c1d31e6910b9d5e0205f9167d0b
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-31 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-26 14:43 [PATCH -next] powerpc: Fix error return code in ppc4xx_msi_probe() Wei Yongjun
2018-03-31 14:04 ` [-next] " Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).