* [PATCH] scsi: hosts: remove redundant assingment of shost->use_blk_mq
@ 2018-04-02 9:37 Johannes Thumshirn
2018-04-02 13:53 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Thumshirn @ 2018-04-02 9:37 UTC (permalink / raw)
To: Martin K . Petersen
Cc: Linux Kernel Mailinglist, Linux SCSI Mailinglist, Johannes Thumshirn
Coverity reports that we're assigning shost->use_blk_mq twice. This
looks like the result of a bad merge of commit 2f31115e940c ("scsi:
core: introduce force_blk_mq")
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
drivers/scsi/hosts.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index ef22b275d050..c36f2a44e5ed 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -473,7 +473,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
else
shost->dma_boundary = 0xffffffff;
- shost->use_blk_mq = scsi_use_blk_mq;
shost->use_blk_mq = scsi_use_blk_mq || shost->hostt->force_blk_mq;
device_initialize(&shost->shost_gendev);
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: hosts: remove redundant assingment of shost->use_blk_mq
2018-04-02 9:37 [PATCH] scsi: hosts: remove redundant assingment of shost->use_blk_mq Johannes Thumshirn
@ 2018-04-02 13:53 ` Bart Van Assche
2018-04-03 7:40 ` Johannes Thumshirn
0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2018-04-02 13:53 UTC (permalink / raw)
To: jthumshirn, martin.petersen; +Cc: linux-scsi, linux-kernel
On Mon, 2018-04-02 at 11:37 +0200, Johannes Thumshirn wrote:
> Coverity reports that we're assigning shost->use_blk_mq twice. This
> looks like the result of a bad merge of commit 2f31115e940c ("scsi:
> core: introduce force_blk_mq")
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> drivers/scsi/hosts.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
> index ef22b275d050..c36f2a44e5ed 100644
> --- a/drivers/scsi/hosts.c
> +++ b/drivers/scsi/hosts.c
> @@ -473,7 +473,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
> else
> shost->dma_boundary = 0xffffffff;
>
> - shost->use_blk_mq = scsi_use_blk_mq;
> shost->use_blk_mq = scsi_use_blk_mq || shost->hostt->force_blk_mq;
>
> device_initialize(&shost->shost_gendev);
A similar patch has already been queued by Martin. See also
https://patchwork.kernel.org/patch/10313569/.
Bart.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: hosts: remove redundant assingment of shost->use_blk_mq
2018-04-02 13:53 ` Bart Van Assche
@ 2018-04-03 7:40 ` Johannes Thumshirn
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2018-04-03 7:40 UTC (permalink / raw)
To: Bart Van Assche, martin.petersen; +Cc: linux-scsi, linux-kernel
On Mon, 2018-04-02 at 13:53 +0000, Bart Van Assche wrote:
> A similar patch has already been queued by Martin. See also
> https://patchwork.kernel.org/patch/10313569/.
Ah OK, fine then :-)
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-03 7:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-02 9:37 [PATCH] scsi: hosts: remove redundant assingment of shost->use_blk_mq Johannes Thumshirn
2018-04-02 13:53 ` Bart Van Assche
2018-04-03 7:40 ` Johannes Thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).