* [PATCH v2 1/4] arm64: dts: renesas: r8a77970: add VSPD support
2018-04-10 10:54 [PATCH v2 0/4] V3M-Eagle HDMI output enablement Jacopo Mondi
@ 2018-04-10 10:54 ` Jacopo Mondi
2018-04-10 10:54 ` [PATCH v2 2/4] arm64: dts: renesas: r8a77970: add DU support Jacopo Mondi
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Jacopo Mondi @ 2018-04-10 10:54 UTC (permalink / raw)
To: horms, magnus.damm, geert, laurent.pinchart, niklas.soderlund,
sergei.shtylyov
Cc: Jacopo Mondi, linux-renesas-soc, devicetree, linux-kernel,
Vladimir Barinov, Niklas Söderlund
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Describe VSPD0 in the R8A77970 device tree; it will be used by DU in
the next patch...
Based on the original (and large) patch by Daisuke Matsushita
<daisuke.matsushita.ns@hitachi.com>.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v1 -> v2:
- Extend the memory region to include V6_CLUTn_TBL* registers.
---
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index 97c27ef..a3ef3bd 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -625,6 +625,16 @@
power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
resets = <&cpg 603>;
};
+
+ vspd0: vsp@fea20000 {
+ compatible = "renesas,vsp2";
+ reg = <0 0xfea20000 0 0x8000>;
+ interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 623>;
+ power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+ resets = <&cpg 623>;
+ renesas,fcp = <&fcpvd0>;
+ };
};
timer {
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 2/4] arm64: dts: renesas: r8a77970: add DU support
2018-04-10 10:54 [PATCH v2 0/4] V3M-Eagle HDMI output enablement Jacopo Mondi
2018-04-10 10:54 ` [PATCH v2 1/4] arm64: dts: renesas: r8a77970: add VSPD support Jacopo Mondi
@ 2018-04-10 10:54 ` Jacopo Mondi
2018-04-10 10:54 ` [PATCH v2 3/4] arm64: dts: renesas: r8a77970: add LVDS support Jacopo Mondi
2018-04-10 10:54 ` [PATCH v2 4/4] arm64: dts: renesas: eagle: Enable HDMI output Jacopo Mondi
3 siblings, 0 replies; 11+ messages in thread
From: Jacopo Mondi @ 2018-04-10 10:54 UTC (permalink / raw)
To: horms, magnus.damm, geert, laurent.pinchart, niklas.soderlund,
sergei.shtylyov
Cc: Jacopo Mondi, linux-renesas-soc, devicetree, linux-kernel,
Vladimir Barinov, Niklas Söderlund
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Define the generic R8A77970 part of the DU device node.
Based on the original (and large) patch by Daisuke Matsushita
<daisuke.matsushita.ns@hitachi.com>.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v1 -> v2:
- Rename the du_out_lvds endpoint to comply with the name used in other
Renesas board DTS files
---
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index a3ef3bd..ae5797d 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -635,6 +635,34 @@
resets = <&cpg 623>;
renesas,fcp = <&fcpvd0>;
};
+
+ du: display@feb00000 {
+ compatible = "renesas,du-r8a77970";
+ reg = <0 0xfeb00000 0 0x80000>;
+ interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 724>;
+ clock-names = "du.0";
+ power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+ vsps = <&vspd0>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ du_out_rgb: endpoint {
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ du_out_lvds0: endpoint {
+ };
+ };
+ };
+ };
};
timer {
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 3/4] arm64: dts: renesas: r8a77970: add LVDS support
2018-04-10 10:54 [PATCH v2 0/4] V3M-Eagle HDMI output enablement Jacopo Mondi
2018-04-10 10:54 ` [PATCH v2 1/4] arm64: dts: renesas: r8a77970: add VSPD support Jacopo Mondi
2018-04-10 10:54 ` [PATCH v2 2/4] arm64: dts: renesas: r8a77970: add DU support Jacopo Mondi
@ 2018-04-10 10:54 ` Jacopo Mondi
2018-04-10 12:02 ` Sergei Shtylyov
2018-04-10 10:54 ` [PATCH v2 4/4] arm64: dts: renesas: eagle: Enable HDMI output Jacopo Mondi
3 siblings, 1 reply; 11+ messages in thread
From: Jacopo Mondi @ 2018-04-10 10:54 UTC (permalink / raw)
To: horms, magnus.damm, geert, laurent.pinchart, niklas.soderlund,
sergei.shtylyov
Cc: Jacopo Mondi, linux-renesas-soc, devicetree, linux-kernel,
Niklas Söderlund
From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect
the it to the LVDS output of the DU.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v1 -> v2:
- Rebased on the modified endpoint name and changed patch subject to
comply with other patches in the series from Sergei.
---
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index ae5797d..ae15355 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -659,6 +659,33 @@
port@1 {
reg = <1>;
du_out_lvds0: endpoint {
+ remote-endpoint = <&lvds0_in>;
+ };
+ };
+ };
+ };
+
+ lvds0: lvds@feb90000 {
+ compatible = "renesas,r8a77970-lvds";
+ reg = <0 0xfeb90000 0 0x14>;
+ clocks = <&cpg CPG_MOD 727>;
+ power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
+ resets = <&cpg 727>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ lvds0_in: endpoint {
+ remote-endpoint = <&du_out_lvds0>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ lvds0_out: endpoint {
};
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: renesas: r8a77970: add LVDS support
2018-04-10 10:54 ` [PATCH v2 3/4] arm64: dts: renesas: r8a77970: add LVDS support Jacopo Mondi
@ 2018-04-10 12:02 ` Sergei Shtylyov
2018-04-10 12:13 ` jacopo mondi
0 siblings, 1 reply; 11+ messages in thread
From: Sergei Shtylyov @ 2018-04-10 12:02 UTC (permalink / raw)
To: Jacopo Mondi, horms, magnus.damm, geert, laurent.pinchart,
niklas.soderlund
Cc: linux-renesas-soc, devicetree, linux-kernel, Niklas Söderlund
On 04/10/2018 01:54 PM, Jacopo Mondi wrote:
> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect
> the it to the LVDS output of the DU.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> ---
> v1 -> v2:
> - Rebased on the modified endpoint name and changed patch subject to
> comply with other patches in the series from Sergei.
Stop, what was wrong with my R8A77970 LVDS patch, reposted on the popular
demand? :-)
MBR, Sergei
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: renesas: r8a77970: add LVDS support
2018-04-10 12:02 ` Sergei Shtylyov
@ 2018-04-10 12:13 ` jacopo mondi
2018-04-10 17:12 ` Sergei Shtylyov
0 siblings, 1 reply; 11+ messages in thread
From: jacopo mondi @ 2018-04-10 12:13 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Jacopo Mondi, horms, magnus.damm, geert, laurent.pinchart,
niklas.soderlund, linux-renesas-soc, devicetree, linux-kernel,
Niklas Söderlund
[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]
Hi Sergei,
On Tue, Apr 10, 2018 at 03:02:39PM +0300, Sergei Shtylyov wrote:
> On 04/10/2018 01:54 PM, Jacopo Mondi wrote:
>
> > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> >
> > Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect
> > the it to the LVDS output of the DU.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > ---
> > v1 -> v2:
> > - Rebased on the modified endpoint name and changed patch subject to
> > comply with other patches in the series from Sergei.
>
> Stop, what was wrong with my R8A77970 LVDS patch, reposted on the popular
> demand? :-)
>
Nothing wrong, I found out about your right now.
I see a very small difference as
lvds@feb90000 vs lvds-encoder@feb90000
You can add your signed-off-by ofc if you think that's the case.
Thanks
j
> MBR, Sergei
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: renesas: r8a77970: add LVDS support
2018-04-10 12:13 ` jacopo mondi
@ 2018-04-10 17:12 ` Sergei Shtylyov
2018-04-11 9:53 ` jacopo mondi
0 siblings, 1 reply; 11+ messages in thread
From: Sergei Shtylyov @ 2018-04-10 17:12 UTC (permalink / raw)
To: jacopo mondi
Cc: Jacopo Mondi, horms, magnus.damm, geert, laurent.pinchart,
niklas.soderlund, linux-renesas-soc, devicetree, linux-kernel,
Niklas Söderlund
On 04/10/2018 03:13 PM, jacopo mondi wrote:
>>> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>>>
>>> Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect
>>> the it to the LVDS output of the DU.
>>>
>>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>>
>>> ---
>>> v1 -> v2:
>>> - Rebased on the modified endpoint name and changed patch subject to
>>> comply with other patches in the series from Sergei.
>>
>> Stop, what was wrong with my R8A77970 LVDS patch, reposted on the popular
>> demand? :-)
>>
>
> Nothing wrong, I found out about your right now.
> I see a very small difference as
> lvds@feb90000 vs lvds-encoder@feb90000
Yes, I thought the latter was closer to a "generic" name that DT spec requires...
> You can add your signed-off-by ofc if you think that's the case.
Didn't understand what you mean here...
> Thanks
> j
MBR, Sergei
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: renesas: r8a77970: add LVDS support
2018-04-10 17:12 ` Sergei Shtylyov
@ 2018-04-11 9:53 ` jacopo mondi
2018-04-11 10:33 ` niklas soderlund
0 siblings, 1 reply; 11+ messages in thread
From: jacopo mondi @ 2018-04-11 9:53 UTC (permalink / raw)
To: Sergei Shtylyov, niklas soderlund
Cc: Jacopo Mondi, horms, magnus.damm, geert, laurent.pinchart,
niklas.soderlund, linux-renesas-soc, devicetree, linux-kernel,
Niklas Söderlund
[-- Attachment #1: Type: text/plain, Size: 2135 bytes --]
Hi Sergei, Niklas
On Tue, Apr 10, 2018 at 08:12:36PM +0300, Sergei Shtylyov wrote:
> On 04/10/2018 03:13 PM, jacopo mondi wrote:
>
> >>> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> >>>
> >>> Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect
> >>> the it to the LVDS output of the DU.
> >>>
> >>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> >>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >>>
> >>> ---
> >>> v1 -> v2:
> >>> - Rebased on the modified endpoint name and changed patch subject to
> >>> comply with other patches in the series from Sergei.
> >>
> >> Stop, what was wrong with my R8A77970 LVDS patch, reposted on the popular
> >> demand? :-)
> >>
> >
> > Nothing wrong, I found out about your right now.
> > I see a very small difference as
> > lvds@feb90000 vs lvds-encoder@feb90000
>
> Yes, I thought the latter was closer to a "generic" name that DT spec requires...
>
> > You can add your signed-off-by ofc if you think that's the case.
>
> Didn't understand what you mean here...
Don't worry, I will resend this and use (part of) your series
[PATCH v2 0/5] Add R8A77970/V3MSK LVDS/HDMI support
But please note that:
[1/5] from your series has already been collected by Simon
I have to reapply Laurent's comment on this series to your one (so I
have to resend it anyhow)
[5/5] from your series shall be resent to take into account the newly
developed LVDS decoder driver (once it has been accepted)
I have anyway to repost your patches then, and as I did in this series
you are ofc listed as author already, so I have missed what's the
difference actually except from LVDS patch I collected from Niklas and not
from your series.
Niklas I picked up patches 1-3 of this series from your tree.
1 and 2 are patches from Sergei's series
3 is from you but was also in Sergei's series and I picked yours as it
was there already. Can I rebase on top of Sergei's one instead?
Thanks
j
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: renesas: r8a77970: add LVDS support
2018-04-11 9:53 ` jacopo mondi
@ 2018-04-11 10:33 ` niklas soderlund
0 siblings, 0 replies; 11+ messages in thread
From: niklas soderlund @ 2018-04-11 10:33 UTC (permalink / raw)
To: jacopo mondi
Cc: Sergei Shtylyov, Jacopo Mondi, horms, magnus.damm, geert,
laurent.pinchart, linux-renesas-soc, devicetree, linux-kernel
Hi Jacopo, Sergei,
On 2018-04-11 11:53:28 +0200, Jacopo Mondi wrote:
> Hi Sergei, Niklas
>
> On Tue, Apr 10, 2018 at 08:12:36PM +0300, Sergei Shtylyov wrote:
> > On 04/10/2018 03:13 PM, jacopo mondi wrote:
> >
> > >>> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > >>>
> > >>> Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect
> > >>> the it to the LVDS output of the DU.
> > >>>
> > >>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > >>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >>>
> > >>> ---
> > >>> v1 -> v2:
> > >>> - Rebased on the modified endpoint name and changed patch subject to
> > >>> comply with other patches in the series from Sergei.
> > >>
> > >> Stop, what was wrong with my R8A77970 LVDS patch, reposted on the popular
> > >> demand? :-)
> > >>
> > >
> > > Nothing wrong, I found out about your right now.
> > > I see a very small difference as
> > > lvds@feb90000 vs lvds-encoder@feb90000
> >
> > Yes, I thought the latter was closer to a "generic" name that DT spec requires...
> >
> > > You can add your signed-off-by ofc if you think that's the case.
> >
> > Didn't understand what you mean here...
>
> Don't worry, I will resend this and use (part of) your series
> [PATCH v2 0/5] Add R8A77970/V3MSK LVDS/HDMI support
>
> But please note that:
> [1/5] from your series has already been collected by Simon
> I have to reapply Laurent's comment on this series to your one (so I
> have to resend it anyhow)
> [5/5] from your series shall be resent to take into account the newly
> developed LVDS decoder driver (once it has been accepted)
>
> I have anyway to repost your patches then, and as I did in this series
> you are ofc listed as author already, so I have missed what's the
> difference actually except from LVDS patch I collected from Niklas and not
> from your series.
>
> Niklas I picked up patches 1-3 of this series from your tree.
> 1 and 2 are patches from Sergei's series
> 3 is from you but was also in Sergei's series and I picked yours as it
> was there already. Can I rebase on top of Sergei's one instead?
Yes please do so. And sorry for this mess, it is my fault as I missed
one of Sergei's patches when integrating changes I made to
r8a77970-eagle.dts. For this series always pick Sergei's patches over
mine :-)
Once more sorry for the mess to both of you.
>
> Thanks
> j
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 4/4] arm64: dts: renesas: eagle: Enable HDMI output
2018-04-10 10:54 [PATCH v2 0/4] V3M-Eagle HDMI output enablement Jacopo Mondi
` (2 preceding siblings ...)
2018-04-10 10:54 ` [PATCH v2 3/4] arm64: dts: renesas: r8a77970: add LVDS support Jacopo Mondi
@ 2018-04-10 10:54 ` Jacopo Mondi
2018-04-10 12:39 ` Laurent Pinchart
3 siblings, 1 reply; 11+ messages in thread
From: Jacopo Mondi @ 2018-04-10 10:54 UTC (permalink / raw)
To: horms, magnus.damm, geert, laurent.pinchart, niklas.soderlund,
sergei.shtylyov
Cc: Jacopo Mondi, linux-renesas-soc, devicetree, linux-kernel,
Niklas Söderlund
Enable HDMI output on Renesas R-Car V3M Eagle board.
The HDMI output is enabled connecting the DU LVDS output to the
transparent LVDS converter THC63LVD1024, and successively routing its
RGB output to the ADV7511W HDMI encoder.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
[for THC63LVD1024: ]
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
---
v1 -> v2:
- Squash patches [5/7], [6/7] and [7/7] of v1 in a single patch as
suggested by Laurent
- Remove DU pinmuxing as it is used for DU parallel RGB output only used
by Eagle's display expander board not enabled by this series.
---
arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 93 ++++++++++++++++++++++++++
1 file changed, 93 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
index 3c5f598..1e2191d 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
@@ -31,6 +31,51 @@
/* first 128MB is reserved for secure area. */
reg = <0x0 0x48000000 0x0 0x38000000>;
};
+
+ hdmi-out {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_con_out: endpoint {
+ remote-endpoint = <&adv7511_out>;
+ };
+ };
+ };
+
+ d3p3: regulator-fixed {
+ compatible = "regulator-fixed";
+ regulator-name = "fixed-3.3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ thc63lvd1024: lvds-decoder {
+ compatible = "thine,thc63lvd1024";
+
+ vcc-supply = <&d3p3>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ thc63lvd1024_in: endpoint {
+ remote-endpoint = <&lvds0_out>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+ thc63lvd1024_out: endpoint {
+ remote-endpoint = <&adv7511_in>;
+ };
+ };
+ };
+ };
};
&avb {
@@ -68,6 +113,38 @@
gpio-controller;
#gpio-cells = <2>;
};
+
+ hdmi@39 {
+ compatible = "adi,adv7511w";
+ reg = <0x39>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
+
+ adi,input-depth = <8>;
+ adi,input-colorspace = "rgb";
+ adi,input-clock = "1x";
+ adi,input-style = <1>;
+ adi,input-justification = "evenly";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ adv7511_in: endpoint {
+ remote-endpoint = <&thc63lvd1024_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ adv7511_out: endpoint {
+ remote-endpoint = <&hdmi_con_out>;
+ };
+ };
+ };
+ };
};
&pfc {
@@ -93,3 +170,19 @@
status = "okay";
};
+
+&du {
+ status = "okay";
+};
+
+&lvds0 {
+ status = "okay";
+
+ ports {
+ port@1 {
+ lvds0_out: endpoint {
+ remote-endpoint = <&thc63lvd1024_in>;
+ };
+ };
+ };
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 4/4] arm64: dts: renesas: eagle: Enable HDMI output
2018-04-10 10:54 ` [PATCH v2 4/4] arm64: dts: renesas: eagle: Enable HDMI output Jacopo Mondi
@ 2018-04-10 12:39 ` Laurent Pinchart
0 siblings, 0 replies; 11+ messages in thread
From: Laurent Pinchart @ 2018-04-10 12:39 UTC (permalink / raw)
To: Jacopo Mondi
Cc: horms, magnus.damm, geert, niklas.soderlund, sergei.shtylyov,
linux-renesas-soc, devicetree, linux-kernel,
Niklas Söderlund
Hi Jacopo,
Thank you for the patch.
On Tuesday, 10 April 2018 13:54:06 EEST Jacopo Mondi wrote:
> Enable HDMI output on Renesas R-Car V3M Eagle board.
>
> The HDMI output is enabled connecting the DU LVDS output to the
> transparent LVDS converter THC63LVD1024, and successively routing its
> RGB output to the ADV7511W HDMI encoder.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> [for THC63LVD1024: ]
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
>
> ---
> v1 -> v2:
> - Squash patches [5/7], [6/7] and [7/7] of v1 in a single patch as
> suggested by Laurent
> - Remove DU pinmuxing as it is used for DU parallel RGB output only used
> by Eagle's display expander board not enabled by this series.
> ---
> arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 93 +++++++++++++++++++++++
> 1 file changed, 93 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts index 3c5f598..1e2191d
> 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> @@ -31,6 +31,51 @@
> /* first 128MB is reserved for secure area. */
> reg = <0x0 0x48000000 0x0 0x38000000>;
> };
> +
> + hdmi-out {
> + compatible = "hdmi-connector";
> + type = "a";
> +
> + port {
> + hdmi_con_out: endpoint {
> + remote-endpoint = <&adv7511_out>;
> + };
> + };
> + };
> +
> + d3p3: regulator-fixed {
> + compatible = "regulator-fixed";
> + regulator-name = "fixed-3.3V";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + thc63lvd1024: lvds-decoder {
Nitpicking, no need for a label, you never reference it.
Apart from that, you can keep my Reviewed-by.
> + compatible = "thine,thc63lvd1024";
> +
> + vcc-supply = <&d3p3>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + thc63lvd1024_in: endpoint {
> + remote-endpoint = <&lvds0_out>;
> + };
> + };
> +
> + port@2 {
> + reg = <2>;
> + thc63lvd1024_out: endpoint {
> + remote-endpoint = <&adv7511_in>;
> + };
> + };
> + };
> + };
> };
>
> &avb {
> @@ -68,6 +113,38 @@
> gpio-controller;
> #gpio-cells = <2>;
> };
> +
> + hdmi@39 {
> + compatible = "adi,adv7511w";
> + reg = <0x39>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
> +
> + adi,input-depth = <8>;
> + adi,input-colorspace = "rgb";
> + adi,input-clock = "1x";
> + adi,input-style = <1>;
> + adi,input-justification = "evenly";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + adv7511_in: endpoint {
> + remote-endpoint = <&thc63lvd1024_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + adv7511_out: endpoint {
> + remote-endpoint = <&hdmi_con_out>;
> + };
> + };
> + };
> + };
> };
>
> &pfc {
> @@ -93,3 +170,19 @@
>
> status = "okay";
> };
> +
> +&du {
> + status = "okay";
> +};
> +
> +&lvds0 {
> + status = "okay";
> +
> + ports {
> + port@1 {
> + lvds0_out: endpoint {
> + remote-endpoint = <&thc63lvd1024_in>;
> + };
> + };
> + };
> +};
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 11+ messages in thread