From: Micah Parrish <micah.parrish@hpe.com>
To: linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Kieulien.Dang@seagate.com,
jeffrey.wang@seagate.com, keith.busch@intel.com,
pragyansri.pathi@intel.com, micah.parrish@hpe.com
Subject: [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage
Date: Thu, 12 Apr 2018 13:25:25 -0600 [thread overview]
Message-ID: <1523561125-31945-1-git-send-email-micah.parrish@hpe.com> (raw)
Add Seagate Nytro Flash Storage nvme drive to quirk list for
NVME_QUIRK_DELAY_BEFORE_CHK_RDY, which solves a bug where the drive is
probed on hot-add before the firmare is ready, I/O errors are generated
while reading sector 0, and linux is "unable to read partition table".
This has occurred when the drive is in an NVME drive slot adjacent to an
Intel drive.
Intel (Keith Busch and Pragyan Pathi) and Seagate (Jeffery Wang
and Kieulien Dang) agreed to add this quirk in off-list discussion.
Signed-off-by: micah.parrish@hpe.com
--- linux/drivers/nvme/host/pci.c.orig 2018-04-05 13:52:23.048890019 -0600
+++ linux/drivers/nvme/host/pci.c 2018-04-09 11:20:57.432900569 -0600
@@ -2687,6 +2687,8 @@ static const struct pci_device_id nvme_i
.driver_data = NVME_QUIRK_NO_DEEPEST_PS },
{ PCI_VDEVICE(INTEL, 0x5845), /* Qemu emulated controller */
.driver_data = NVME_QUIRK_IDENTIFY_CNS, },
+ { PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */
+ .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
{ PCI_DEVICE(0x1c58, 0x0003), /* HGST adapter */
.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
{ PCI_DEVICE(0x1c58, 0x0023), /* WDC SN200 adapter */
next reply other threads:[~2018-04-12 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 19:25 Micah Parrish [this message]
2018-04-12 21:28 ` [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage Martin K. Petersen
2018-04-12 21:40 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523561125-31945-1-git-send-email-micah.parrish@hpe.com \
--to=micah.parrish@hpe.com \
--cc=Kieulien.Dang@seagate.com \
--cc=jeffrey.wang@seagate.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=pragyansri.pathi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).