* [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage
@ 2018-04-12 19:25 Micah Parrish
2018-04-12 21:28 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: Micah Parrish @ 2018-04-12 19:25 UTC (permalink / raw)
To: linux-nvme
Cc: linux-kernel, Kieulien.Dang, jeffrey.wang, keith.busch,
pragyansri.pathi, micah.parrish
Add Seagate Nytro Flash Storage nvme drive to quirk list for
NVME_QUIRK_DELAY_BEFORE_CHK_RDY, which solves a bug where the drive is
probed on hot-add before the firmare is ready, I/O errors are generated
while reading sector 0, and linux is "unable to read partition table".
This has occurred when the drive is in an NVME drive slot adjacent to an
Intel drive.
Intel (Keith Busch and Pragyan Pathi) and Seagate (Jeffery Wang
and Kieulien Dang) agreed to add this quirk in off-list discussion.
Signed-off-by: micah.parrish@hpe.com
--- linux/drivers/nvme/host/pci.c.orig 2018-04-05 13:52:23.048890019 -0600
+++ linux/drivers/nvme/host/pci.c 2018-04-09 11:20:57.432900569 -0600
@@ -2687,6 +2687,8 @@ static const struct pci_device_id nvme_i
.driver_data = NVME_QUIRK_NO_DEEPEST_PS },
{ PCI_VDEVICE(INTEL, 0x5845), /* Qemu emulated controller */
.driver_data = NVME_QUIRK_IDENTIFY_CNS, },
+ { PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */
+ .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
{ PCI_DEVICE(0x1c58, 0x0003), /* HGST adapter */
.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
{ PCI_DEVICE(0x1c58, 0x0023), /* WDC SN200 adapter */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage
2018-04-12 19:25 [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage Micah Parrish
@ 2018-04-12 21:28 ` Martin K. Petersen
2018-04-12 21:40 ` Keith Busch
0 siblings, 1 reply; 3+ messages in thread
From: Martin K. Petersen @ 2018-04-12 21:28 UTC (permalink / raw)
To: Micah Parrish
Cc: linux-nvme, linux-kernel, keith.busch, pragyansri.pathi,
jeffrey.wang, Kieulien.Dang
Micah,
> Add Seagate Nytro Flash Storage nvme drive to quirk list for
> NVME_QUIRK_DELAY_BEFORE_CHK_RDY, which solves a bug where the drive is
> probed on hot-add before the firmare is ready, I/O errors are generated
> while reading sector 0, and linux is "unable to read partition table".
Looks fine.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage
2018-04-12 21:28 ` Martin K. Petersen
@ 2018-04-12 21:40 ` Keith Busch
0 siblings, 0 replies; 3+ messages in thread
From: Keith Busch @ 2018-04-12 21:40 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Micah Parrish, linux-nvme, linux-kernel, pragyansri.pathi,
jeffrey.wang, Kieulien.Dang
Thanks, applied for 4.17-rc1.
I was a little surprised git was able to apply this since the patch
format is off, but it worked!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-12 21:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 19:25 [PATCH] NVMe: Add Quirk Delay before CHK RDY for Seagate Nytro Flash Storage Micah Parrish
2018-04-12 21:28 ` Martin K. Petersen
2018-04-12 21:40 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).