linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chintan Pandya <cpandya@codeaurora.org>
To: vbabka@suse.cz, labbott@redhat.com, catalin.marinas@arm.com,
	hannes@cmpxchg.org, f.fainelli@gmail.com, xieyisheng1@huawei.com,
	ard.biesheuvel@linaro.org, richard.weiyang@gmail.com,
	byungchul.park@lge.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Chintan Pandya <cpandya@codeaurora.org>
Subject: [PATCH 2/2] mm: vmalloc: Pass proper vm_start into debugobjects
Date: Fri, 13 Apr 2018 17:03:54 +0530	[thread overview]
Message-ID: <1523619234-17635-3-git-send-email-cpandya@codeaurora.org> (raw)
In-Reply-To: <1523619234-17635-1-git-send-email-cpandya@codeaurora.org>

Client can call vunmap with some intermediate 'addr'
which may not be the start of the VM area. Entire
unmap code works with vm->vm_start which is proper
but debug object API is called with 'addr'. This
could be a problem within debug objects.

Pass proper start address into debug object API.

Signed-off-by: Chintan Pandya <cpandya@codeaurora.org>
---
 mm/vmalloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 9ff21a1..28034c55 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1526,8 +1526,8 @@ static void __vunmap(const void *addr, int deallocate_pages)
 		return;
 	}
 
-	debug_check_no_locks_freed(addr, get_vm_area_size(area));
-	debug_check_no_obj_freed(addr, get_vm_area_size(area));
+	debug_check_no_locks_freed(area->addr, get_vm_area_size(area));
+	debug_check_no_obj_freed(area->addr, get_vm_area_size(area));
 
 	remove_vm_area(addr);
 	if (deallocate_pages) {
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation
Center, Inc., is a member of Code Aurora Forum, a Linux Foundation
Collaborative Project

  parent reply	other threads:[~2018-04-13 11:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13 11:33 [PATCH 0/2] vunmap and debug objects Chintan Pandya
2018-04-13 11:33 ` [PATCH 1/2] mm: vmalloc: Avoid racy handling of debugobjects in vunmap Chintan Pandya
2018-04-13 11:33 ` Chintan Pandya [this message]
2018-04-13 12:01   ` [PATCH 2/2] mm: vmalloc: Pass proper vm_start into debugobjects Anshuman Khandual
2018-04-16 12:09     ` Chintan Pandya
2018-04-17  3:09       ` Anshuman Khandual
2018-04-17  5:10         ` Chintan Pandya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1523619234-17635-3-git-send-email-cpandya@codeaurora.org \
    --to=cpandya@codeaurora.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=byungchul.park@lge.com \
    --cc=catalin.marinas@arm.com \
    --cc=f.fainelli@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=richard.weiyang@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=xieyisheng1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).