From: Chintan Pandya <cpandya@codeaurora.org>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
vbabka@suse.cz, labbott@redhat.com, catalin.marinas@arm.com,
hannes@cmpxchg.org, f.fainelli@gmail.com, xieyisheng1@huawei.com,
ard.biesheuvel@linaro.org, richard.weiyang@gmail.com,
byungchul.park@lge.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: vmalloc: Pass proper vm_start into debugobjects
Date: Tue, 17 Apr 2018 10:40:57 +0530 [thread overview]
Message-ID: <89438471-6e47-cb70-8909-0ffcc2d3e313@codeaurora.org> (raw)
In-Reply-To: <e8d4c0b2-dfb5-8d4d-3bcc-30b8915d24cb@linux.vnet.ibm.com>
On 4/17/2018 8:39 AM, Anshuman Khandual wrote:
> On 04/16/2018 05:39 PM, Chintan Pandya wrote:
>>
>>
>> On 4/13/2018 5:31 PM, Anshuman Khandual wrote:
>>> On 04/13/2018 05:03 PM, Chintan Pandya wrote:
>>>> Client can call vunmap with some intermediate 'addr'
>>>> which may not be the start of the VM area. Entire
>>>> unmap code works with vm->vm_start which is proper
>>>> but debug object API is called with 'addr'. This
>>>> could be a problem within debug objects.
>>>>
>>>> Pass proper start address into debug object API.
>>>>
>>>> Signed-off-by: Chintan Pandya <cpandya@codeaurora.org>
>>>> ---
>>>> mm/vmalloc.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
>>>> index 9ff21a1..28034c55 100644
>>>> --- a/mm/vmalloc.c
>>>> +++ b/mm/vmalloc.c
>>>> @@ -1526,8 +1526,8 @@ static void __vunmap(const void *addr, int
>>>> deallocate_pages)
>>>> return;
>>>> }
>>>> - debug_check_no_locks_freed(addr, get_vm_area_size(area));
>>>> - debug_check_no_obj_freed(addr, get_vm_area_size(area));
>>>> + debug_check_no_locks_freed(area->addr, get_vm_area_size(area));
>>>> + debug_check_no_obj_freed(area->addr, get_vm_area_size(area));
>>>
>>> This kind of makes sense to me but I am not sure. We also have another
>>> instance of this inside the function vm_unmap_ram() where we call for
>> Right, I missed it. I plan to add below stub in v2.
>>
>> --- a/mm/vmalloc.c
>> +++ b/mm/vmalloc.c
>> @@ -1124,15 +1124,15 @@ void vm_unmap_ram(const void *mem, unsigned int
>> count)
>> BUG_ON(addr > VMALLOC_END);
>> BUG_ON(!PAGE_ALIGNED(addr));
>>
>> - debug_check_no_locks_freed(mem, size);
>> -
>> if (likely(count <= VMAP_MAX_ALLOC)) {
>> + debug_check_no_locks_freed(mem, size);
>
> It should have been 'va->va_start' instead of 'mem' in here but as
> said before it looks correct to me but I am not really sure.
vb_free() doesn't honor va->va_start. If mem is not va_start and
deliberate, one will provide proper size. And that should be okay
to do as per the code. So, I don't think this particular debug_check
should have passed va_start in args.
>
Chintan
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation
Collaborative Project
prev parent reply other threads:[~2018-04-17 5:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 11:33 [PATCH 0/2] vunmap and debug objects Chintan Pandya
2018-04-13 11:33 ` [PATCH 1/2] mm: vmalloc: Avoid racy handling of debugobjects in vunmap Chintan Pandya
2018-04-13 11:33 ` [PATCH 2/2] mm: vmalloc: Pass proper vm_start into debugobjects Chintan Pandya
2018-04-13 12:01 ` Anshuman Khandual
2018-04-16 12:09 ` Chintan Pandya
2018-04-17 3:09 ` Anshuman Khandual
2018-04-17 5:10 ` Chintan Pandya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89438471-6e47-cb70-8909-0ffcc2d3e313@codeaurora.org \
--to=cpandya@codeaurora.org \
--cc=ard.biesheuvel@linaro.org \
--cc=byungchul.park@lge.com \
--cc=catalin.marinas@arm.com \
--cc=f.fainelli@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
--cc=vbabka@suse.cz \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).