* [PATCH] ARM: dts: imx6qdl-phytec-pfla02: Use IRQ_TYPE specifier
@ 2018-05-13 23:28 Hernán Gonzalez
2018-05-15 7:12 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Hernán Gonzalez @ 2018-05-13 23:28 UTC (permalink / raw)
To: shawnguo
Cc: s.hauer, kernel, fabio.estevam, robh+dt, mark.rutland,
linux-arm-kernel, devicetree, linux-kernel, Hernán Gonzalez
Replace magic number with the proper IRQ_TYPE specifier to improve DT
readability.
Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar>
---
arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
index c58f344..1b79ee7 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
@@ -115,7 +115,7 @@
compatible = "dlg,da9063";
reg = <0x58>;
interrupt-parent = <&gpio2>;
- interrupts = <9 0x8>; /* active-low GPIO2_9 */
+ interrupts = <9 IRQ_TYPE_LOW_LEVEL>; /* active-low GPIO2_9 */
regulators {
vddcore_reg: bcore1 {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: dts: imx6qdl-phytec-pfla02: Use IRQ_TYPE specifier
2018-05-13 23:28 [PATCH] ARM: dts: imx6qdl-phytec-pfla02: Use IRQ_TYPE specifier Hernán Gonzalez
@ 2018-05-15 7:12 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2018-05-15 7:12 UTC (permalink / raw)
To: Hernán Gonzalez
Cc: s.hauer, kernel, fabio.estevam, robh+dt, mark.rutland,
linux-arm-kernel, devicetree, linux-kernel
On Sun, May 13, 2018 at 08:28:35PM -0300, Hernán Gonzalez wrote:
> Replace magic number with the proper IRQ_TYPE specifier to improve DT
> readability.
>
> Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar>
> ---
> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index c58f344..1b79ee7 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -115,7 +115,7 @@
> compatible = "dlg,da9063";
> reg = <0x58>;
> interrupt-parent = <&gpio2>;
> - interrupts = <9 0x8>; /* active-low GPIO2_9 */
> + interrupts = <9 IRQ_TYPE_LOW_LEVEL>; /* active-low GPIO2_9 */
It should be IRQ_TYPE_LEVEL_LOW. I fixed it up and applied the patch.
Shawn
>
> regulators {
> vddcore_reg: bcore1 {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-15 7:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-13 23:28 [PATCH] ARM: dts: imx6qdl-phytec-pfla02: Use IRQ_TYPE specifier Hernán Gonzalez
2018-05-15 7:12 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).