* [PATCH 0/3] drivers/w1/masters/ds2490: Correct errors reported by checkpatch
@ 2018-06-14 15:20 Henriette Hofmeier
2018-06-14 15:20 ` [PATCH 1/3] ds2490.c: Add required spaces Henriette Hofmeier
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Henriette Hofmeier @ 2018-06-14 15:20 UTC (permalink / raw)
To: devel
Cc: zbr, arvind.yadav.cs, gregkh, linux-kernel, Henriette Hofmeier,
florian.harbecke
Remove unnecessary spaces, add required spaced and
move braces to fix errors reported by checkpatch.
Henriette Hofmeier (3):
ds2490.c: Add required spaces
ds2490.c: Remove unnecessary whitespace
ds2490.c: Move struct open braces to previous line
drivers/w1/masters/ds2490.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] ds2490.c: Add required spaces
2018-06-14 15:20 [PATCH 0/3] drivers/w1/masters/ds2490: Correct errors reported by checkpatch Henriette Hofmeier
@ 2018-06-14 15:20 ` Henriette Hofmeier
2018-06-14 15:20 ` [PATCH 2/3] ds2490.c: Remove unnecessary whitespace Henriette Hofmeier
2018-06-14 15:20 ` [PATCH 3/3] ds2490.c: Move struct open braces to previous line Henriette Hofmeier
2 siblings, 0 replies; 4+ messages in thread
From: Henriette Hofmeier @ 2018-06-14 15:20 UTC (permalink / raw)
To: devel
Cc: zbr, arvind.yadav.cs, gregkh, linux-kernel, Henriette Hofmeier,
Florian Harbecke
Add missing spaces in for- and while-loops
reported missing by checkpatch.
Signed-off-by: Henriette Hofmeier <passt@h-hofmeier.de>
Signed-off-by: Florian Harbecke <florian.harbecke@fau.de>
---
drivers/w1/masters/ds2490.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c
index c423bdb..917a5f1 100644
--- a/drivers/w1/masters/ds2490.c
+++ b/drivers/w1/masters/ds2490.c
@@ -236,7 +236,7 @@ static void ds_dump_status(struct ds_device *dev, unsigned char *buf, int count)
int i;
pr_info("0x%x: count=%d, status: ", dev->ep[EP_STATUS], count);
- for (i=0; i<count; ++i)
+ for (i = 0; i < count; ++i)
pr_info("%02x ", buf[i]);
pr_info("\n");
@@ -358,7 +358,7 @@ static int ds_recv_data(struct ds_device *dev, unsigned char *buf, int size)
int i;
printk("%s: count=%d: ", __func__, count);
- for (i=0; i<count; ++i)
+ for (i = 0; i < count; ++i)
printk("%02x ", buf[i]);
printk("\n");
}
@@ -404,7 +404,7 @@ int ds_stop_pulse(struct ds_device *dev, int limit)
if (err)
break;
}
- } while(++count < limit);
+ } while (++count < limit);
return err;
}
@@ -447,7 +447,7 @@ static int ds_wait_status(struct ds_device *dev, struct ds_status *st)
if (err >= 0) {
int i;
printk("0x%x: count=%d, status: ", dev->ep[EP_STATUS], err);
- for (i=0; i<err; ++i)
+ for (i = 0; i < err; ++i)
printk("%02x ", dev->st_buf[i]);
printk("\n");
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] ds2490.c: Remove unnecessary whitespace
2018-06-14 15:20 [PATCH 0/3] drivers/w1/masters/ds2490: Correct errors reported by checkpatch Henriette Hofmeier
2018-06-14 15:20 ` [PATCH 1/3] ds2490.c: Add required spaces Henriette Hofmeier
@ 2018-06-14 15:20 ` Henriette Hofmeier
2018-06-14 15:20 ` [PATCH 3/3] ds2490.c: Move struct open braces to previous line Henriette Hofmeier
2 siblings, 0 replies; 4+ messages in thread
From: Henriette Hofmeier @ 2018-06-14 15:20 UTC (permalink / raw)
To: devel
Cc: zbr, arvind.yadav.cs, gregkh, linux-kernel, Henriette Hofmeier,
Florian Harbecke
Remove unnecessary whitespace criticized by
checkpatch.
Signed-off-by: Henriette Hofmeier <passt@h-hofmeier.de>
Signed-off-by: Florian Harbecke <florian.harbecke@fau.de>
---
drivers/w1/masters/ds2490.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c
index 917a5f1..1e4b243 100644
--- a/drivers/w1/masters/ds2490.c
+++ b/drivers/w1/masters/ds2490.c
@@ -613,7 +613,7 @@ static int ds_read_byte(struct ds_device *dev, u8 *byte)
int err;
struct ds_status st;
- err = ds_send_control(dev, COMM_BYTE_IO | COMM_IM , 0xff);
+ err = ds_send_control(dev, COMM_BYTE_IO | COMM_IM, 0xff);
if (err)
return err;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] ds2490.c: Move struct open braces to previous line
2018-06-14 15:20 [PATCH 0/3] drivers/w1/masters/ds2490: Correct errors reported by checkpatch Henriette Hofmeier
2018-06-14 15:20 ` [PATCH 1/3] ds2490.c: Add required spaces Henriette Hofmeier
2018-06-14 15:20 ` [PATCH 2/3] ds2490.c: Remove unnecessary whitespace Henriette Hofmeier
@ 2018-06-14 15:20 ` Henriette Hofmeier
2 siblings, 0 replies; 4+ messages in thread
From: Henriette Hofmeier @ 2018-06-14 15:20 UTC (permalink / raw)
To: devel
Cc: zbr, arvind.yadav.cs, gregkh, linux-kernel, Henriette Hofmeier,
Florian Harbecke
Move open braces of two structs to the declaration line,
as criticized by checkpatch.
Signed-off-by: Henriette Hofmeier <passt@h-hofmeier.de>
Signed-off-by: Florian Harbecke <florian.harbecke@fau.de>
---
drivers/w1/masters/ds2490.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c
index 1e4b243..0f4ecfc 100644
--- a/drivers/w1/masters/ds2490.c
+++ b/drivers/w1/masters/ds2490.c
@@ -134,8 +134,7 @@
#define EP_DATA_OUT 2
#define EP_DATA_IN 3
-struct ds_device
-{
+struct ds_device {
struct list_head ds_entry;
struct usb_device *udev;
@@ -158,8 +157,7 @@ struct ds_device
struct w1_bus_master master;
};
-struct ds_status
-{
+struct ds_status {
u8 enable;
u8 speed;
u8 pullup_dur;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-14 15:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-14 15:20 [PATCH 0/3] drivers/w1/masters/ds2490: Correct errors reported by checkpatch Henriette Hofmeier
2018-06-14 15:20 ` [PATCH 1/3] ds2490.c: Add required spaces Henriette Hofmeier
2018-06-14 15:20 ` [PATCH 2/3] ds2490.c: Remove unnecessary whitespace Henriette Hofmeier
2018-06-14 15:20 ` [PATCH 3/3] ds2490.c: Move struct open braces to previous line Henriette Hofmeier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).