* [PATCH] drm/arm/malidp:- Rectify the width and height passed to rotmem_required()
@ 2018-06-15 12:54 Ayan Kumar Halder
2018-06-18 13:09 ` Liviu Dudau
0 siblings, 1 reply; 2+ messages in thread
From: Ayan Kumar Halder @ 2018-06-15 12:54 UTC (permalink / raw)
To: ayan.halder, liviu.dudau, brian.starkey, malidp, airlied,
dri-devel, linux-kernel
Cc: nd
The width and height needs to be swapped
Signed-off-by: Ayan Kumar halder <ayan.halder@arm.com>
Reviewed-by: Brian Starkey <brian.starkey@arm.com>
Reviewed-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
---
drivers/gpu/drm/arm/malidp_planes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
index 377382e..533cdde 100644
--- a/drivers/gpu/drm/arm/malidp_planes.c
+++ b/drivers/gpu/drm/arm/malidp_planes.c
@@ -244,8 +244,8 @@ static int malidp_de_plane_check(struct drm_plane *plane,
if (state->rotation != DRM_MODE_ROTATE_0 || fb->modifier) {
int val;
- val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_h,
- state->crtc_w,
+ val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,
+ state->crtc_h,
fb->format->format,
!!(fb->modifier));
if (val < 0)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/arm/malidp:- Rectify the width and height passed to rotmem_required()
2018-06-15 12:54 [PATCH] drm/arm/malidp:- Rectify the width and height passed to rotmem_required() Ayan Kumar Halder
@ 2018-06-18 13:09 ` Liviu Dudau
0 siblings, 0 replies; 2+ messages in thread
From: Liviu Dudau @ 2018-06-18 13:09 UTC (permalink / raw)
To: Ayan Kumar Halder
Cc: brian.starkey, malidp, airlied, dri-devel, linux-kernel, nd
On Fri, Jun 15, 2018 at 01:54:36PM +0100, Ayan Kumar Halder wrote:
> The width and height needs to be swapped
>
> Signed-off-by: Ayan Kumar halder <ayan.halder@arm.com>
> Reviewed-by: Brian Starkey <brian.starkey@arm.com>
> Reviewed-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> ---
> drivers/gpu/drm/arm/malidp_planes.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index 377382e..533cdde 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -244,8 +244,8 @@ static int malidp_de_plane_check(struct drm_plane *plane,
> if (state->rotation != DRM_MODE_ROTATE_0 || fb->modifier) {
> int val;
>
> - val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_h,
> - state->crtc_w,
> + val = mp->hwdev->hw->rotmem_required(mp->hwdev, state->crtc_w,
> + state->crtc_h,
> fb->format->format,
> !!(fb->modifier));
Ooops, thanks for catching this!
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> if (val < 0)
> --
> 2.7.4
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-18 13:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-15 12:54 [PATCH] drm/arm/malidp:- Rectify the width and height passed to rotmem_required() Ayan Kumar Halder
2018-06-18 13:09 ` Liviu Dudau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).