linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Morten Rasmussen <morten.rasmussen@arm.com>
To: peterz@infradead.org, mingo@redhat.com
Cc: valentin.schneider@arm.com, dietmar.eggemann@arm.com,
	vincent.guittot@linaro.org, gaku.inami.xh@renesas.com,
	linux-kernel@vger.kernel.org,
	Chris Redpath <chris.redpath@arm.com>,
	Morten Rasmussen <morten.rasmussen@arm.com>
Subject: [PATCHv3 9/9] sched/fair: Don't move tasks to lower capacity cpus unless necessary
Date: Wed, 20 Jun 2018 10:05:49 +0100	[thread overview]
Message-ID: <1529485549-5191-10-git-send-email-morten.rasmussen@arm.com> (raw)
In-Reply-To: <1529485549-5191-1-git-send-email-morten.rasmussen@arm.com>

From: Chris Redpath <chris.redpath@arm.com>

When lower capacity CPUs are load balancing and considering to pull
something from a higher capacity group, we should not pull tasks from a
cpu with only one task running as this is guaranteed to impede progress
for that task. If there is more than one task running, load balance in
the higher capacity group would have already made any possible moves to
resolve imbalance and we should make better use of system compute
capacity by moving a task if we still have more than one running.

cc: Ingo Molnar <mingo@redhat.com>
cc: Peter Zijlstra <peterz@infradead.org>

Signed-off-by: Chris Redpath <chris.redpath@arm.com>
Signed-off-by: Morten Rasmussen <morten.rasmussen@arm.com>
---
 kernel/sched/fair.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index aac7b9155bc4..5d612d3906d5 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8796,6 +8796,17 @@ static struct rq *find_busiest_queue(struct lb_env *env,
 
 		capacity = capacity_of(i);
 
+		/*
+		 * For ASYM_CPUCAPACITY domains, don't pick a cpu that could
+		 * eventually lead to active_balancing high->low capacity.
+		 * Higher per-cpu capacity is considered better than balancing
+		 * average load.
+		 */
+		if (env->sd->flags & SD_ASYM_CPUCAPACITY &&
+			capacity_of(env->dst_cpu) < capacity &&
+			rq->nr_running == 1)
+			continue;
+
 		wl = weighted_cpuload(rq);
 
 		/*
-- 
2.7.4


  parent reply	other threads:[~2018-06-20  9:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  9:05 [PATCHv3 0/9] sched/fair: Migrate 'misfit' tasks on asymmetric capacity systems Morten Rasmussen
2018-06-20  9:05 ` [PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations Morten Rasmussen
2018-06-22  8:22   ` Quentin Perret
2018-06-22 14:36     ` Morten Rasmussen
2018-06-27 15:41       ` Dietmar Eggemann
2018-06-28  8:48         ` Morten Rasmussen
2018-06-28 17:16           ` Dietmar Eggemann
2018-07-02  8:36             ` Morten Rasmussen
2018-06-20  9:05 ` [PATCHv3 2/9] sched/fair: Add group_misfit_task load-balance type Morten Rasmussen
2018-06-20  9:05 ` [PATCHv3 3/9] sched: Add sched_group per-cpu max capacity Morten Rasmussen
2018-06-20  9:05 ` [PATCHv3 4/9] sched/fair: Consider misfit tasks when load-balancing Morten Rasmussen
2018-06-20  9:05 ` [PATCHv3 5/9] sched/fair: Kick nohz balance if rq->misfit_task Morten Rasmussen
2018-06-20  9:05 ` [PATCHv3 6/9] sched: Change root_domain->overload type to int Morten Rasmussen
2018-06-20  9:05 ` [PATCHv3 7/9] sched: Wrap rq->rd->overload accesses with READ/WRITE_ONCE Morten Rasmussen
2018-06-20  9:05 ` [PATCHv3 8/9] sched/fair: Set sd->overload when misfit Morten Rasmussen
2018-06-20  9:05 ` Morten Rasmussen [this message]
2018-07-03  2:28 ` [PATCHv3 0/9] sched/fair: Migrate 'misfit' tasks on asymmetric capacity systems Gaku Inami
2018-07-04 10:33   ` Morten Rasmussen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1529485549-5191-10-git-send-email-morten.rasmussen@arm.com \
    --to=morten.rasmussen@arm.com \
    --cc=chris.redpath@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gaku.inami.xh@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).