From: Morten Rasmussen <morten.rasmussen@arm.com>
To: peterz@infradead.org, mingo@redhat.com
Cc: valentin.schneider@arm.com, dietmar.eggemann@arm.com,
vincent.guittot@linaro.org, gaku.inami.xh@renesas.com,
linux-kernel@vger.kernel.org,
Morten Rasmussen <morten.rasmussen@arm.com>
Subject: [PATCHv3 6/9] sched: Change root_domain->overload type to int
Date: Wed, 20 Jun 2018 10:05:46 +0100 [thread overview]
Message-ID: <1529485549-5191-7-git-send-email-morten.rasmussen@arm.com> (raw)
In-Reply-To: <1529485549-5191-1-git-send-email-morten.rasmussen@arm.com>
From: Valentin Schneider <valentin.schneider@arm.com>
sizeof(_Bool) is implementation defined, so let's just go with 'int' as
is done for other structures e.g. sched_domain_shared->has_idle_cores.
cc: Ingo Molnar <mingo@redhat.com>
cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Signed-off-by: Morten Rasmussen <morten.rasmussen@arm.com>
---
kernel/sched/fair.c | 7 +++----
kernel/sched/sched.h | 4 ++--
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b29d53d1e22a..545fa3600894 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8170,7 +8170,7 @@ static bool update_nohz_stats(struct rq *rq, bool force)
static inline void update_sg_lb_stats(struct lb_env *env,
struct sched_group *group, int load_idx,
int local_group, struct sg_lb_stats *sgs,
- bool *overload)
+ int *overload)
{
unsigned long load;
int i, nr_running;
@@ -8195,7 +8195,7 @@ static inline void update_sg_lb_stats(struct lb_env *env,
nr_running = rq->nr_running;
if (nr_running > 1)
- *overload = true;
+ *overload = 1;
#ifdef CONFIG_NUMA_BALANCING
sgs->nr_numa_running += rq->nr_numa_running;
@@ -8354,8 +8354,7 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd
struct sched_group *sg = env->sd->groups;
struct sg_lb_stats *local = &sds->local_stat;
struct sg_lb_stats tmp_sgs;
- int load_idx, prefer_sibling = 0;
- bool overload = false;
+ int load_idx, prefer_sibling, overload = 0;
if (child && child->flags & SD_PREFER_SIBLING)
prefer_sibling = 1;
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 5ed67122cf59..f945edadd2c5 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -689,7 +689,7 @@ struct root_domain {
cpumask_var_t online;
/* Indicate more than one runnable task for any CPU */
- bool overload;
+ int overload;
/*
* The bit corresponding to a CPU gets set here if such CPU has more
@@ -1666,7 +1666,7 @@ static inline void add_nr_running(struct rq *rq, unsigned count)
if (prev_nr < 2 && rq->nr_running >= 2) {
#ifdef CONFIG_SMP
if (!rq->rd->overload)
- rq->rd->overload = true;
+ rq->rd->overload = 1;
#endif
}
--
2.7.4
next prev parent reply other threads:[~2018-06-20 9:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 9:05 [PATCHv3 0/9] sched/fair: Migrate 'misfit' tasks on asymmetric capacity systems Morten Rasmussen
2018-06-20 9:05 ` [PATCHv3 1/9] sched: Add static_key for asymmetric cpu capacity optimizations Morten Rasmussen
2018-06-22 8:22 ` Quentin Perret
2018-06-22 14:36 ` Morten Rasmussen
2018-06-27 15:41 ` Dietmar Eggemann
2018-06-28 8:48 ` Morten Rasmussen
2018-06-28 17:16 ` Dietmar Eggemann
2018-07-02 8:36 ` Morten Rasmussen
2018-06-20 9:05 ` [PATCHv3 2/9] sched/fair: Add group_misfit_task load-balance type Morten Rasmussen
2018-06-20 9:05 ` [PATCHv3 3/9] sched: Add sched_group per-cpu max capacity Morten Rasmussen
2018-06-20 9:05 ` [PATCHv3 4/9] sched/fair: Consider misfit tasks when load-balancing Morten Rasmussen
2018-06-20 9:05 ` [PATCHv3 5/9] sched/fair: Kick nohz balance if rq->misfit_task Morten Rasmussen
2018-06-20 9:05 ` Morten Rasmussen [this message]
2018-06-20 9:05 ` [PATCHv3 7/9] sched: Wrap rq->rd->overload accesses with READ/WRITE_ONCE Morten Rasmussen
2018-06-20 9:05 ` [PATCHv3 8/9] sched/fair: Set sd->overload when misfit Morten Rasmussen
2018-06-20 9:05 ` [PATCHv3 9/9] sched/fair: Don't move tasks to lower capacity cpus unless necessary Morten Rasmussen
2018-07-03 2:28 ` [PATCHv3 0/9] sched/fair: Migrate 'misfit' tasks on asymmetric capacity systems Gaku Inami
2018-07-04 10:33 ` Morten Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529485549-5191-7-git-send-email-morten.rasmussen@arm.com \
--to=morten.rasmussen@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=gaku.inami.xh@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).