* [PATCH 1/4] ARM: dts: imx51-zii-rdu1: Populate RAVE SP EEPROM nodes
2018-06-28 4:24 [PATCH 0/4] RDU1/2 latest supported RAVE SP nodes Andrey Smirnov
@ 2018-06-28 4:24 ` Andrey Smirnov
2018-06-28 4:24 ` [PATCH 2/4] ARM: dts: imx6qdl-zii-rdu2: " Andrey Smirnov
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Andrey Smirnov @ 2018-06-28 4:24 UTC (permalink / raw)
To: Shawn Guo
Cc: Andrey Smirnov, Fabio Estevam, Nikita Yushchenko, Lucas Stach,
cphealy, Rob Herring, Mark Rutland, linux-arm-kernel, devicetree,
linux-kernel
ZII's RDU1s come with up to 3 EEPROMs attached to RAVE SP. Add
corresponding nodes to make them availible.
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: cphealy@gmail.com
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/boot/dts/imx51-zii-rdu1.dts | 29 ++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index ad2445dfa91d..c6da263cf210 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -578,6 +578,8 @@
rave-sp {
compatible = "zii,rave-sp-rdu1";
current-speed = <38400>;
+ #address-cells = <1>;
+ #size-cells = <1>;
watchdog {
compatible = "zii,rave-sp-watchdog";
@@ -590,6 +592,33 @@
pwrbutton {
compatible = "zii,rave-sp-pwrbutton";
};
+
+ eeprom@a3 {
+ compatible = "zii,rave-sp-eeprom";
+ reg = <0xa3 0x2000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ zii,eeprom-name = "dds-eeprom";
+ };
+
+ eeprom@a4 {
+ compatible = "zii,rave-sp-eeprom";
+ reg = <0xa4 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ zii,eeprom-name = "main-eeprom";
+ };
+
+ eeprom@ae {
+ compatible = "zii,rave-sp-eeprom";
+ reg = <0xae 0x200>;
+ zii,eeprom-name = "switch-eeprom";
+ /*
+ * Not all RDU1s have this functionality, so we
+ * rely on the bootloader to enable this
+ */
+ status = "disabled";
+ };
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/4] ARM: dts: imx6qdl-zii-rdu2: Populate RAVE SP EEPROM nodes
2018-06-28 4:24 [PATCH 0/4] RDU1/2 latest supported RAVE SP nodes Andrey Smirnov
2018-06-28 4:24 ` [PATCH 1/4] ARM: dts: imx51-zii-rdu1: Populate RAVE SP EEPROM nodes Andrey Smirnov
@ 2018-06-28 4:24 ` Andrey Smirnov
2018-06-28 4:39 ` Andrey Smirnov
2018-06-28 4:24 ` [PATCH 3/4] ARM: dts: imx6qdl-zii-rdu2: Populate RAVE SP backlight node Andrey Smirnov
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Andrey Smirnov @ 2018-06-28 4:24 UTC (permalink / raw)
To: Shawn Guo
Cc: Andrey Smirnov, Fabio Estevam, Nikita Yushchenko, Lucas Stach,
cphealy, Rob Herring, Mark Rutland, linux-arm-kernel, devicetree,
linux-kernel
ZII's RDU1s come with two EEPROMs attached to RAVE SP. Add
corresponding nodes to make them availible.
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: cphealy@gmail.com
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 19a075aee19e..e4630481d951 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -320,10 +320,28 @@
rave-sp {
compatible = "zii,rave-sp-rdu2";
current-speed = <1000000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
watchdog {
compatible = "zii,rave-sp-watchdog";
};
+
+ eeprom@a3 {
+ compatible = "zii,rave-sp-eeprom";
+ reg = <0xa3 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ zii,eeprom-name = "dds-eeprom";
+ };
+
+ eeprom@a4 {
+ compatible = "zii,rave-sp-eeprom";
+ reg = <0xa4 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ zii,eeprom-name = "main-eeprom";
+ };
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/4] ARM: dts: imx6qdl-zii-rdu2: Populate RAVE SP EEPROM nodes
2018-06-28 4:24 ` [PATCH 2/4] ARM: dts: imx6qdl-zii-rdu2: " Andrey Smirnov
@ 2018-06-28 4:39 ` Andrey Smirnov
2018-07-01 13:48 ` Shawn Guo
0 siblings, 1 reply; 8+ messages in thread
From: Andrey Smirnov @ 2018-06-28 4:39 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, Nikita Yushchenko, Lucas Stach, Chris Healy,
Rob Herring, Mark Rutland, linux-arm-kernel,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Wed, Jun 27, 2018 at 9:24 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
>
> ZII's RDU1s come with two EEPROMs attached to RAVE SP. Add
Ugh, the description should read RDU2, not RDU1. Will fix in v2,
tomorrow. Sorry about that.
Thanks,
Andrey Smirnov
> corresponding nodes to make them availible.
>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: cphealy@gmail.com
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 19a075aee19e..e4630481d951 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -320,10 +320,28 @@
> rave-sp {
> compatible = "zii,rave-sp-rdu2";
> current-speed = <1000000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
>
> watchdog {
> compatible = "zii,rave-sp-watchdog";
> };
> +
> + eeprom@a3 {
> + compatible = "zii,rave-sp-eeprom";
> + reg = <0xa3 0x4000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + zii,eeprom-name = "dds-eeprom";
> + };
> +
> + eeprom@a4 {
> + compatible = "zii,rave-sp-eeprom";
> + reg = <0xa4 0x4000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + zii,eeprom-name = "main-eeprom";
> + };
> };
> };
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/4] ARM: dts: imx6qdl-zii-rdu2: Populate RAVE SP EEPROM nodes
2018-06-28 4:39 ` Andrey Smirnov
@ 2018-07-01 13:48 ` Shawn Guo
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2018-07-01 13:48 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Fabio Estevam, Nikita Yushchenko, Lucas Stach, Chris Healy,
Rob Herring, Mark Rutland, linux-arm-kernel,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
On Wed, Jun 27, 2018 at 09:39:37PM -0700, Andrey Smirnov wrote:
> On Wed, Jun 27, 2018 at 9:24 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
> >
> > ZII's RDU1s come with two EEPROMs attached to RAVE SP. Add
>
> Ugh, the description should read RDU2, not RDU1. Will fix in v2,
> tomorrow. Sorry about that.
I fixed it up and applied the series.
Shawn
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/4] ARM: dts: imx6qdl-zii-rdu2: Populate RAVE SP backlight node
2018-06-28 4:24 [PATCH 0/4] RDU1/2 latest supported RAVE SP nodes Andrey Smirnov
2018-06-28 4:24 ` [PATCH 1/4] ARM: dts: imx51-zii-rdu1: Populate RAVE SP EEPROM nodes Andrey Smirnov
2018-06-28 4:24 ` [PATCH 2/4] ARM: dts: imx6qdl-zii-rdu2: " Andrey Smirnov
@ 2018-06-28 4:24 ` Andrey Smirnov
2018-06-28 4:24 ` [PATCH 4/4] ARM: dts: imx6qdl-zii-rdu2: Populate RAVE SP power button node Andrey Smirnov
2018-06-28 9:53 ` [PATCH 0/4] RDU1/2 latest supported RAVE SP nodes Lucas Stach
4 siblings, 0 replies; 8+ messages in thread
From: Andrey Smirnov @ 2018-06-28 4:24 UTC (permalink / raw)
To: Shawn Guo
Cc: Andrey Smirnov, Fabio Estevam, Nikita Yushchenko, Lucas Stach,
cphealy, Rob Herring, Mark Rutland, linux-arm-kernel, devicetree,
linux-kernel
RAVE SP found on RDU2 implements backlight control compatible with the
rave-sp-backlight driver. Add a node to make it availible.
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: cphealy@gmail.com
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index e4630481d951..48da4b15da09 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -327,6 +327,10 @@
compatible = "zii,rave-sp-watchdog";
};
+ backlight {
+ compatible = "zii,rave-sp-backlight";
+ };
+
eeprom@a3 {
compatible = "zii,rave-sp-eeprom";
reg = <0xa3 0x4000>;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 4/4] ARM: dts: imx6qdl-zii-rdu2: Populate RAVE SP power button node
2018-06-28 4:24 [PATCH 0/4] RDU1/2 latest supported RAVE SP nodes Andrey Smirnov
` (2 preceding siblings ...)
2018-06-28 4:24 ` [PATCH 3/4] ARM: dts: imx6qdl-zii-rdu2: Populate RAVE SP backlight node Andrey Smirnov
@ 2018-06-28 4:24 ` Andrey Smirnov
2018-06-28 9:53 ` [PATCH 0/4] RDU1/2 latest supported RAVE SP nodes Lucas Stach
4 siblings, 0 replies; 8+ messages in thread
From: Andrey Smirnov @ 2018-06-28 4:24 UTC (permalink / raw)
To: Shawn Guo
Cc: Andrey Smirnov, Fabio Estevam, Nikita Yushchenko, Lucas Stach,
cphealy, Rob Herring, Mark Rutland, linux-arm-kernel, devicetree,
linux-kernel
RAVE SP found on RDU2 implements power button control compatible with
the rave-sp-pwrbutton driver. Add a node to make it availible.
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: cphealy@gmail.com
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 48da4b15da09..869dfd8431a1 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -331,6 +331,10 @@
compatible = "zii,rave-sp-backlight";
};
+ pwrbutton {
+ compatible = "zii,rave-sp-pwrbutton";
+ };
+
eeprom@a3 {
compatible = "zii,rave-sp-eeprom";
reg = <0xa3 0x4000>;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 0/4] RDU1/2 latest supported RAVE SP nodes
2018-06-28 4:24 [PATCH 0/4] RDU1/2 latest supported RAVE SP nodes Andrey Smirnov
` (3 preceding siblings ...)
2018-06-28 4:24 ` [PATCH 4/4] ARM: dts: imx6qdl-zii-rdu2: Populate RAVE SP power button node Andrey Smirnov
@ 2018-06-28 9:53 ` Lucas Stach
4 siblings, 0 replies; 8+ messages in thread
From: Lucas Stach @ 2018-06-28 9:53 UTC (permalink / raw)
To: Andrey Smirnov, Shawn Guo
Cc: Fabio Estevam, Nikita Yushchenko, cphealy, Rob Herring,
Mark Rutland, linux-arm-kernel, devicetree, linux-kernel
Am Mittwoch, den 27.06.2018, 21:24 -0700 schrieb Andrey Smirnov:
> Shawn:
>
> These are patches adding the rest of RAVE SP child nodes covering all
> the rest of currently supported MFD cells. There's more to be added,
> once more drivers get accepted upstream.
>
> The bindings three drivers mentioned are availible in:
>
> Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
> Documentation/devicetree/bindings/input/zii,rave-sp-pwrbutton.txt
> Documentation/devicetree/bindings/leds/backlight/zii,rave-sp-backlight.txt
>
> Feedback is welcome!
Apart from the RDU 1/2 mixup you noticed yourself this looks good to
me. Maybe Shawn can just fix this up while applying.
For the series:
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Regards,
Lucas
^ permalink raw reply [flat|nested] 8+ messages in thread