linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: fbtft: fix line indent
@ 2018-06-29 15:20 Radek Dostál
  2018-06-29 18:23 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Radek Dostál @ 2018-06-29 15:20 UTC (permalink / raw)
  To: thomas.petazzoni; +Cc: gregkh, devel, linux-kernel, Radek Dostál

Signed-off-by: Radek Dostál <radek.dostal@streamunlimited.com>
---
 drivers/staging/fbtft/fbtft_device.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c
index 4a54b46..cad244c 100644
--- a/drivers/staging/fbtft/fbtft_device.c
+++ b/drivers/staging/fbtft/fbtft_device.c
@@ -1232,14 +1232,14 @@ static struct fbtft_device_display displays[] = {
 			.name = "",
 			.id = 0,
 			.dev = {
-			.release = fbtft_device_pdev_release,
-			.platform_data = &(struct fbtft_platform_data) {
-				.gpios = (const struct fbtft_gpio []) {
-					{},
+				.release = fbtft_device_pdev_release,
+				.platform_data = &(struct fbtft_platform_data) {
+					.gpios = (const struct fbtft_gpio []) {
+						{},
+					},
 				},
 			},
 		},
-		},
 	}
 };
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: fbtft: fix line indent
  2018-06-29 15:20 [PATCH] staging: fbtft: fix line indent Radek Dostál
@ 2018-06-29 18:23 ` Greg KH
  2018-07-02  7:28   ` [PATCH v2] staging: fbtft: indent fbtft_device_display - last entry - pdev - dev Radek Dostál
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2018-06-29 18:23 UTC (permalink / raw)
  To: Radek Dostál; +Cc: thomas.petazzoni, devel, linux-kernel

On Fri, Jun 29, 2018 at 05:20:32PM +0200, Radek Dostál wrote:
> Signed-off-by: Radek Dostál <radek.dostal@streamunlimited.com>
> ---
>  drivers/staging/fbtft/fbtft_device.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] staging: fbtft: indent fbtft_device_display - last entry - pdev - dev
  2018-06-29 18:23 ` Greg KH
@ 2018-07-02  7:28   ` Radek Dostál
  0 siblings, 0 replies; 3+ messages in thread
From: Radek Dostál @ 2018-07-02  7:28 UTC (permalink / raw)
  To: gregkh; +Cc: thomas.petazzoni, devel, linux-kernel, Radek Dostál

The dev section was opening curly bracket, but not adding ident, which
resulted in two times "}," after each other with same indentation. Add
ident at the right place fixes this problem.

This formatting issue is not detectable by checkpatch.pl

Signed-off-by: Radek Dostál <radek.dostal@streamunlimited.com>
---

Changes in v2:
- Extended commit message.

 drivers/staging/fbtft/fbtft_device.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c
index ec84776..22ba81d 100644
--- a/drivers/staging/fbtft/fbtft_device.c
+++ b/drivers/staging/fbtft/fbtft_device.c
@@ -1223,14 +1223,14 @@ static struct fbtft_device_display displays[] = {
 			.name = "",
 			.id = 0,
 			.dev = {
-			.release = fbtft_device_pdev_release,
-			.platform_data = &(struct fbtft_platform_data) {
-				.gpios = (const struct fbtft_gpio []) {
-					{},
+				.release = fbtft_device_pdev_release,
+				.platform_data = &(struct fbtft_platform_data) {
+					.gpios = (const struct fbtft_gpio []) {
+						{},
+					},
 				},
 			},
 		},
-		},
 	}
 };
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-02  7:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-29 15:20 [PATCH] staging: fbtft: fix line indent Radek Dostál
2018-06-29 18:23 ` Greg KH
2018-07-02  7:28   ` [PATCH v2] staging: fbtft: indent fbtft_device_display - last entry - pdev - dev Radek Dostál

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).